From patchwork Thu Nov 24 18:21:28 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 698970 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3tPndQ4XZ0z9t1B for ; Fri, 25 Nov 2016 05:23:22 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="0JGGEZAR"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S938628AbcKXSWx (ORCPT ); Thu, 24 Nov 2016 13:22:53 -0500 Received: from mail-lf0-f67.google.com ([209.85.215.67]:34290 "EHLO mail-lf0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935509AbcKXSWt (ORCPT ); Thu, 24 Nov 2016 13:22:49 -0500 Received: by mail-lf0-f67.google.com with SMTP id o141so2286903lff.1; Thu, 24 Nov 2016 10:22:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=J+nyQZcPz/YqoNQ7N7YZyLN0J1ShoF7eaVzBeFpF/qQ=; b=0JGGEZARqlLIxgyU67zl5LUgGAw3RVkJZVyDcklIfhLpzNCgBAmwl5cl3YOUi0Ggks RLMStVdveh8z+HhPVMWva+2CgxcSADFR08UoLB0fCfIfJj7SBHap1x1xIfD4Ma/2T3Mp +xJrVUePUXj+1LLZti1DNbp8O6Swv40V1WrJ8MY6bXZndxt+M+0bh2w/SBVygKzRMtjV unpGyd9BtPompIb6YESbVrbEs1NUOuQ2QY0mZmI2qyUh1KWgCR7T1QmmVklqzEVrZd1w i8iTU95ZgN8dqmUiMvQQU1kbxavpV0vDeJJ8qH6XNbEgMvlthti56uIx633ncM4pkG7b xbIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=J+nyQZcPz/YqoNQ7N7YZyLN0J1ShoF7eaVzBeFpF/qQ=; b=b6ffVincrNdfiW27aDzjLDhiZdrCCqWpNeBOkFRZFhEWz5hyXB5ZKOZnSHU+POX+Uv lLsohugw0e9umPze+u9aL6S00tHfX51J6zCnqN7PaNIjaTN1s1Dq4/m1meOPGBhmqxGu vh2eND/5oztqAfCSQaoL8+f1OL5YlZ248RoAGtCrSCGwGgE4Z24lSJH8NunAnx5nx+qA IOHuFQ2OsfMJUB6yZ07GvQv93UMIpRaTvYdRJjOwrxo29fXcmMC5V7e4WP7/uxe3nACF z2nAw9T93Nt+CqxoRStzQXRqY6T4EnfPS4Qyhfg1hLhPpA4UMSFQPYNnrEJ4ztp5ukMK 6Xhg== X-Gm-Message-State: AKaTC01gRd8bHWk7MZEfXSIPCR4V0mucf5M+HLR55VFOsJDHWZW1amGfdGHI4yTG9DX4tw== X-Received: by 10.46.0.193 with SMTP id e62mr2171592lji.68.1480011767203; Thu, 24 Nov 2016 10:22:47 -0800 (PST) Received: from xi.terra (c-04aadb54.07-184-6d6c6d4.cust.bredbandsbolaget.se. [84.219.170.4]) by smtp.gmail.com with ESMTPSA id 73sm8441417ljb.6.2016.11.24.10.22.45 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 24 Nov 2016 10:22:45 -0800 (PST) Received: from johan by xi.terra with local (Exim 4.87) (envelope-from ) id 1c9yfV-0003TW-QF; Thu, 24 Nov 2016 19:22:45 +0100 From: Johan Hovold To: "David S. Miller" Cc: Florian Fainelli , Madalin Bucur , Timur Tabi , Andrew Lunn , Vivien Didelot , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH net v2 2/5] net: bcmgenet: fix phydev reference leak Date: Thu, 24 Nov 2016 19:21:28 +0100 Message-Id: <1480011691-13278-3-git-send-email-johan@kernel.org> X-Mailer: git-send-email 2.7.3 In-Reply-To: <1480011691-13278-1-git-send-email-johan@kernel.org> References: <1480011691-13278-1-git-send-email-johan@kernel.org> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Make sure to drop the reference taken by of_phy_find_device() when initialising MOCA PHYs. Fixes: 6ac9de5f6563 ("net: bcmgenet: Register link_update callback for all MoCA PHYs") Signed-off-by: Johan Hovold --- drivers/net/ethernet/broadcom/genet/bcmmii.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/broadcom/genet/bcmmii.c b/drivers/net/ethernet/broadcom/genet/bcmmii.c index 457c3bc8cfff..2e745bd51df4 100644 --- a/drivers/net/ethernet/broadcom/genet/bcmmii.c +++ b/drivers/net/ethernet/broadcom/genet/bcmmii.c @@ -542,8 +542,10 @@ static int bcmgenet_mii_of_init(struct bcmgenet_priv *priv) /* Make sure we initialize MoCA PHYs with a link down */ if (phy_mode == PHY_INTERFACE_MODE_MOCA) { phydev = of_phy_find_device(dn); - if (phydev) + if (phydev) { phydev->link = 0; + put_device(&phydev->mdio.dev); + } } return 0;