| Message ID | 1476950488-24923-1-git-send-email-peppe.cavallaro@st.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
Hi Peppe, On 10/20/2016 10:01 AM, Giuseppe Cavallaro wrote: > It makes sense to display the descriptors even if > DES0 is zero. This helps for example in case of it > is needed to dump rx write-back descriptors to get > timestamp status. > > Signed-off-by: Giuseppe Cavallaro <peppe.cavallaro@st.com> > Cc: Alexandre TORGUE <alexandre.torgue@st.com> > --- > drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.c b/drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.c > index 4ec7397..a1b17cd 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.c > +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.c > @@ -347,10 +347,9 @@ static void dwmac4_display_ring(void *head, unsigned int size, bool rx) > pr_info("%s descriptor ring:\n", rx ? "RX" : "TX"); > > for (i = 0; i < size; i++) { > - if (p->des0) > - pr_info("%d [0x%x]: 0x%x 0x%x 0x%x 0x%x\n", > - i, (unsigned int)virt_to_phys(p), > - p->des0, p->des1, p->des2, p->des3); > + pr_info("%d [0x%x]: 0x%x 0x%x 0x%x 0x%x\n", > + i, (unsigned int)virt_to_phys(p), > + p->des0, p->des1, p->des2, p->des3); > p++; > } > } > I agree. Acked-by: Alexandre Torgue <alexandre.torgue@st.com> Thanks Alex
From: Giuseppe Cavallaro <peppe.cavallaro@st.com> Date: Thu, 20 Oct 2016 10:01:28 +0200 > It makes sense to display the descriptors even if > DES0 is zero. This helps for example in case of it > is needed to dump rx write-back descriptors to get > timestamp status. > > Signed-off-by: Giuseppe Cavallaro <peppe.cavallaro@st.com> Applied, thank you.
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.c b/drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.c index 4ec7397..a1b17cd 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.c @@ -347,10 +347,9 @@ static void dwmac4_display_ring(void *head, unsigned int size, bool rx) pr_info("%s descriptor ring:\n", rx ? "RX" : "TX"); for (i = 0; i < size; i++) { - if (p->des0) - pr_info("%d [0x%x]: 0x%x 0x%x 0x%x 0x%x\n", - i, (unsigned int)virt_to_phys(p), - p->des0, p->des1, p->des2, p->des3); + pr_info("%d [0x%x]: 0x%x 0x%x 0x%x 0x%x\n", + i, (unsigned int)virt_to_phys(p), + p->des0, p->des1, p->des2, p->des3); p++; } }
It makes sense to display the descriptors even if DES0 is zero. This helps for example in case of it is needed to dump rx write-back descriptors to get timestamp status. Signed-off-by: Giuseppe Cavallaro <peppe.cavallaro@st.com> Cc: Alexandre TORGUE <alexandre.torgue@st.com> --- drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)