From patchwork Tue Oct 18 11:27:28 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Wahren X-Patchwork-Id: 683648 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3sytDH6xv3z9ryn for ; Tue, 18 Oct 2016 22:30:39 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759425AbcJRL2N (ORCPT ); Tue, 18 Oct 2016 07:28:13 -0400 Received: from mout.kundenserver.de ([212.227.126.135]:65351 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758935AbcJRL2C (ORCPT ); Tue, 18 Oct 2016 07:28:02 -0400 Received: from duckbill-v2-sdk.fritz.box ([109.104.48.177]) by mrelayeu.kundenserver.de (mreue004) with ESMTPSA (Nemesis) id 0LiGhD-1cilex36uZ-00nO00; Tue, 18 Oct 2016 13:27:48 +0200 From: Stefan Wahren To: "David S. Miller" , Greg Kroah-Hartman , Jiri Slaby Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Stefan Wahren Subject: [PATCH v3 net-next 2/8] net: qca_debug: use net_device_ops instead of direct call Date: Tue, 18 Oct 2016 13:27:28 +0200 Message-Id: <1476790054-27174-3-git-send-email-stefan.wahren@i2se.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1476790054-27174-1-git-send-email-stefan.wahren@i2se.com> References: <1476790054-27174-1-git-send-email-stefan.wahren@i2se.com> X-Provags-ID: V03:K0:viNdlOlNnunxVXsdInA2z60rBnv/EmYZ0KHZwQGLQGPTXFBmeDg lOCzrWLEc8WTuc8O4C0LOA6ImBAvk3Xr8xkkSMUSTdH6u8JnxcC85AmhVX1jgBpilwEN7Ok AEhFjClVy5fZRS4/QX5k/LrdBOzXYrI5d/242cymern2wnvvkRF16PXgdVgtgyrQEyv+ixZ iHPc5+33pMki/TiBVA+4g== X-UI-Out-Filterresults: notjunk:1; V01:K0:5LkGEVXi5SM=:KAQiz6wCBlsl9jYDUV5JpN tIvYN6ggQsdWM9V3xvFS2n06338KpOOf9PtpAxZxTpDDVoEeLFdqD6N9Mf6cy7iVy5KJPR6KG scuiZs3Uod4+0rxRYVEFcdsmp4ezDVaf5dQ5ae5PHyfvNJFiIJ1XMX3Lx/z3svxmAJFTXbq/D v8m87l2KbTnIyoT9pbHsroSwPPfy+FBdGLXY96u+k9hNvxHGlpY1q3DrPuYoqFvYtv/8pCgEY OGAoZOg231B/+Lg0gRvH2zxCOqmdbKSUb30AyleEVokKl/PyNtiiL7f+Ugfo2zpeyj3ZnwI07 SKoyCKBGZhFjRbFISFEaqYKv764MAXG2DF/bGv14J+jCBq1WeZmNWErDJ3vVT9g+OBo4iv8GG rFxX2tuCbI8rk4ack1ZY/m4FKJrzJFcJdPkBWSQp+CbmV+IqNRitFMM2pbAnYjXpgAO9Khe73 8FMzJedJrgyPepk0pdbIZKXDyevKU1N3ATwccsGOqQmsrTQwpPW0d90BR1pZ6Dze+bk+vewyT kXqz/ebjx+Bw3SSE7PDBf7sok8DA8LiSHaQqPJjFMIHpTq79GsrL3NxQ1x908+KitUOE34KTf cp4deYKDims3Q5DsoI3PGnoX5b6Idt/l43vzMpa9+Ik4TJdqSpesMpn7zIQCJqNstaTSCUJZ8 kyOdKn4zmMMP6ZDriIRnFw9Jg3dYdodiT2vkgh9CZfgZE1S0uJardm1Bv3TsFhTTIY3s= Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org There is no need to export qcaspi_netdev_open and qcaspi_netdev_close because they are also accessible via the net_device_ops. Signed-off-by: Stefan Wahren --- drivers/net/ethernet/qualcomm/qca_debug.c | 5 +++-- drivers/net/ethernet/qualcomm/qca_spi.h | 3 --- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/qualcomm/qca_debug.c b/drivers/net/ethernet/qualcomm/qca_debug.c index 8e28234..851bf07 100644 --- a/drivers/net/ethernet/qualcomm/qca_debug.c +++ b/drivers/net/ethernet/qualcomm/qca_debug.c @@ -273,6 +273,7 @@ qcaspi_get_ringparam(struct net_device *dev, struct ethtool_ringparam *ring) static int qcaspi_set_ringparam(struct net_device *dev, struct ethtool_ringparam *ring) { + const struct net_device_ops *ops = dev->netdev_ops; struct qcaspi *qca = netdev_priv(dev); if ((ring->rx_pending) || @@ -281,13 +282,13 @@ qcaspi_set_ringparam(struct net_device *dev, struct ethtool_ringparam *ring) return -EINVAL; if (netif_running(dev)) - qcaspi_netdev_close(dev); + ops->ndo_stop(dev); qca->txr.count = max_t(u32, ring->tx_pending, TX_RING_MIN_LEN); qca->txr.count = min_t(u16, qca->txr.count, TX_RING_MAX_LEN); if (netif_running(dev)) - qcaspi_netdev_open(dev); + ops->ndo_open(dev); return 0; } diff --git a/drivers/net/ethernet/qualcomm/qca_spi.h b/drivers/net/ethernet/qualcomm/qca_spi.h index 6e31a0e..064853d 100644 --- a/drivers/net/ethernet/qualcomm/qca_spi.h +++ b/drivers/net/ethernet/qualcomm/qca_spi.h @@ -108,7 +108,4 @@ struct qcaspi { u16 burst_len; }; -int qcaspi_netdev_open(struct net_device *dev); -int qcaspi_netdev_close(struct net_device *dev); - #endif /* _QCA_SPI_H */