From patchwork Mon Aug 1 07:02:35 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Chen X-Patchwork-Id: 654530 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: davem@davemloft.net Delivered-To: davem-davemloft@shards.monkeyblade.net Received: from NAM03-DM3-obe.outbound.protection.outlook.com (mail-dm3nam03on0079.outbound.protection.outlook.com [104.47.41.79]) by shards.monkeyblade.net (Postfix) with ESMTPS id 481DE598F6E for ; Mon, 1 Aug 2016 00:12:08 -0700 (PDT) Received: from BY2PR03CA045.namprd03.prod.outlook.com (10.141.249.18) by BY2PR0301MB2055.namprd03.prod.outlook.com (10.163.196.157) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.544.10; Mon, 1 Aug 2016 07:12:05 +0000 Received: from BL2FFO11FD034.protection.gbl (2a01:111:f400:7c09::149) by BY2PR03CA045.outlook.office365.com (2a01:111:e400:2c5d::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.549.15 via Frontend Transport; Mon, 1 Aug 2016 07:12:05 +0000 Authentication-Results: spf=fail (sender IP is 192.88.158.2) smtp.mailfrom=nxp.com; nxp.com; dkim=none (message not signed) header.d=none; nxp.com; dmarc=fail action=none header.from=nxp.com; nxp.com; dkim=none (message not signed) header.d=none; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.158.2 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.158.2; helo=az84smr01.freescale.net; Received: from az84smr01.freescale.net (192.88.158.2) by BL2FFO11FD034.mail.protection.outlook.com (10.173.161.130) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.549.5 via Frontend Transport; Mon, 1 Aug 2016 07:12:05 +0000 Received: from shlinux2.ap.freescale.net (shlinux2.ap.freescale.net [10.192.224.44]) by az84smr01.freescale.net (8.14.3/8.14.0) with ESMTP id u717BL1u013140; Mon, 1 Aug 2016 00:12:00 -0700 From: Peter Chen To: CC: , , , , , , , , , , , , , , , , , Peter Chen Subject: [PATCH v2 07/15] ethernet: hisilicon: hns: hns_dsaf_main: add missing of_node_put after calling of_parse_phandle Date: Mon, 1 Aug 2016 15:02:35 +0800 Message-ID: <1470034963-30506-8-git-send-email-peter.chen@nxp.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1470034963-30506-1-git-send-email-peter.chen@nxp.com> References: <1470034963-30506-1-git-send-email-peter.chen@nxp.com> X-EOPAttributedMessage: 0 X-Matching-Connectors: 131145091258717968; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.158.2; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(7916002)(2980300002)(1109001)(1110001)(339900001)(189002)(199003)(104016004)(87936001)(47776003)(189998001)(2906002)(33646002)(50986999)(50226002)(76176999)(97736004)(8936002)(110136002)(7416002)(4326007)(19580395003)(8666005)(36756003)(5003940100001)(68736007)(77096005)(86362001)(2950100001)(2351001)(11100500001)(229853001)(106466001)(105606002)(92566002)(8676002)(48376002)(586003)(81156014)(85426001)(356003)(19580405001)(81166006)(7846002)(305945005)(69596002)(50466002)(7059030); DIR:OUT; SFP:1101; SCL:1; SRVR:BY2PR0301MB2055; H:az84smr01.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BL2FFO11FD034; 1:l4oTDFRJrLGLTKSzNGKCUEsmqszq1FLcb9a2/YnM7SKpZAtmlw6Azydd/bNUNKC51Bpah3Uzn+pqealawiQLDLVv9xWT4h44qVOQCahcMJoppF6YvadpPRkOM84QNf3aB/wOtim1jJZv83Mqz69DLikLjTjsJKSEQiw1WLOPD3TG1ZtiVb7vi141qNHFhPJtDGwNAfK5UtKLiQkhmJhyiA6XFWTVjjoQFuWoSZGbRx3ZzINIOiUVJFgzx2qDZ1QrIWUjX8QQ9Z2Ep45oXIOyCB60QcjzHG01+RiZOrVv/tlRGNQyg679FsCti0/uwwSwQigglK6gl+anO7Tq8Oj8TdNdeImYR3nqmvj96MGmd1lnm0Kw+zk6/Z5BCRwtbo8F7qPj3v/trxKQsT067jvQgPPpuMZmLwT+Pi4PUiZk3Tu3pykqx/Cmw3i/yU3bINJzfliMEDnbsMDZokH44sdrtu0iJm0VCEUGFW8xFmxLCf5uMgGDv5SxDSSU3QIZ8YRwdg1gUXYZTaP+I2QpYRGUuSoutUP+JerzcmoLmHOXe4HvP7YYB2aEpOFHuLH5UIs3oofHBiaQXAdmLSrS7Gl4ykMjUlU6ZLDZ54CHDiea445FlK10tnNRiNMd+OpsLbEG4B9vk1rO0uIOp/ptPJ6J+E1coFvwVgnVTLQdmnUmolKpI9Z5+7oxgwuA2MOG8EKuINHayl832QyzHCMvK1DZBUJIuyd2G/pLqSJiW3pyGmE= MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 1d483878-c936-4cb1-1710-08d3b9db24fa X-Microsoft-Exchange-Diagnostics: 1; BY2PR0301MB2055; 2:A1cDZuzCyM28DssoIUsEvoC12WHkXbUP+xsWZ/dVmV3euAFCrq9jE605VOm0My/yWs4Ziz3i6eXPQYmRlSpGZyqQr74TqEAV71GykkWfJ2kWTu4p5uKdtI+Tk2kXapNbkMsevNgFUSl/AxU0xK5BvWKE7ONCsOd7qJdiRrYUngsB1squxMvKYebOXK/3z8k2; 3:PIFvuXcyGt3JzJafjWNYY/a3ERNKto8l0J9y7Os91efnYqPL7a6hUJPXeZdk2eya4/1Z+4rapsi7a4U3IQxK9vQ3EVZmXJ9sBPLPxCXIMw/cc/k9wK93UOVbBaITnnqYbMz9oHl2lWTe5k20jwGLNGeoGQY8pUnPAUwy+XugVecPrkfS8dLGM/MUAazWwcPY5YJB46k0tI5hNLyHBww7tjXr0bX/q3N7Zkfh6TKHV7k=; 25:EEHGevOZzMe+AJGTlL8r6C26mG3faZIgE668ayP1xCWlkIw7J02h/1l8Td4Kp/oHLG0mtOl5cXRl5sgnBxf6/MVAJV9ns4FlqLNJtWFFlF4fQfr14c8udQAS1OfT4E+yBayDRGjwX+cS7fqwOysRNC36SJx37Ln8r55DYrlbSra9kCg5RvFxyAUSO4h7oyshnk2NoCo6LMnrSlgk+LN3iRFsfn7SNxZPWhrB4ZX2n1ZxkfY2NMx6GS1YePQBIxSug43c9oF/T8Bmkott5eU00N/E9syCn7YU9P1HmRyuS2qbWEUJ1oT+1EDwLpQJ6YLL57p3rEeg4+GtP29kftZYiNMqPfN38r/VjOCYi9GUnFxcWYXC2VASnHM8pZ6oxzjNVD2NAHq8dHnziJPFTiPEXBDWvBYlRfvJKLbyyJcdzsA= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY2PR0301MB2055; X-Microsoft-Exchange-Diagnostics: 1; BY2PR0301MB2055; 31:utGTopLav5TtmYYz+FzfcR/AM5WMrizGT+LH1Bbhi/XZQLoI2wxaJp0s+Nzuqk4xjLsKv58yy/1YrTzmszDmtyseYbXiCROhMPd2sVI5TSrhP4n8Syn1JUFGlGs9aKfH+Ot+f/uOJ2lcmJ7X9eyUsAmfh+FpWMi4q/Mji5DWbLYf2yeLwdPbXqotB0X2LrkLLQwZhbljnn7gv+g/jdytgA==; 4:TdxPTxRThkVtuMvNxW4cM5nwiBx9PUnt/zj9yG7dvUF3H49aRRQZIk+5rY8XpUpOVx06HhX0QTtr/j+wwqyOdtOwDIp9RJFnWZLkYrpizxG9A3FjiX4L+iFJ07OH+qwebrv0l9G+UIIHK4PHA5QS/5Yp74YbgGG8oruEJHn59y/H+V6jgiiieX2qKIvg9hzB2Y0aBP38aeWEQZEfvdlpjSlH2IXDNSB9c8PEmmYXiJZWQ1UTa6yq+Ua3kodmPU17GxLDFe411nozWI/VHY1IQLKvv26vlThdxZlggdkpcbpEllOWpZ+0DeEw5F3Yr2ZweXRXZrWr1Sx/CTqbTmTxoYp6We5/J2l2O5BkSebu9PNBkPtJMstNlc392irCTDasR1WFrxgIIz/Nm2dIobL0O79eGqBpVlSAy/c8cSJf5ww+OUoCIorWBnuWmLNn8uBolBzjipx0d4WR9PLvZ72T11KgsWC774stgy5No7+nJlIL5EkLcP3owXKqxl2W5NDi7mkK6FRs/YK/cIkPasn/LA== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(2401047)(13018025)(5005006)(8121501046)(13024025)(13015025)(13023025)(13017025)(10201501046)(3002001)(6055026); SRVR:BY2PR0301MB2055; BCL:0; PCL:0; RULEID:(400006); SRVR:BY2PR0301MB2055; X-Forefront-PRVS: 0021920B5A X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BY2PR0301MB2055; 23:Du17NovdtBv5OFsOH7vDstJRmREe1qmHpxvjiCB?= =?us-ascii?Q?a4CdNfk8CqemMw/RQ1SMKK9pBClLSyJziGIVZvti/0uEto1G22T3su738ixX?= =?us-ascii?Q?gtHldmGOkEE8EdzIlhFjb2zsh4mnMo6nuxM1dyZxb6rO5giwh7W9bTdxskOl?= =?us-ascii?Q?AqP1mLbzzw3uqbHwRBLiQJ0zaYd8zKS5sSicY1fA77zinLmYcfssXCUglcaP?= =?us-ascii?Q?xK8Tt80/wEycqjVWpcc1dg4r9gOv6BHLuP/QaITX4ldA3l9TNqnMMj+KYoEq?= =?us-ascii?Q?+4HHiSA/XK3EY0dHNXv6/Abe+ESTElgJaWGzErsYBYPn3E8ymH7xCIGrVLZY?= =?us-ascii?Q?SqIrnWwHTaChrgtVD3Bgo/96cb2GpLj+2ggm6lvkme8EjdBkbfuY3WLuH4mU?= =?us-ascii?Q?zD/U5xq0682+JkXT5zmaJ3hzLVeGbd1zD63UhDgK3HDRqEqdXHI34MfHeMZ+?= =?us-ascii?Q?5loZkTGAr6FRp9T8CDr1q8MgJ5vDNTDqdCZGC89AiaDUA5AVqeoKdKmF6ZJI?= =?us-ascii?Q?xC7wvEQgEr5ppHOmL+7/MRM1LsWbCPkFAxpF5tB0tG5Xcy9RcrO0n19h5Low?= =?us-ascii?Q?fVeilfI9YUAZSc44yeIAvzo/vMjqRQ5YOm2kWn7TFnUIHQFAMKEyBAtZCQiR?= =?us-ascii?Q?L/SGq2oLOcL0R5EwXwlgwKwEooFRn4GZKgzZ87qP3VDCiv8ZFrRoIHur7xMA?= =?us-ascii?Q?bOZfYVxiN4OTA1RdFoEQjKA7NaF0BWA9w0OCXmoRyBKNnPLFZl52QEE5Y7sP?= =?us-ascii?Q?RN+/179O8rbY2V64+tqKwMC2zrcrSNlaqfW5rbTVRYM1JNPS19LzkZPNmUGH?= =?us-ascii?Q?0JaOm/b+mAVAwPk/O01gmDxTOlDecCLfJwPCv9kldRXwQIf/nMLYnMuRN/O8?= =?us-ascii?Q?WGgENCWJ4TyEIgwB+A1vKF3/mL9Rdx9PW3Sy+oDnXVwoM9aQVHwoQ2hmNj3X?= =?us-ascii?Q?Wh0kuwxdpx/DJoGrvdVpEbs3XiK2fPB6Off/eCi5LSIC1u/46d6NLFAjIm9l?= =?us-ascii?Q?9x7onV0B4xqc73cIw9b1FATDgGdzTRwRkUp5ulbg8palBvLhlCNJpfIAsBbs?= =?us-ascii?Q?p4JBGFfwHtLwwEBT+shjcnwXJzlrEm94VbeRd3hw2v3s/akIbjI4dWG4Lupm?= =?us-ascii?Q?XyjPDRFXncR7N+vpxhm9Lal1OQmDjdtRiLojL3wKStEphLNGliQ8FhQ=3D?= =?us-ascii?Q?=3D?= X-Microsoft-Exchange-Diagnostics: 1; BY2PR0301MB2055; 6:XeVFYgemVUPngXNysJ/+JeL+H4AhGe1xxPmNESvOIZFfFkkfkt1ZW1Kv3Xq5uSOOEk8HKbkcIoBPFTlgXCvc6ftyJtHU+t7aaHPntIxNDugU8M8O6cJXtbmZfhlDsHNlSSlo+6i1L2w7m6MVlbD5TEYBpdVw2QOJriLyttHt98w1FL0BdKyc3CN9Czyyi1TJcXF6Mm773hjC01T29DWkxjnV/TEXS7DzmnSZl8tRoI5Ls5dac0tkZ8oPh7dg+n8vbtH6vZZfgZdPYPJ0aCFRoEnDmEWIYN2gW7GYFx9sIGc=; 5:bdZcMla5tnnxtlqAq4lqhE5xfNkQCEKfbif/HVtqnpJwX6Us5/A+SjJMlzcA0l9w0VAeUMkiZHVD3HFdTdjDi+LDhodBuMEbPthhOBMlPSge5TwajBxZLuXNMFbhgKTH2V4IY14cH3gr4tjxYtyrr/jd8BCERHRvu0pP3HR3Xdo=; 24:daUEsQMTATV3PwSznoJvwNOyzG6f0SqYBfCZQ+aD00wwhXkz9+hSArOqo2hGb6FOyRbqzX0PUgyB6XuKR1Ro35Yj0uav7/7FzLuHyMiOcm8=; 7:6oEJUzDoSaM7v0chD/eKZSemT5zUQVnmw32O+DPrRiKoBHYl0OJd25nrUageGxK2wlMYK/yZ3dyqkfm4i6QxynB9HlGzK0lRTI2DmdZpFTe12PbZ1Q8VXsP5ETsWZLVLHT8Z51E70thbVNzPf11hITw5+lSokdD05jxZhgI9Fyzlv0Hk1SCLfx+MdhMMqZJbf0PVejbHJpYyOtSgNGXDijJqF3izZyG8TQO7IjrqiUDLPeRHoVjuYGp/TFll8abW SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Aug 2016 07:12:05.5753 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.158.2]; Helo=[az84smr01.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR0301MB2055 X-Greylist: Sender DNS name whitelisted, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 01 Aug 2016 00:12:08 -0700 (PDT) List-ID: of_node_put needs to be called when the device node which is got from of_parse_phandle has finished using. Signed-off-by: Peter Chen --- drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c index 2ef4277..afb5daa 100644 --- a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c +++ b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c @@ -51,7 +51,7 @@ int hns_dsaf_get_cfg(struct dsaf_device *dsaf_dev) const char *mode_str; struct regmap *syscon; struct resource *res; - struct device_node *np = dsaf_dev->dev->of_node; + struct device_node *np = dsaf_dev->dev->of_node, *np_temp; struct platform_device *pdev = to_platform_device(dsaf_dev->dev); if (dev_of_node(dsaf_dev->dev)) { @@ -102,8 +102,9 @@ int hns_dsaf_get_cfg(struct dsaf_device *dsaf_dev) dsaf_dev->dsaf_tc_mode = HRD_DSAF_4TC_MODE; if (dev_of_node(dsaf_dev->dev)) { - syscon = syscon_node_to_regmap( - of_parse_phandle(np, "subctrl-syscon", 0)); + np_temp = of_parse_phandle(np, "subctrl-syscon", 0); + syscon = syscon_node_to_regmap(np_temp); + of_node_put(np_temp); if (IS_ERR_OR_NULL(syscon)) { res = platform_get_resource(pdev, IORESOURCE_MEM, res_idx++);