From patchwork Mon Aug 1 07:02:34 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Chen X-Patchwork-Id: 654535 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: davem@davemloft.net Delivered-To: davem-davemloft@shards.monkeyblade.net Received: from NAM03-CO1-obe.outbound.protection.outlook.com (mail-co1nam03on0085.outbound.protection.outlook.com [104.47.40.85]) by shards.monkeyblade.net (Postfix) with ESMTPS id 84BDA598F6E for ; Mon, 1 Aug 2016 00:12:02 -0700 (PDT) Received: from BY2PR03CA050.namprd03.prod.outlook.com (10.141.249.23) by CY1PR0301MB0700.namprd03.prod.outlook.com (10.160.159.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.549.15; Mon, 1 Aug 2016 07:12:00 +0000 Received: from BY2FFO11FD041.protection.gbl (2a01:111:f400:7c0c::153) by BY2PR03CA050.outlook.office365.com (2a01:111:e400:2c5d::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.549.15 via Frontend Transport; Mon, 1 Aug 2016 07:11:59 +0000 Authentication-Results: spf=fail (sender IP is 192.88.158.2) smtp.mailfrom=nxp.com; nxp.com; dkim=none (message not signed) header.d=none; nxp.com; dmarc=fail action=none header.from=nxp.com; nxp.com; dkim=none (message not signed) header.d=none; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.158.2 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.158.2; helo=az84smr01.freescale.net; Received: from az84smr01.freescale.net (192.88.158.2) by BY2FFO11FD041.mail.protection.outlook.com (10.1.14.226) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.549.5 via Frontend Transport; Mon, 1 Aug 2016 07:12:00 +0000 Received: from shlinux2.ap.freescale.net (shlinux2.ap.freescale.net [10.192.224.44]) by az84smr01.freescale.net (8.14.3/8.14.0) with ESMTP id u717BL1t013140; Mon, 1 Aug 2016 00:11:55 -0700 From: Peter Chen To: CC: , , , , , , , , , , , , , , , , , Peter Chen Subject: [PATCH v2 06/15] ethernet: hisilicon: hns: hns_dsaf_mac: add missing of_node_put after calling of_parse_phandle Date: Mon, 1 Aug 2016 15:02:34 +0800 Message-ID: <1470034963-30506-7-git-send-email-peter.chen@nxp.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1470034963-30506-1-git-send-email-peter.chen@nxp.com> References: <1470034963-30506-1-git-send-email-peter.chen@nxp.com> X-EOPAttributedMessage: 0 X-Matching-Connectors: 131145091207101774; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.158.2; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(7916002)(2980300002)(1109001)(1110001)(339900001)(189002)(199003)(189998001)(8666005)(8676002)(86362001)(87936001)(356003)(81156014)(104016004)(305945005)(2906002)(4326007)(50226002)(8936002)(7846002)(68736007)(48376002)(81166006)(7416002)(110136002)(47776003)(36756003)(19580395003)(77096005)(97736004)(19580405001)(105606002)(50986999)(2950100001)(76176999)(50466002)(85426001)(106466001)(5003940100001)(92566002)(69596002)(2351001)(586003)(33646002)(229853001)(7059030); DIR:OUT; SFP:1101; SCL:1; SRVR:CY1PR0301MB0700; H:az84smr01.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BY2FFO11FD041; 1:/l6mt2B65LkGhLR0Ipcy8zJqN+vnwL9z/1dmveWntiB3fZdI7OxIdx2eLRB9Qsc60JUDJ0pdxRP7+WH2DkjSkgHU+MqDKv7nJMz6xxTqxfwlHTyE/EltUVpm08tq0rzNZNvrR4Q9QKtg3aYIV1DtXDBWB1PwfepPmmn8wINmy7hptufN4lD4N2XO9rORT5e4zY/ccHkzm5fYAOHWWP9cPAV+LSy1PzdjeJ/hG9dvUrCuNbl2NYRju8RyANN66NniHtXmQHLY54r1OjzuqW6n8Yi5aNK9/Rng/pkwouaJOyUkqxLcnbMMsgkcUkhefHTjzBK47tcTp7gI/4ee3Ry6CloVt77wVaIQCqrytwTnszWsjp3KMvATI9sN5EyYxhj+xtbd9Mi1CcaKhBC4pgUD31XA0yXGfUXUNbxn4RY0EHBzq5eb8fOGlswMI60dRTe13aXS3wjDD2qqvVTsR4iDICJ8fMPCK4us+sRvk3g3zDVEchJcHMZ7UqI8IIMKBnC4PxgIUPGbV00k0nCQi+g4VzWD228oGPQOK3p03Ct9ybdXqgsCS3Hmy0GETwMHEzJUD8Bi0lzl2teNu5fXlUJHEqxpVM3OYO0nEHBzd9vX5FSPoRpTGrwB4l5ZkG0D6IrlxIXYJzYbcS0tiLlEmGuTFryVPdxmf69wpOTr7OvH5WYLWwDao/nQS+DhbhNR8Am/7giV+ee4c+uKG2baF30Cx0RfKTz1rOu01sF0iCAZu60= MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: efd05131-3017-4804-724e-08d3b9db21d3 X-Microsoft-Exchange-Diagnostics: 1; CY1PR0301MB0700; 2:LidQvU72Bg0lHd+HREq4QtCC7LPU3LnDGrU8xYSEQ5eY0hXR0WRaX2rjFz2q9t5ZpORMhsZFFxG7r3kYkkKghFBGmkZS0jq/lwhHA9lvJXFseA3OhKkXdOM7jN2L7jED5rkwLcKNYuy70kPddfj7wSLfNqII/3HfTNCiFICdC5rj8R0vpSu/WoUWF2aK62zI; 3:tINpmZA0BC8uCXFG2pUa4vaUwLzDo+vxf38hwMQ+ajrfa7gZilLeks3TFAN1pPVt0hWMCfUxH8S+7beBx9PWLk2VGKsVLAjYpIIX5yQRKSbKc1213B6DKfj/5Dx8wGPdiKRK1N2+CPNtG0XfMyYz/a7A8A/5GBgLbkEZXwLiSfSQcYfTAlaSPVnT7ykiu5jOM7HSYKmT+9BnJ92i/JkBbmJZwcSdK8Ld7SOVQ3O61+Q= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR0301MB0700; X-Microsoft-Exchange-Diagnostics: 1; CY1PR0301MB0700; 25:Cjfhi8NErnWrFrlQt/lSoKVoLoWfolWz+wT1JOpXq9IIkufowAq++bnr5PAX/EgDUqgTpPIBPUpA+aUfBip8FRILcYqBrgGidRknC8igabIEpksKkkV1ApKhqgWRD+YzsqmPKaC1RZryFCNaJwKc29DdPVcmAH4nN3DNId8pMkgWPgDlcW4be6fHXFFYm0ENUz6fwjhdWW2kqU5H5/Odm9JlgKXklp8hLeDofjuYBwerK/SKPYBNjDL96LbDxIereAFrSzdJVsMABsZRQAbVwlglBpbslz8jJjc9vx516gXx/gyD0jD+Jxl0o48zs7OwiO/lu+n8R3pUDWaQ0UOLcB8n1Gg6eHTxEcvwox31B777TijBNVVRhxLMedJ+8UM+Pc3dP3eC/7QgGTsBdm8hBIaICREBlI3JBU9G+GIfqq7HF2rzy7rykn5O9lDcYZA+BXaDYLItYZXK47t/x2mn56mlkcKEXCPf6PDlbWvG08AaG5x88W0N8pcP+dycRKeFpF6t03PLHmldmjMu3Oz3pf2UWHzJnL3AvuLLyStNz8NVMTJc4BIUEBJqs+CHtVR335A5RxHZp4jIRYDZhD3gmnu+IxOcxnVBkTBxYXiThvlfHbILhwkZiQuZ/VY5OQ4r/Uz2YDulB8n9cfzorqkeGJ2A2cjfwmhF+ygVh3WMpC/0Ku3tYs+fyu33zQicULHRgsmKTK2ZhVCayIlC6j8FXf6GMDA4jhTzuZ+lnfu954c=; 31:dGu6/zs/vYch8FM6Ua1XDkxTEa6k3ABwvSLls6N1wA3ZqsIKrdCar3Z0+KIqoNaJrcW2aO8WcvrLKwdjH0Dhq0sIeZkIxtkGfBiAfvtRZlCwcuP+jkwr3tREwB0HiXEOcuzwwJMmrhN/tJ50lCTLRqp1VqDNJaP6eYiEvQOtKg0J7c8y79VFbiX68X+vX9OYycwUoSDkeLqxIMT0Wktp+w== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(2401047)(13023025)(5005006)(13017025)(8121501046)(13018025)(13015025)(13024025)(10201501046)(3002001)(6055026); SRVR:CY1PR0301MB0700; BCL:0; PCL:0; RULEID:(400006); SRVR:CY1PR0301MB0700; X-Microsoft-Exchange-Diagnostics: 1; CY1PR0301MB0700; 4:XsArfU8N8aXdrdB6mB4pwry9IUB2V1iaXxJvSFsb28BbA8FJGvLWJeFttrQMYoqkVZh1dMrrXX4rucQTc3slKQuwljwggLerYPLLVb4gLGzKtKPuFod/x4wNI9qFY1AayZxkuOICKJbDPduEjTV/+kCOFjmehTTePqTCIXsvcQCIy3WfNEPmL4cn2MzfHyCyTXLQe+9MlogTz29XKAnKQuEIHvJ+O1rByxVU8GxbLpLnPWc4p1IFolnQwLVsovPowPo+j2zhQOWy5f+/CzFbcfYSjeJeTZ2Xe+CNk25TCaf8dsPbizUMVBeggDWQDOTqWtwCl6FB8MX/dN//XRyohr8yaIDrUMxKjTd7bQ/vPGY7xTnQHK+HBZ5IvgIJnMH5KR6MYnn7du15T+44h6v37SMFd6fZA0WmO8yRmxUZ74GsKbVdUr89b4HZLA7JvJ0gmBPcwmCY44o+9ihLBCKzah9FWAl4uR3u103DeUwQrJca5DBZ/gJKSxDhRhw3X+ip4uP10J2hsHEnAR7/4SHhyA== X-Forefront-PRVS: 0021920B5A X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY1PR0301MB0700; 23:o7KY/uRJaO8if0XIXkaCqe7DwwvXf9WnUth9MUp?= =?us-ascii?Q?80v/0oRCzJpF8iTjOt75UVXQei6pdCOZ9nutdZH0qVPPk2NnO6aCDOaii+OV?= =?us-ascii?Q?H5hNRKWtXFYdJ1YqB9jNG6HKFcyRmHezr8aYTzqUYirf/54jhqTlD5oLSO1p?= =?us-ascii?Q?zBLoqHWjyGiLO/AnzDMK6KiF7ltX0POZGziHReJZCgCQGUxaD0rQvGECPVKj?= =?us-ascii?Q?a2m7Za04UfDWfoU5A5ArbYJAs2AElE6ax2gl1T3j0dDFmTcInLExsLRWr3i2?= =?us-ascii?Q?rJeurKUL8sGnhb3FdyMjjuFmYZo8OqPX24b1PpNAmixitv8Ticrmdc1vHSni?= =?us-ascii?Q?fDM4BR2IgILtA44PwsxtY36Hjg5crzAq+s3ExW1HxzRS2LJjrnvw934dzOKq?= =?us-ascii?Q?VdOrFQucZOoz/lbjGRtMwIBxaXaMset4aGFAzsgZ1krcdYtGngnguJm0aXa3?= =?us-ascii?Q?lrnaYHhNkDSl6TBuUVk6+pwXeEkcmSNxLayuSgH0ezsGnWE/tPoo8bb+pP50?= =?us-ascii?Q?HOYm9GU5C6RfLJ6nakJhvDzLRJpHDfn2Ls7hKbjOfj/43PtD99/hVQ2kOsd1?= =?us-ascii?Q?yfc+RUXeOQvw3ZVERr3dAbgXyphk5LTcicsmijlIWJwlG1Cgv/a3m3dVofPn?= =?us-ascii?Q?G1DUxMwnPlcmq09Cu+7DK1PqhxUUeGJ3DbKKgOSciD6wN+MQjhIho2+oc6ce?= =?us-ascii?Q?rn+iokw9kVyDrtQgc26A8IMMOtfhY4WC83qMgGhjkS3h2d5us50A4S4agOk/?= =?us-ascii?Q?3XF67M0J1ZaB7aTivYIzpv5PmZP/weQNczsoQo7qLI1xspmEGRZmrOL8rs+L?= =?us-ascii?Q?J9kb37BlNOIwINScyh03ynee8sZFHmDKo8RmFykbi1si1L1+iRjmgGf9OT0B?= =?us-ascii?Q?zwVJ/f34FIoc1hU1H4eh0DBqsQOjumNUzN+pfdPyzxGW0CTsnZ635WMuxXSU?= =?us-ascii?Q?N/TH0H7qWaOQ35ENVotJf0TwAkh1vAeb135PM0S+jqzDPZunTqhqdsTXp97F?= =?us-ascii?Q?WRQ+02RAkC/ps4q1A3CbZlGccEo9dVF8rCdORSWL5f9BIrj79bylATygcmTX?= =?us-ascii?Q?f8qgp8DRZTrBco+xn1X8Z/9kAifKx9/Mqx0h/yOwhy1WMrB74ulWFzVSaqkS?= =?us-ascii?Q?wUc9U4IlQyFJysyFKFHihHETiepbshRkk?= X-Microsoft-Exchange-Diagnostics: 1; CY1PR0301MB0700; 6:meV1NUjJciY52VDi8PJr+uemG13kwnBMAue3XgGRbJEMGi+o8LVuflPq8dVe2yGQBE1d6zPxgFM6yyo3Ig/PuDSdsHAxz5Sn/LOKDBi7TotvSNnxbX+I+c2f7RRKdkBlnirWuAh95MI4Vzfwh1FgJA2TYLVtk1XuROkCUG13cuTlJMXvp2T0Iz9QhFZLhcSOQLOl2sbxbKhsl+Nh+PY4kfIRvYMRDvFrLynMQnO36YLcoGU0p/uS3PNVAJGOkOCU+0XQrHeyrzpXNG+OBXE4eiuM6IJ49YR7xbA6/hxqV1U=; 5:BlUKo2NiYA0SWwfD2yc76IBynu3Nfl0ny0qkZTIm2VoVs5B0sQkJLcETYjysH3poTX1zqCgIvm5kh4gT6GdGZMVkOhFy5m6ZjvjZWItsA4cQa9fDkOHfVCqq45GRjR3356DtIJAEiLjz30O0p5g5m2Rrz894w45j4AZQsMFQLT8=; 24:lDLEvw4RrZoQQSoZdNCQCmMUNqYXhZeZTNXg5NXieNQFz3gGRJm5OLqgYmdgZ35v1bBkKZ7zrucPiSMo0YO5+UCfIqW5SY+LpvWo/I+uoPo=; 7:dwe3TZnTF5tPDpwKIN4HCNZDto0jkJqvHECb6rygmsqh60RjzYESsiUGodFanXc9/Zow6JUGAu+kUCIn2pMSZTyrgBE6c0tRzOkNofxGUwWql4LbGIUtjzfkSW4VJbU+3lFPDVhT315KCFHw+i7XpJhZtGurG9l+lqp/VZmN8wcUJAaWBThVbhn9gYcyD/HRIXVDhIc60K7YwP3VJsHBZsIx+w2MUAOUV1qvG1+BLzxuzpeGzQNjFev3W/jt6cIj SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Aug 2016 07:12:00.4449 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.158.2]; Helo=[az84smr01.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0301MB0700 X-Greylist: Sender DNS name whitelisted, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 01 Aug 2016 00:12:02 -0700 (PDT) List-ID: of_node_put needs to be called when the device node which is got from of_parse_phandle has finished using. Signed-off-by: Peter Chen --- drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c index 3fb87e2..5c8afe1 100644 --- a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c +++ b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c @@ -795,6 +795,7 @@ static int hns_mac_get_info(struct hns_mac_cb *mac_cb) dev_dbg(mac_cb->dev, "mac%d phy_node: %s\n", mac_cb->mac_id, np->name); } + of_node_put(np); return 0; } @@ -812,10 +813,12 @@ static int hns_mac_get_info(struct hns_mac_cb *mac_cb) dev_dbg(mac_cb->dev, "mac%d phy_node: %s\n", mac_cb->mac_id, np->name); } + of_node_put(np); - syscon = syscon_node_to_regmap( - of_parse_phandle(to_of_node(mac_cb->fw_port), - "serdes-syscon", 0)); + np = of_parse_phandle(to_of_node(mac_cb->fw_port), + "serdes-syscon", 0); + syscon = syscon_node_to_regmap(np); + of_node_put(np); if (IS_ERR_OR_NULL(syscon)) { dev_err(mac_cb->dev, "serdes-syscon is needed!\n"); return -EINVAL;