From patchwork Mon Aug 1 07:02:33 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Chen X-Patchwork-Id: 654525 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: davem@davemloft.net Delivered-To: davem-davemloft@shards.monkeyblade.net Received: from NAM03-CO1-obe.outbound.protection.outlook.com (mail-co1nam03on0083.outbound.protection.outlook.com [104.47.40.83]) by shards.monkeyblade.net (Postfix) with ESMTPS id 26309598F6E for ; Mon, 1 Aug 2016 00:11:57 -0700 (PDT) Received: from BY2PR03CA045.namprd03.prod.outlook.com (10.141.249.18) by CY1PR0301MB2060.namprd03.prod.outlook.com (10.164.2.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.549.15; Mon, 1 Aug 2016 07:11:54 +0000 Received: from BY2FFO11FD056.protection.gbl (2a01:111:f400:7c0c::165) by BY2PR03CA045.outlook.office365.com (2a01:111:e400:2c5d::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.549.15 via Frontend Transport; Mon, 1 Aug 2016 07:11:54 +0000 Authentication-Results: spf=fail (sender IP is 192.88.158.2) smtp.mailfrom=nxp.com; nxp.com; dkim=none (message not signed) header.d=none; nxp.com; dmarc=fail action=none header.from=nxp.com; nxp.com; dkim=none (message not signed) header.d=none; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.158.2 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.158.2; helo=az84smr01.freescale.net; Received: from az84smr01.freescale.net (192.88.158.2) by BY2FFO11FD056.mail.protection.outlook.com (10.1.15.193) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.549.5 via Frontend Transport; Mon, 1 Aug 2016 07:11:55 +0000 Received: from shlinux2.ap.freescale.net (shlinux2.ap.freescale.net [10.192.224.44]) by az84smr01.freescale.net (8.14.3/8.14.0) with ESMTP id u717BL1s013140; Mon, 1 Aug 2016 00:11:50 -0700 From: Peter Chen To: CC: , , , , , , , , , , , , , , , , , Peter Chen Subject: [PATCH v2 05/15] ethernet: cavium: octeon: add missing of_node_put after calling of_parse_phandle Date: Mon, 1 Aug 2016 15:02:33 +0800 Message-ID: <1470034963-30506-6-git-send-email-peter.chen@nxp.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1470034963-30506-1-git-send-email-peter.chen@nxp.com> References: <1470034963-30506-1-git-send-email-peter.chen@nxp.com> X-EOPAttributedMessage: 0 X-Matching-Connectors: 131145091156072123; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.158.2; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(7916002)(2980300002)(1110001)(1109001)(339900001)(199003)(189002)(50466002)(77096005)(7416002)(105606002)(85426001)(110136002)(19580395003)(68736007)(189998001)(8936002)(81156014)(8676002)(81166006)(36756003)(97736004)(48376002)(50986999)(76176999)(87936001)(2906002)(50226002)(7846002)(2950100001)(305945005)(86362001)(47776003)(106466001)(11100500001)(104016004)(4326007)(586003)(356003)(229853001)(33646002)(8666005)(5003940100001)(19580405001)(92566002)(2351001)(69596002)(7059030); DIR:OUT; SFP:1101; SCL:1; SRVR:CY1PR0301MB2060; H:az84smr01.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BY2FFO11FD056; 1:l8YdLPSZN/n5G6QUzjfYsk1+X6+bFLs24vaPYAahS2Cm5YlglGq3ETk3jhO68VYCEbUPSVfT/wC+hy72GYZ4T8RH9i1oJnjWzdCpvobT9+q4Yvsmdd3RCy0fr6v98rLTRFoxp9GcXxOnVccGq/Xk+h1UQo848ACZau8nPEHzNiek9BznvWg2Fd6e7FzUgxkoc8Rutk4qf06MWpEyCOKxAS2XWvPdaXdCQbGPC/ue4rQp3/a6iKZU9H86q1B5uWPJ+Ba9mtt66F9zQw2zBUc+hcAUGQDyFZ8het2o1Rv76uQMc8JdEKQ3IHqnHrBTKWjjGRHqWrManioVYBR8o4/KwXTLjB2QIHYpKpBm5ZOW+h1nM9yKPc3b42jPd2AazFMMKUKn3X1zoOW6z6TbKF1/E9jdvh1RfVzpjiwi/pqZje8f0Zyo+/O5sKb9rtAcvZflSLCC6cIvHubQx8yvVDyQk/ifOvRhgzP2wKrdtQM3AlRiaJzgRviZ8EvYsmYcHYtB6XshS+hzQ+BT3QWm+bCo4QFXssz9ZDHlEYl7oWXfOjteoETb3JPRNUn+NjqsDzyEhQ51qEFpWD3oITC8QCt60srMnMpax517cUb0wyNO1OU6vJIvTJJncuKwRg9cGeleSdiUm7e3XsFuGaUR43PnZQblNxVS9xSVHOsLlqLA/j2bCrmKgKrrsSEJOCc6qdR39TbA5hx2VWrx7KeLHXrsl4Jb0jSOc6ElWICA55SkOLU= MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 3867e82c-5805-43cb-cbcb-08d3b9db1ec8 X-Microsoft-Exchange-Diagnostics: 1; CY1PR0301MB2060; 2:/SntySkI4ZNGH63w9XHzHQxlX7Byng9CnPBEwVKOC2IppYPeq6XETbWtqVmeEGZMJ1BZKRQpLe3WUT0/6PUV4FGstTaZuj42b/Zx9rPZitpYfRLL3WZC5YvfJHCtMyhfkz4q5jyV+z3LEobwyYnJ9o4cujFzOYfKS7uBEkVo9k44ZXYO/K0nzPiPiBxepDOG; 3:3l8qt6gruH4Rzj9ynpMtoylxshZFJ6C43W2/KwGlyqleGEv0RtWlBmdAo2YdgjqRkH+eF7Nn91h8gAAQZ/55MkORLGVWU6e0rBPmXDUc6hMz3xfwgyncm594mcRsFXBpNc9ixXm814GyEeo8Ih2USr6ICVDE/2WEY4FC4EYnNKI8vC01BbFtp5Fvony82XfV4TkAZ6GatxWhpEW2PkyI3xNS0uW/0SDIMOBw5nImeGk=; 25:x+L1k5egjF7QBQl9q/+G2Y5pgyxajQdP35IMyOAiSF1S/DYvwUwLNWN1luCS3o5jDSiTeF9XLX16jzfeUoDgmn3hIAa+v6bIr88xgsxi/UT3nx5FkKDqSJw7alCxLFYT+HDtZgKt/7qxsaJ5bRTX4IC9C4x3Y06FhkDQrOMhVXPg0LZxAKI01uwcEqib0hNZ1E0Ec3na61oxpLP5uNubR5ZNI6Ti5NUVU4xQ0HkVv5JzcguVmimTRNDFpCRljeFXET/aEdIqGZ1whYkE2p0kcxfr35s9YdTWWzucvULLshtn0maG8t0G+ZmpvjKvfjThy9ycbr81hc8lQBpU+tHadzw4EQeve+nFg8zAPXu/FD2rw3yolvy0odsnmVtRy6VSbVeLz+tciNI5WDhzxySYn6dAKNe76du8oUZpBrE3TM8= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR0301MB2060; X-Microsoft-Exchange-Diagnostics: 1; CY1PR0301MB2060; 31:l4Awd/h51GpTal7l0QMsb1fmbs2SHVGIHHMCk+9EurxuTCD2mXm2ycDWDQUePPy0Er1h0Y2V0lydszWD3mjsc2RTrbeKETu8P8yE2FfvXqWZb2eWjUJ6c/gAlZgTTsmsIWS7nDWo4Gmm3m7URa/3ZYmi7qnCCS8FQ1W6rsD1jhic6huJ16HZuNYtRanLFX60fskeb5/pdVzUx8b0K6bHhQ==; 4:QU7rgIik3I70hay3QVuoeZkCUCXduiLz+4YUE9PuOzxT2XuCK8FoJ/cQsmyI+YNpklE+8TULVQtpZpUGwJ1dFmgKq/30f0iDZIP2dJfQmExoucT5abuVF0T9I29g6iUB6haoTF+vfGybbKhl2XsPPqLAaEsfCVyhMcS2TKW0bpEcTwP3ZJOf0ITlTEl8gveqGLqAHWs3yxxM7iGet7Axpy47dxgaZhtfTLQe1OpP8UEP3Pqhn46h6nn9h+IMLyew2FL4UEVcbxByJGH7EoacQRDt2QdwRNOyFwsgU/rZ9BW13E99nYzhUs7JWAlspbu1sdkt3EfCvBEWWi9uO+Ne1mZnIByEprHeGtxKDi8Q0zw9DbcLlqAcjlIUGB5k9Xvcm9Q0kq3R2USaNeTbwNmEETzbNnu/bDmdwBrvT4egAL20QpQUk/uEY8ZTqEVQZFZzkqyq2mKtPjndjPoJ+2MGDlCKo4vrmpSVXazvFr0TNKe6GigJucl4sPc2Gfk10aFGnVGMu/lQW3PE5tYeABzxtg== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(2401047)(13023025)(13024025)(13015025)(13018025)(13017025)(8121501046)(5005006)(10201501046)(3002001)(6055026); SRVR:CY1PR0301MB2060; BCL:0; PCL:0; RULEID:(400006); SRVR:CY1PR0301MB2060; X-Forefront-PRVS: 0021920B5A X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY1PR0301MB2060; 23:kxlVMEHZFY+cPaSCuqFk5PTt8/kWaOT34VMpAe/?= =?us-ascii?Q?NZkZZvj/HlnGlrnwlyWS1vsyDcSyA/akBvRtObcEuMl8ijKGHVEBdC37bOq+?= =?us-ascii?Q?VSZQfQbNIWlZ8oB5nZaHhv26G6hvX6QwoivAhJIBH+rIHSupe1BZKiQEpATS?= =?us-ascii?Q?aoPJ6iQTgFuDAF+agQuvbfychP6JwWRfsmZpFk6/w4Km/TaKY+uBTSl575K9?= =?us-ascii?Q?Uj9IcednXOz7X0jSGa999K5yKIs5t1hpj/vLAsRtr1kBHrLJDtqfmMZ2hYrG?= =?us-ascii?Q?Uvu9awd/GgpuRY8X7L9rl55HmoZzpT2FvEVmHcXeFEuLDnsniVnbqsbr9h6Z?= =?us-ascii?Q?SbFirJZgrZ2jqhafm6LYpeXJftUyNsNc/n3QP/2dCJcJ/DDgQz+P9GPbsdfF?= =?us-ascii?Q?tE+MNy+JwtGzCzkRCiXobrKY9h2pXv8sV708Jp9tq005MbyEOdV3mLUfY3UZ?= =?us-ascii?Q?H3I7is7FM7yLKc2lsR76GPJr837r3FxqH/ocpK1qk35o0k/5YNpHP4cfFWVm?= =?us-ascii?Q?xYNi+2FFyQ6AMPShHZc7FV6HF1R8ocojJBa6iVtWc+FOWcZPztOEmalMc8Zp?= =?us-ascii?Q?elMkkDmuOFTHOcr9s5c8X+28zn3RqlizpIrlBSB9HEvO0QBijF8o2Pflbqoo?= =?us-ascii?Q?idNeTQU9ayVQ6lZ2B6f9FTHthzJZM4SLLhPPbxdlQJyUCG7Tg/41bzdOew8W?= =?us-ascii?Q?VLfE0Jf4s3A8IDvMWY6gRZg/Kx+ddZAVdTWPgtGHY3xLVDlQR3cTMRo2aqJZ?= =?us-ascii?Q?rKbEingvdRlsaYPx2dVyF55pJJNYk3dc8xFQkOyUWZ0OKJzJumCqzj7yBizT?= =?us-ascii?Q?VCG/KAtLedobUQsi+svxuG3ZQ4TQTXhiqpFT2zoY7xP9dMzlk/zLDeWxDpmx?= =?us-ascii?Q?NIQDDz/ZyLfF21hlRw4V8+XQUUalx59R+m69RatHnDW2BETUnoEqIsI2xaei?= =?us-ascii?Q?zSow7FLpnWYZQzxqfSXEpUcatZHFvhHZPrkeDGYCTGlYXpwBkCms/jAIKXl2?= =?us-ascii?Q?eMQuLKJwkH80xH1fVIlLu7oYhXX8p10/dyEibvqjO6C+RTbLM8XfK9NgoUgX?= =?us-ascii?Q?ANp4Ns7huV9hp6s+DH2oPmmm/+TJCj+1yG7Oah4Mo6WIK+UrNVAqU2ISDGDm?= =?us-ascii?Q?44bHUc46djldMUNl2CckH0k6kDg0ckfNdYjrcA+MpxWaZPYl1YgFmig=3D?= =?us-ascii?Q?=3D?= X-Microsoft-Exchange-Diagnostics: 1; CY1PR0301MB2060; 6:GWRwZvMlUc3+1qBeMmCob0Aj3r324FibDB45jxSU35bSyy8a1ZnTBkYTjxUUrzVQRjy/F7Bt6AoCT+0Qkdrr2IgKI6bAK5DCXjQcPiChs51OhviH3Go1fqfInJsP1LXISnliZEIZyNhXEBTWJhKHMiP64OW/EOtyVUjVn+SZgnlnwbxYkzEJa0iZcF6cq11snsII5DBmHsojyEtlRRIXipb9Q4XutrBQEJ8UYCmzQIg2UqSj8VWjyaxY5lW+rIzbmvSyBuY5ca20WnOLn5D6ahULDSh3woybL4AD0126pZY=; 5:/kEgVdbROJyJRF1jAnwPVWISAMmEY12W6vST64e7mg+ZoWfF4LbjEdW9QGzrVSXKm2jtvD0P2EdJHDFVo0fYU55ROHebyXGzemZSWjDegyElh6jqi2jPOFVpVaQ99MvDJIcvbhx9xu1SyFxBmsIYBmOS+1zzrEM7nZ170dTqj60=; 24:awwQivReCH8d20B3i4aEqV/7aRNNfpybB2t8e/YCC6Q3xppo43mxQhiXkTDwxtcgaUpgNQ5AI9CSF5vurggP+C+Y2aHB/pOOgGGQrKnbE9k=; 7:KHGY83XLGPh602WEjZHkT1EsdzaLwr9CEpWj7VomjlAZuE/sRQCZogczI133iMW4YhEReimoWmQ2HYMKq4lKC/Q4zXISbY6c1fFXSvOui7baEBX8XvINAVyzx3Ja0/IEK7mhwla2cY70ucbaYY2v+BInNZtzwmgllhrAy0o/1OOh7WgTezGkAsdQoxSYJ1AnRXgF3+T1TyUdoXtvgwUfkOTwOutGhDxAMJxxkwOySPrlDYArbXoMahcWVoW7kQ8Q SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Aug 2016 07:11:55.1392 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.158.2]; Helo=[az84smr01.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0301MB2060 X-Greylist: Sender DNS name whitelisted, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 01 Aug 2016 00:11:57 -0700 (PDT) List-ID: of_node_put needs to be called when the device node which is got from of_parse_phandle has finished using. Signed-off-by: Peter Chen --- drivers/net/ethernet/cavium/octeon/octeon_mgmt.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ethernet/cavium/octeon/octeon_mgmt.c b/drivers/net/ethernet/cavium/octeon/octeon_mgmt.c index e8bc15b..4ab404f 100644 --- a/drivers/net/ethernet/cavium/octeon/octeon_mgmt.c +++ b/drivers/net/ethernet/cavium/octeon/octeon_mgmt.c @@ -1513,6 +1513,7 @@ static int octeon_mgmt_probe(struct platform_device *pdev) return 0; err: + of_node_put(p->phy_np); free_netdev(netdev); return result; } @@ -1520,8 +1521,10 @@ err: static int octeon_mgmt_remove(struct platform_device *pdev) { struct net_device *netdev = platform_get_drvdata(pdev); + struct octeon_mgmt *p = netdev_priv(netdev); unregister_netdev(netdev); + of_node_put(p->phy_np); free_netdev(netdev); return 0; }