From patchwork Mon Aug 1 07:02:31 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Chen X-Patchwork-Id: 654523 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: davem@davemloft.net Delivered-To: davem-davemloft@shards.monkeyblade.net Received: from NAM03-DM3-obe.outbound.protection.outlook.com (mail-dm3nam03on0041.outbound.protection.outlook.com [104.47.41.41]) by shards.monkeyblade.net (Postfix) with ESMTPS id D76E5598F6C for ; Mon, 1 Aug 2016 00:11:46 -0700 (PDT) Received: from BN6PR03CA0031.namprd03.prod.outlook.com (10.175.124.17) by SN1PR0301MB2062.namprd03.prod.outlook.com (10.163.227.149) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.549.15; Mon, 1 Aug 2016 07:11:42 +0000 Received: from BY2FFO11FD048.protection.gbl (2a01:111:f400:7c0c::121) by BN6PR03CA0031.outlook.office365.com (2603:10b6:404:10c::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.549.15 via Frontend Transport; Mon, 1 Aug 2016 07:11:43 +0000 Authentication-Results: spf=fail (sender IP is 192.88.158.2) smtp.mailfrom=nxp.com; nxp.com; dkim=none (message not signed) header.d=none; nxp.com; dmarc=fail action=none header.from=nxp.com; nxp.com; dkim=none (message not signed) header.d=none; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.158.2 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.158.2; helo=az84smr01.freescale.net; Received: from az84smr01.freescale.net (192.88.158.2) by BY2FFO11FD048.mail.protection.outlook.com (10.1.15.176) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.549.5 via Frontend Transport; Mon, 1 Aug 2016 07:11:44 +0000 Received: from shlinux2.ap.freescale.net (shlinux2.ap.freescale.net [10.192.224.44]) by az84smr01.freescale.net (8.14.3/8.14.0) with ESMTP id u717BL1q013140; Mon, 1 Aug 2016 00:11:39 -0700 From: Peter Chen To: CC: , , , , , , , , , , , , , , , , , Peter Chen Subject: [PATCH v2 03/15] ethernet: arc: emac_main: add missing of_node_put after calling of_parse_phandle Date: Mon, 1 Aug 2016 15:02:31 +0800 Message-ID: <1470034963-30506-4-git-send-email-peter.chen@nxp.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1470034963-30506-1-git-send-email-peter.chen@nxp.com> References: <1470034963-30506-1-git-send-email-peter.chen@nxp.com> X-EOPAttributedMessage: 0 X-Matching-Connectors: 131145091049641281; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.158.2; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(979002)(6009001)(7916002)(2980300002)(1110001)(1109001)(339900001)(199003)(189002)(8666005)(8676002)(50466002)(81166006)(8936002)(81156014)(48376002)(50226002)(229853001)(76176999)(50986999)(7846002)(305945005)(106466001)(47776003)(2351001)(575784001)(86362001)(7416002)(356003)(87936001)(5003940100001)(69596002)(36756003)(104016004)(92566002)(19580405001)(19580395003)(2950100001)(110136002)(33646002)(97736004)(77096005)(586003)(105606002)(2906002)(68736007)(85426001)(4326007)(189998001)(7059030)(969003)(989001)(999001)(1009001)(1019001); DIR:OUT; SFP:1101; SCL:1; SRVR:SN1PR0301MB2062; H:az84smr01.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BY2FFO11FD048; 1:HX/nVjJHmrtfzN5pl32/2w+F6rl/JKViVpwqq13GXvsAMgc421JPHgGS/fBhW47fxE7tzm1rgDMH9gIsTsnqxKaNjqGcC8mGOVOJKy8Bzx1io/k9nASuLD5Y/PCa7IW7im4uqQ1ZvIIRpiDpoSRhgosSIBnjcbyoJDsMwpTT9DsEmoCdHhEC4YokvKVHGI2dCtAUWPnrlsh1HCUXPbyIhu1QACZrzwXzvGMavnfkiOdTpaxETtkYRpgVQg6br5332OpsLbjiUpHQXqJxQDrbaQgcpUk6teknXi9T+VH6ytti3wZrdUzSnnANjDCXN0JnoSbUK0aiyEZAlh45S5Z0da8uFHjbdrM0V/uBRQ8v8iQY1JWqqEuxE5Zze0mTr2tC3cClQJjJp9e5TDCEsO6rEwdr+whSXdcDeFVc/OHA+/fBmmsKGwuPRwztTYg31bPjymylIKF+8vOUkgM9wDLwLR8rkwU1kiQsuxKQZfvaRCt/ewxbNhKkeEi8M2hsAP/wh4asYeXbfs9nBGRnUiXgmsyxbmv1sPvSuxQ+ecHw2WPXtN+1q75EXqdgWwg1N/BxdrEPm4zqueo5G2H33npysqdl3qlxFp1gNpd4SIWk8JpzTwS9CaUoeUqGY1f2I8rYaBQa2np0sKlqK1MCOPiJH4RsoQROgo2jJfuhAXJQrMOzFi5rQTi67UrjZH4m86qhhysovoi0v7hqQX+d6FO7EpOCTgejrkidw1umr8AwLJI= MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: aa1eb7ea-6ce0-4fb3-d541-08d3b9db1883 X-Microsoft-Exchange-Diagnostics: 1; SN1PR0301MB2062; 2:Dv9NkEi8i5p1oxNAp8Wbp6tpJBvDVPtcMBJRkLTQl/CnvfZ4xPkk2EqFM9kSXWsuC5mPyvXQZ95NpI8dmR6KR7Zy3Hwug01hXCytrK0E6ePWIFdjZBqS94YhUSnqNCTith/x4T1zTjLIUdJVns/ZbPXAE6/5LTsEVWDHeQjgLXOuFrI4P6XARkliNBNll5as; 3:+qYC0CYu9BIj4E1AdnRI/i1s90IsGr69IX9Tb/FRt6BAC7ephg/yX0qqqOFaCu6D6oH7MiiIywbNVpDPb/cHnKkAPghUZu3ONYVkmgSC/AZPyuoXLqzLDsx4riFA/rvBGDPbOVda6MDsqZP7odaH36RwBzWl5TmQp52hQ1jjd7jHBipLrZ/NYjpc42vZN1cCdiabIc8Hq8MJx/yr9JBosrXs0wXCn4QVYqf0pJ50a00=; 25:VU7anlDr4XP3uMxoxLkot3DnTVoDhdJRgmUY8BsmhX/XqjOQDYwTTW5dc2G3sx/uN+L9y8I5kSxE+szh1s20dY4eS0C+oCr7lVRutR/1IDFfTk4LpFy1UgL5iPl8U/ara3v/psZ+9B+pMvDmcJEMQun07Eex9KDRim4aUj8GERy9ek/Jk22YXDwZPwmsAX3RCyj9wZIRRg0ZtU85XdywFMUKW+6DqfE/ORT18E0gz7/XHWYH71mcU36Z5YjFFtclElvFzIkPswgDBHehcGeKAg+qoW0DUhuRAcl/KPnitN+qCUrKz7CFTCOBh7lMIq6YnD62Z9uIyKo1eBBaEwGEdXcuhLcW4mTyQSF6ANMndKJ/w5OINytQeAlLDnjl8TlsiolAnjOEwNBXHec/rQY/ms+mAMqP8DgrDF9B8YQ2c1U= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:SN1PR0301MB2062; X-Microsoft-Exchange-Diagnostics: 1; SN1PR0301MB2062; 31:5yGLBEgII+o17LBOwy0TzcLcKeO0T2tS5SsCftCSBnGDRWW2eGpgG3a7sUEqhUGr7FAs+8PAg3zWU6ptYDEg0Zxni4sQQZaMOuVnB03DL/lk6vkpF4zv7PoxnGqGkqlIHPwB/Q5u40slCikuVm7QJlthopy78ixcmvZRu7lG+aP5x+xHQfcyDhbhYsUayO7V97MXr1DNmRphbvUyyf/Aqw==; 4:xRUSqqBlxqvOWNR0Z0ADeOlVAhntNMaQp8srN+O7y2Mtb2WRLsy96knLIvGGvkOhYk+Ve6XANT5nzKIsVN672OW+q5yjsNmGAVEzjbAZT2RcRfRHYz30z01OwCEUBhJ/sb52Pzrj7xj+fOwX8TqRyvqj9caokXTWJH627cDbsd2862hTUPRqrHfWBYGL0P8N4/NWK4QchuXFRuHTQ5ivQja6zPNzIxKuoUW3vMDqXOfziaADCdoNS0E+PqR8lYPkTf/JLhF3mg0dy4g6XbHRp8fLy30qElT2sYjQGcrAHlCQNbyDYFnsVh3GG0qjrtPwg/W5ufImwtE4jsLqcIOJBrroaUiMI2dJ3VeU71XTEIm4MZRn9tjrkqKO4KxZbXgGwZ+prs0Pd4zJY+kD9fw7rNnUolevmF2nQ1fP4po8ACbyF1l0DdK/Bwj6569ecbvdIPLWBsT4QndIkNo36NKodEkfbTcq6yNJ0LZ2ieYfLAYoM35VAMYEqp1IeXvpAZdICtzvy6QpQoo6svo4fr5tdA== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(2401047)(13023025)(13024025)(13015025)(13018025)(13017025)(8121501046)(5005006)(10201501046)(3002001)(6055026); SRVR:SN1PR0301MB2062; BCL:0; PCL:0; RULEID:(400006); SRVR:SN1PR0301MB2062; X-Forefront-PRVS: 0021920B5A X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; SN1PR0301MB2062; 23:0qu3td63URC5IUUCBoJsTPYbhwCr6gmy++1S5Mb?= =?us-ascii?Q?A4QS8Xe9bRoXUuTxswuskeS0Yae9RfB0MgU1xtd1+xstOc0lUDJdqLM7BJFQ?= =?us-ascii?Q?7PXeTxsBFTs3SOkALrh9qK9yAIxax+376Tu9IgNj/6MzKMzJ3o3eC/xwxpZ0?= =?us-ascii?Q?pr22dp0DWeIu937wPF6j2pUZtccU0p/q4+GJkP0xPO8lzuv2I8VBoIx60aui?= =?us-ascii?Q?vUblpHcXhIowMlnHAbDU4G5cpRPD2cQNDyymHrEdv9/4qCq3H4KAhPcXRNga?= =?us-ascii?Q?bIOsVHh7hS9g+fc/HTP9oVgDuf7g0JwonoY7hG/tQjOcy19ppTqKH2FpclAi?= =?us-ascii?Q?g928utLheD5eqs89hGQwWD7llmWlfkFgsG+N8jvl/40y64dwGToZ8Lrfyxj8?= =?us-ascii?Q?ct0cRG/p3tp6p1Gt7qU/vlwMPEUQ2sAVHJEPBmXzu3S4NSo/cetDMgg1pR8K?= =?us-ascii?Q?vYSbatCtxr/pDY76ZhzxoqzMF5onz13sOerYK87VYOmJGFa+09vZ/F9l+uJ1?= =?us-ascii?Q?vQeZ/j5jWLQkMfhqms7ULcWSJObUyiI6CqX60+I2Hy9M7k2OaKcq00AMhECC?= =?us-ascii?Q?lvc5FuMmDn5ht8NY0heFyuuSnjzBl6PkTwkrmIJmpvzD3r0dvxAhXMeSAq00?= =?us-ascii?Q?NRnALOlkaGL+MDImaQvi1KxqQPuUiIgly1AjKwmuwZLqzplYYEMAk1tC0uHr?= =?us-ascii?Q?bY5/72vaP1MyxkmC2YZXnORtNqEiPnJfLwqXPNXRY2MtYRT/6CAWPumHFlJr?= =?us-ascii?Q?XZvq+BlQpdSn/oXkBTbdg9KGxVVcx4aLnBi59UxkTFjkxBwnqPTBu69gxNuM?= =?us-ascii?Q?TMzLCo4jsK/VgoZmyPfSQp0r9eeIVn57mosXLe6yIM7SkPx2aqej2Eg3NfUe?= =?us-ascii?Q?AivwjOb3GD2/51+M5qUZhZdaMN+ji1cGftnYxly5M/sxZnXAqZodURvvGWKS?= =?us-ascii?Q?JqZ7N334ePMq9GyMhujAzUDIRzfjTzXjuS/JZ9W0Gc+gtO433Pm/j1EGxHXo?= =?us-ascii?Q?sG8iqS+4xPd3rKzdW3cNcvS7v14A4d99wONm5Vkp77/eBSMUdsd9L1CO/+OQ?= =?us-ascii?Q?GuVz46r83KdHFrLk9uHzWGnv5e77T7PBHz80I+pNFiExyGfgHDJlmUqUIls+?= =?us-ascii?Q?DHAVdQWoT+RpaPCQSKf8Hsrq0tLcc+HnHGKXNnROWFLz2SudslsoxhTgXV9X?= =?us-ascii?Q?NQZf8KCrEGrCInEdISraWf/7qdnuEnJjBapRpJe3Ls/vqzzfvmw0CwUKqr1v?= =?us-ascii?Q?6WpwnB8k51drODiWS14eGUmAOchVhYyLbKZhB9C8n?= X-Microsoft-Exchange-Diagnostics: 1; SN1PR0301MB2062; 6:ALZlP1H0CiiVEYB2mNYNHnDjb7xJ+ZbJIR6ukNnDK4Lkfr6UHOVySdVnV1gt7ZonjMXPZoYE5WAgFedk4hIkri+KY9D21Lsak9FuiARDeZA7r+yAiQWAAI+XmZtgQmnFzFgXm3EpMSeoWLbpkCZA3/GlmLBUK7+maH+Ju+Rbf/Unh7avegPutgcml2zmvycMHor79vZ9kRcOT+SaKrA989Y6UGNT8/sWizuzp3/zhqj23FPMNofyMWjkWWh7gCxpePaBWQDnrIhDOGjhP0hIKRWK+EF+tPIV/NdPH3Nw46g=; 5:pp0uGgM000NDA3gGt2FAQDPsV/oMuo+U4PQcLiMCjguBLWpDJVoYcV7LNmzeiHFVe73USOtZZVXPzMO5AKZAe5djZ6UfPPeHt7VhW6agV0q5l63OGlEmZCkUjakKgeYEhlyVJJdnh6EL0h03x3pisedkPY9QUm0C1+LkvyIFR5s=; 24:EFL3isX3vrDYdmJ2L3IT2d7j2Usmxay/3r5MBpv7z8WVtu2uG8bicijTLqWTKrIIHkss+pR30+XoMWzPdKPTFiUuoqlbWTWQkcRY2D/5sIk=; 7:Qhgi64Axy5UuBX1z6ItmjyuvCYAGnIFHF6e5cBd76Jf/MobbWiLjSLIUyb3tsiOEz8OgEfAnylv30ShvO1nzuvfY4K4suP95QiA8t2/IfLPVXBKK5ixJ1lA7MoCxeshSdOtQV4k5eVK61BqJZLmltXT6XQo08/x6LK+19zylhYiDUieYUWFpqyCCVfCkjjWFyw0ImIs5dxjgrWchJLFRfOdM3H8YJW92ABHZaJZTkw+PimkwLzZB067xXTJfB1Hy SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Aug 2016 07:11:44.8081 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.158.2]; Helo=[az84smr01.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR0301MB2062 X-Greylist: Sender DNS name whitelisted, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 01 Aug 2016 00:11:47 -0700 (PDT) List-ID: of_node_put needs to be called when the device node which is got from of_parse_phandle has finished using. Signed-off-by: Peter Chen --- drivers/net/ethernet/arc/emac_main.c | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/arc/emac_main.c b/drivers/net/ethernet/arc/emac_main.c index 586beda..4bff0f3 100644 --- a/drivers/net/ethernet/arc/emac_main.c +++ b/drivers/net/ethernet/arc/emac_main.c @@ -749,14 +749,16 @@ int arc_emac_probe(struct net_device *ndev, int interface) err = of_address_to_resource(dev->of_node, 0, &res_regs); if (err) { dev_err(dev, "failed to retrieve registers base from device tree\n"); - return -ENODEV; + err = -ENODEV; + goto out_put_node; } /* Get IRQ from device tree */ irq = irq_of_parse_and_map(dev->of_node, 0); if (!irq) { dev_err(dev, "failed to retrieve value from device tree\n"); - return -ENODEV; + err = -ENODEV; + goto out_put_node; } ndev->netdev_ops = &arc_emac_netdev_ops; @@ -778,7 +780,7 @@ int arc_emac_probe(struct net_device *ndev, int interface) err = clk_prepare_enable(priv->clk); if (err) { dev_err(dev, "failed to enable clock\n"); - return err; + goto out_put_node; } clock_frequency = clk_get_rate(priv->clk); @@ -787,7 +789,8 @@ int arc_emac_probe(struct net_device *ndev, int interface) if (of_property_read_u32(dev->of_node, "clock-frequency", &clock_frequency)) { dev_err(dev, "failed to retrieve from device tree\n"); - return -EINVAL; + err = -EINVAL; + goto out_put_node; } } @@ -867,6 +870,7 @@ int arc_emac_probe(struct net_device *ndev, int interface) goto out_netif_api; } + of_node_put(phy_node); return 0; out_netif_api: @@ -877,6 +881,9 @@ out_mdio: out_clken: if (priv->clk) clk_disable_unprepare(priv->clk); +out_put_node: + of_node_put(phy_node); + return err; } EXPORT_SYMBOL_GPL(arc_emac_probe);