From patchwork Mon Aug 1 07:02:37 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Chen X-Patchwork-Id: 654529 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: davem@davemloft.net Delivered-To: davem-davemloft@shards.monkeyblade.net Received: from NAM01-BN3-obe.outbound.protection.outlook.com (mail-bn3nam01on0070.outbound.protection.outlook.com [104.47.33.70]) by shards.monkeyblade.net (Postfix) with ESMTPS id 96640598F71 for ; Mon, 1 Aug 2016 00:12:18 -0700 (PDT) Received: from BLUPR0301CA0017.namprd03.prod.outlook.com (10.162.113.155) by BY2PR0301MB0696.namprd03.prod.outlook.com (10.160.63.150) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.549.15; Mon, 1 Aug 2016 07:12:15 +0000 Received: from BY2FFO11FD031.protection.gbl (2a01:111:f400:7c0c::150) by BLUPR0301CA0017.outlook.office365.com (2a01:111:e400:5259::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.549.15 via Frontend Transport; Mon, 1 Aug 2016 07:12:15 +0000 Authentication-Results: spf=fail (sender IP is 192.88.158.2) smtp.mailfrom=nxp.com; nxp.com; dkim=none (message not signed) header.d=none; nxp.com; dmarc=fail action=none header.from=nxp.com; nxp.com; dkim=none (message not signed) header.d=none; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.158.2 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.158.2; helo=az84smr01.freescale.net; Received: from az84smr01.freescale.net (192.88.158.2) by BY2FFO11FD031.mail.protection.outlook.com (10.1.14.196) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.549.5 via Frontend Transport; Mon, 1 Aug 2016 07:12:15 +0000 Received: from shlinux2.ap.freescale.net (shlinux2.ap.freescale.net [10.192.224.44]) by az84smr01.freescale.net (8.14.3/8.14.0) with ESMTP id u717BL1w013140; Mon, 1 Aug 2016 00:12:10 -0700 From: Peter Chen To: CC: , , , , , , , , , , , , , , , , , Peter Chen Subject: [PATCH v2 09/15] ethernet: marvell: mvpp2: add missing of_node_put after calling of_parse_phandle Date: Mon, 1 Aug 2016 15:02:37 +0800 Message-ID: <1470034963-30506-10-git-send-email-peter.chen@nxp.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1470034963-30506-1-git-send-email-peter.chen@nxp.com> References: <1470034963-30506-1-git-send-email-peter.chen@nxp.com> X-EOPAttributedMessage: 0 X-Matching-Connectors: 131145091362117230; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.158.2; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(7916002)(2980300002)(1109001)(1110001)(339900001)(199003)(189002)(50226002)(76176999)(5003940100001)(2906002)(7416002)(68736007)(86362001)(50986999)(36756003)(4326007)(305945005)(8936002)(81166006)(97736004)(47776003)(8676002)(11100500001)(586003)(7846002)(81156014)(356003)(8666005)(104016004)(87936001)(105606002)(189998001)(110136002)(77096005)(106466001)(33646002)(2950100001)(2351001)(229853001)(48376002)(69596002)(50466002)(92566002)(19580395003)(19580405001)(85426001)(7059030); DIR:OUT; SFP:1101; SCL:1; SRVR:BY2PR0301MB0696; H:az84smr01.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BY2FFO11FD031; 1:CZb1CH9xigthoon4qoKdzquVfak8UzovVuF+0bavqOysV/DBMr0xjCxOc/s6xLxkxWChEO+pqbeB6y7eW3Ft3kmWI8xzupNzs4hHolVGh6uO3Q3G7wnSH8WePcDjWUYeqxaeI7SlgFhMRmgEhsq2mSQiKKE0D8R21sDQ14zKGd1I+NkIV6tOCQg9tzWuzTqUQEYQJEDbFkpjzJnUcaAQYM+jZVUSlvE6oUE3wagAuy2Ggkac7mp44STebhayTJ1XMKalhwzMg+LfN+602neW/Vfi/EnnubwzkbGFdyJzaP+eBozz22FXccEBoMUpwW22StYkQb1915k84+m4/5rVVSZseBKXkPE4B9eNauk0fj5ehwgGHZDgSa0jtwxs479bA/kvh0VLpdpqQNq/U7+NoEBuewKRQMRKKOpKkgCUcsCwB9iFe+IcX1pkSnybbayoCy/UDntQ6dtPjEj3r6SrgFO9/1tTNp4fbofedmj+ZnVhxgEST8AASh1Tr91ouSnlcQSihR8J7cTtUgxYNjvMjlJofp+1YGX2U0uVmEqt0+TSO7ZQnCIcP5weR27nHCCTTr3qIpm/sA+lnTH6SP5ERfJuTRG8MyAIQ7m8iyt8NiDK3+iIOFEpGOrQ4X+7UeG3PV42Y2OswRST0/SkfzC4DgG/MabMKEzY5Ohn22XnDXwWasgRdiYtt+tJsc+mpbswDs65/0OH9QAZgCr/sIOGVud8wQeTPWYzEVVtMDIdDAQ= MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 810b0ab7-8096-484d-d66e-08d3b9db2b23 X-Microsoft-Exchange-Diagnostics: 1; BY2PR0301MB0696; 2:6GS/sYM4e8wsy/ywthlCeMnwJ6hYk96u5rDgpNFKJ8AivN52m1FEIGnsXBT5JCE5Lz/N7reWpsmzK08ZjggXDhEADz6KXcvMunT/leyLYbSxVsTFFUxSjxGMLz1pHpcehbJWgLEeTXvjL39LfdYjqZkBccCA2yEsu6BpVYk2irhGQRbvZgUQBlMbhAO2veno; 3:/IAG/LRxONLwwHmJ0oe28RzyE5TpDLddsoEMkrrYP5OCGuUcBXBtWmQ/LzdhcyuLIvceusx+1Qct8NOJvgggion9mYVWaRsAR2KlG+ObTlvsjv9Crh3mLmy0pFI14d5pYgzWAzLwnHPvTYJ+NDAEyMt2PGr07xxi0gutubZaQRyGUkaDe0mX+CGPWC1RucatAPvNP08T+U5l10piU3NG7JsC/U5Wbk2PRIWaPCGQp/w=; 25:YwgRcx0Ly6Nm3gxcAim2u2yDzCcB8oTvsD+DOgwocVI4pQjmXqWdPMVDiFTv0hC/1hz0VSs1UVTyAOPcqn7PkJGuj3Bu8Tq0r4FjTRbZP+RvhYK152Vo0kiS4KGkJ5x39RSmFcYup4+nnaFPuGD1FKMGG2XuS74HgQD1xjqskdR89Kfr0Hg8OhxEyr0jQ/LTX1bXrFQsBAr2LKImWw5XHwNfjfoMoOCwWhtRtZe8oeISKJ2jnGF3rVziFIQozWnEOvYxIzbTrHPe4B4e7QCfzoIF9uicf4gf/fLsgCnP5OblFkWYTs8bLIGc9XTV2iGgJZy7JEjX16F0nzdQuo//GK/hgeiWkybhzuupSGvGBOSisoE4eaFrqbmI6N9B2bSoah0rB6lFRZtQJAI09TtYFQ== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY2PR0301MB0696; X-Microsoft-Exchange-Diagnostics: 1; BY2PR0301MB0696; 31:64EUiBHRmoSefzhqdN/t9++WhKPTWNAmrhdGSblslfs+a5zA3tClQxVmUQ5mAU9XyFwRQHPSo0zFg0CfVV6KJJCKYYXLAc4GHVHNSr24uuqqVWbrbw29FgnQUw1ynWKON4pM9VnL6MsihceAtryBfFCNlmsrkjjo7v2BAq/msXO0a/eL6Sird3D75bdZ1TX0516YgvR3OV4XbK79WcvpPtrOLlPK+wkyBx9niA3+U/c=; 4:TvYv38XneSUz9XoyYYYk6IrSQwDMzlloUVRctFurpeEWScskWTkOC9ZGG+N8u9V0MtFQc3Dj7UOzxt5mA3VHgVdAINrn6QDfpmz81KXlEje97KRJar8InFRvNWywlyPqQXon4CEBE62u4v6tWplqZXdrLgODpNm1tZ7SMHIfSpJZsqHKYwVy5JdB2PpiPUCAwxkswmpqst61acn8RTpzcvjhp3KfJsHxa/hHChQKSqKFWuXCycYsxSgdmL8mPq4YpUlUp/hyPFTEJ6L4Qz/pgmAhBNJUJ8z1F44aM3irtzV3OsGB8xsJZHuiQ2jKYOHFC0NmcM3c94+XFR4C9fgz1VsHyTOgif5tUkkjCjarKP2vV43eqqdMudOWYDLn3a456GeyYHa1Em/oPlHcyBO42oGPsOYChVcX0Zj9toHRcT03UXN2NnTwb6aINBBR1M6liUan66DHGesUhIDtXEDfEWXF7twZ8dRaiNGIO4ANkcFUruFMWNPyM/HOyiqeAvWtNLZZkTPuzj2IEXttvIryQA== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(2401047)(13018025)(8121501046)(13024025)(13023025)(13015025)(13017025)(5005006)(10201501046)(3002001)(6055026); SRVR:BY2PR0301MB0696; BCL:0; PCL:0; RULEID:(400006); SRVR:BY2PR0301MB0696; X-Forefront-PRVS: 0021920B5A X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BY2PR0301MB0696; 23:GhgkamJhpw56TulncleBdFC7YTcGpz1gz30Qpsb?= =?us-ascii?Q?X36dViciFNnv6bbYroDCN3F4IfJdh6cnLI0w9D3waADnTBvLsjgZi8FN0Qme?= =?us-ascii?Q?cdfRrMg9wbvD7zaeUjL6y8d1Hs7eODpRBD9bhC1jyt/B22aL1o1Jd0nIG8n5?= =?us-ascii?Q?c4lQTPOWS9bZR4tq42HDhhOrGc0SLp5U0ou1phRjvqXQPc87HdwP/Oyik79e?= =?us-ascii?Q?L10nvJX1wnUB6Pd91FXbp39+UgqXpsrkl4aAGRH8Ac+C0t5ktNHDv6nx/E/u?= =?us-ascii?Q?1C4wymPvXmDe2kIJBPmFwCDpZhG0e6eSDgAdpvY8rwupKqBC0tuL7COX52L6?= =?us-ascii?Q?S9KucWWJkCqld1qughqY5mwRgLxfaPrFWrBxCJVJGiULzrrerYxtYp6OSQL0?= =?us-ascii?Q?BIXG7/C7vkk09lpblaGYN13q2zZ7VvlJg2h6DqaTOzGBAFGNvhHO9YbHeHZa?= =?us-ascii?Q?SIHs2TCSKW8nAAEhxpOFHgjvjsMEAT1BN0RSF1+tC3T1Mg8jmou4IEff7Myd?= =?us-ascii?Q?hkNGQ54zOYzdgpUcntVR0lj6icqSrppjwKmyJO1LMyiI+bCWw781da5p+2wF?= =?us-ascii?Q?w1RmSGlf5lMpqWpk02AHG7uOcQUb+3J6mcVJgIKdl2U7KxV3A3qLmTEEQze5?= =?us-ascii?Q?Kxdsys0xfnkI8BRnf248wgx30Wszy7zRmZbIWHhVGdVTewRlYc5cI7hNEEXf?= =?us-ascii?Q?4i/zfIBOGXtBpo9L57goHXCaa7xGsYo9zTyUrAuHO7/0VEWTv60UtQfcd8Mp?= =?us-ascii?Q?lF7xmJXSkuoFagmRPCE+ajDFgmBGz8TG0521vLWt5R8hqJkdM1mfdCDezCj5?= =?us-ascii?Q?Qx39qeHnYBO/6kl9WLGWF5T5zYOZyPKAdXmWhW95DDXWrWFnMwLKGf1HCU8h?= =?us-ascii?Q?cgW+TkOXNKSNxofMyRxOSsybgQJXOD57k80piEAD735La1MFxeLDLDAddkbl?= =?us-ascii?Q?7SizTetivyA/0EdNEM7EGQTXrCSfa7kdkLXL5Nh3V1aMnjfG2FfPzQeXvBu+?= =?us-ascii?Q?wMLgaxLxji/Mu5iCU4muXEJxxg7wUaiQ4euJXMDz6e4UVibyw2WwgmCxsgvR?= =?us-ascii?Q?6wek5N0Nq1BntmjGO47d1MD9kTV6SfsMLUCYZMIMp9jeRhlIwM66y50SkSeH?= =?us-ascii?Q?p8jU/i2YNJofh6ZCJiaNwAJyJ03yZjD50FpU+46qW180iegpCE3Oq4w=3D?= =?us-ascii?Q?=3D?= X-Microsoft-Exchange-Diagnostics: 1; BY2PR0301MB0696; 6:qJJ6Mx60cISaRLYSBbrVOFxFZ+pOyrO00v68I1FpyWsJKpbg18sY3+nT2HP9VeGRkhD0nQtqnxwCZbq2jJdP9ggAhkY678GF58MgbbOlddV4grBJkBxsHljSpp/beicBXBqv1SzXKaOGuNYWh8lJfh1fbV/stMAWqTTNsV62ev3kudfA2ezofl1X03Bei3Soi6uozHgApANlsYEb6q0fAjRBXyj4f4AI2jRgM2E1WMqlcVDa0x2WK5/MIutn6ecssCrtWuNelBsBQvorUev5r5Zz1wq3GvI055UUei/+Bzc=; 5:TaLTY0q4xk9NKHk+9PKA+ggTD1M86E/oOX5Tsd83VGDi1qt2PO9vrPGKmK6EQebnCJ4yhSdXX50TF6omkqCS5mkIebWmUjqj/Pk0rdbnbkLYYoFsReVMWQNJdYY3QYIHsbNmam1jmuy54uvO8GcwS/MlMFo/99nJN3cX6q0gK5w=; 24:z3Vs1PTqn56GIVrXJ0owln0BCqNpN5WWmMR8fUpqO3nhJxjACTambiGg89KO/TvOm4EU4pFXqMICrXRpHwhZLPxAB9MWb62pW6iWb16asM0=; 7:gXy3W9kFoWD5+Xy6kpzPO/ExHSjrBMgREcR2Wb49K2RNnX2S+/CfaHV4JC5rElNiUdRhVcYxg9jmkW1rRS66jxpnQRUCxiP8Q/R9qlSP5wdz1UyQnr/6HdtfhYF61tYvky3/ksmKmLQ/p2HgpqP2rSQ/TSd7jGjzEsK3ICItfUOHlrynNGU/XTGuj27cDAoMVIO0RqczEWuADqaf1vUwr39JWjFT9CNwR7U7kMXa1usePKjZuFVWiBEbtZj1E6sW SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Aug 2016 07:12:15.8685 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.158.2]; Helo=[az84smr01.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR0301MB0696 X-Greylist: Sender DNS name whitelisted, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 01 Aug 2016 00:12:18 -0700 (PDT) List-ID: of_node_put needs to be called when the device node which is got from of_parse_phandle has finished using. Signed-off-by: Peter Chen --- drivers/net/ethernet/marvell/mvpp2.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/marvell/mvpp2.c b/drivers/net/ethernet/marvell/mvpp2.c index 0b04717..60227a3 100644 --- a/drivers/net/ethernet/marvell/mvpp2.c +++ b/drivers/net/ethernet/marvell/mvpp2.c @@ -6234,6 +6234,7 @@ err_free_stats: err_free_irq: irq_dispose_mapping(port->irq); err_free_netdev: + of_node_put(phy_node); free_netdev(dev); return err; } @@ -6244,6 +6245,7 @@ static void mvpp2_port_remove(struct mvpp2_port *port) int i; unregister_netdev(port->dev); + of_node_put(port->phy_node); free_percpu(port->pcpu); free_percpu(port->stats); for (i = 0; i < txq_number; i++)