From patchwork Sun Jul 31 11:42:33 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heinrich Schuchardt X-Patchwork-Id: 654352 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3s2LF91sDLz9t0j for ; Sun, 31 Jul 2016 21:43:09 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753415AbcGaLmr (ORCPT ); Sun, 31 Jul 2016 07:42:47 -0400 Received: from mout.gmx.net ([212.227.17.22]:56174 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751773AbcGaLmn (ORCPT ); Sun, 31 Jul 2016 07:42:43 -0400 Received: from LT002.fritz.box ([109.91.48.91]) by mail.gmx.com (mrgmx103) with ESMTPSA (Nemesis) id 0Lqhaw-1aqeuC0eKQ-00eK1v; Sun, 31 Jul 2016 13:42:38 +0200 From: Heinrich Schuchardt To: Sergei Shtylyov , Florian Fainelli Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Heinrich Schuchardt Subject: [PATCH 1/1 v2] dsa: b53: remove redundant if Date: Sun, 31 Jul 2016 13:42:33 +0200 Message-Id: <1469965353-3496-1-git-send-email-xypron.glpk@gmx.de> X-Mailer: git-send-email 2.8.1 In-Reply-To: References: X-Provags-ID: V03:K0:fBJbdT9c/5xdbZgduLMBsZGKaPuxCdcFf25z4RkCLfYpWF4t4k/ UzGx5aCSYokQeoFBgNUljwugr0Y7pBRUbVUThvbaFWb8OVHS8hnbv/9k2Dn4A/KMpSuV/3v Qkj6at3+BO/wX06b/z/8TgEnemeGU2x0pRucH5qYMxcVyF7Q0iMClzfQ41oWWyEZUwfnqCJ L4DYcxfTCQP0cr4w5Udnw== X-UI-Out-Filterresults: notjunk:1; V01:K0:3PHNo2xvGcI=:D86ONYzjRWq7hu+I/Cwj8H 9bLKbkxgIBPjYHzZAaplhWgfcapLlsMUV2wrgLbvr0GxpWLuOyrGXocsZpltE+XIsqdLYi75v udYvIyxTyQzFROxufCAEpxbHCAw77SjfAoW78Yl4MszUG7CAztWdFL1X5S5FNd1E+7LPWHwXd 0lMB4TNOzAKjabR6w3JtidZammCi8bxjqAEOoXIiYx5Lt2xBI2kgfBP2Bk4HocINxXr1hhLI8 PXTPfDzSjtVBr6qerlhHUn/zDpkqTRrE4OmxdwOXVoBVyncS1Fo99qaZUdlH7zxUjNay/6FAB TBB0+yzQtaqQhJv7IIKOcqEA7D0y37/ksInUgsYNTrf/xG5XmVfnufRMjqOXscncleaJ5f9Tj DwxMB4Fv7caMnbpLwyJT73zM43LwFYFXXyZ6XFUluXXO9ZI4zmq/Jn/vc5RZSAgUcRDDyKxI2 /HYRliHzFDRflOjZ/CY8CnBG/PJ/YU3nI8EDdvKVTB/wHsioobqnBG3IGZn0uekJRX4uaoiSh rTmmgzz5km62a1OE37UP+878m98EzX9zlbrpS9fgkcVvexn1AsNW8jDmrQz1DgrUaJybd1NOf 9VhZznyqGxtEvMgvQY/wBE1+BJWJ+pQSZ5kQTQnJnvfyKxBxGpeg0OxW5JSUUDKnsoIr2vzG9 6s8bMDsNqHRA03kZEIKFr8m90wVbqUqmtTvAwHuwyZSIdSOkxH3G9KTzM+tX+7E0LybckRzDa ewOoSWUdhFn/GFMpE2NywpGq8+TkE6mUJPVmynxguLvg5vAahpq4sCoWQk4= Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org For pdata == null the code leaves with an error. There is no need to check the condition again. Signed-off-by: Heinrich Schuchardt --- drivers/net/dsa/b53/b53_mmap.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/dsa/b53/b53_mmap.c b/drivers/net/dsa/b53/b53_mmap.c index 21f1068..77ffc43 100644 --- a/drivers/net/dsa/b53/b53_mmap.c +++ b/drivers/net/dsa/b53/b53_mmap.c @@ -233,8 +233,7 @@ static int b53_mmap_probe(struct platform_device *pdev) if (!dev) return -ENOMEM; - if (pdata) - dev->pdata = pdata; + dev->pdata = pdata; platform_set_drvdata(pdev, dev);