From patchwork Thu Jul 28 13:16:50 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zhu Yanjun X-Patchwork-Id: 653720 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3s0Xdl6bKjz9t0d for ; Thu, 28 Jul 2016 23:24:43 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758027AbcG1NYl (ORCPT ); Thu, 28 Jul 2016 09:24:41 -0400 Received: from [123.119.172.174] ([123.119.172.174]:47600 "EHLO mail.rain.com" rhost-flags-FAIL-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1757859AbcG1NYi (ORCPT ); Thu, 28 Jul 2016 09:24:38 -0400 X-Greylist: delayed 597 seconds by postgrey-1.27 at vger.kernel.org; Thu, 28 Jul 2016 09:24:36 EDT Received: from mail.rain.com (mail.rain.com [192.168.2.102]) by mail.rain.com (Postfix) with ESMTPA id 7ED975C30FE; Thu, 28 Jul 2016 21:16:55 +0800 (CST) From: zyjzyj2000@gmail.com To: jeffrey.t.kirsher@intel.com, intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Zhu Yanjun Subject: [PATCH 1/1] ixgbevf: replace integer number with bool value Date: Thu, 28 Jul 2016 21:16:50 +0800 Message-Id: <1469711810-4557-1-git-send-email-zyjzyj2000@gmail.com> X-Mailer: git-send-email 2.7.4 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Zhu Yanjun The variable get_mac_status is a bool variable. So a bool value is better than an integer number. Signed-off-by: Zhu Yanjun --- drivers/net/ethernet/intel/ixgbevf/ethtool.c | 2 +- drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/intel/ixgbevf/ethtool.c b/drivers/net/ethernet/intel/ixgbevf/ethtool.c index 508e72c..ce221d1 100644 --- a/drivers/net/ethernet/intel/ixgbevf/ethtool.c +++ b/drivers/net/ethernet/intel/ixgbevf/ethtool.c @@ -104,7 +104,7 @@ static int ixgbevf_get_settings(struct net_device *netdev, ecmd->transceiver = XCVR_DUMMY1; ecmd->port = -1; - hw->mac.get_link_status = 1; + hw->mac.get_link_status = true; hw->mac.ops.check_link(hw, &link_speed, &link_up, false); if (link_up) { diff --git a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c index acc2401..a98e7c2 100644 --- a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c +++ b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c @@ -1285,7 +1285,7 @@ static irqreturn_t ixgbevf_msix_other(int irq, void *data) struct ixgbevf_adapter *adapter = data; struct ixgbe_hw *hw = &adapter->hw; - hw->mac.get_link_status = 1; + hw->mac.get_link_status = true; ixgbevf_service_event_schedule(adapter); @@ -2109,7 +2109,7 @@ static void ixgbevf_up_complete(struct ixgbevf_adapter *adapter) ixgbevf_save_reset_stats(adapter); ixgbevf_init_last_counter_stats(adapter); - hw->mac.get_link_status = 1; + hw->mac.get_link_status = true; mod_timer(&adapter->service_timer, jiffies); }