From patchwork Wed Jul 27 02:20:40 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Chen X-Patchwork-Id: 653052 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3rzfVQ64SWz9t1p for ; Wed, 27 Jul 2016 12:45:18 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161391AbcG0CpO (ORCPT ); Tue, 26 Jul 2016 22:45:14 -0400 Received: from mail-co1nam03on0064.outbound.protection.outlook.com ([104.47.40.64]:59447 "EHLO NAM03-CO1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1161311AbcG0CpL (ORCPT ); Tue, 26 Jul 2016 22:45:11 -0400 Received: from BN3PR0301CA0028.namprd03.prod.outlook.com (10.160.180.166) by CY4PR03MB2488.namprd03.prod.outlook.com (10.168.165.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.544.10; Wed, 27 Jul 2016 02:30:01 +0000 Received: from BN1AFFO11FD020.protection.gbl (2a01:111:f400:7c10::164) by BN3PR0301CA0028.outlook.office365.com (2a01:111:e400:4000::38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.544.10 via Frontend Transport; Wed, 27 Jul 2016 02:30:02 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; nxp.com; dkim=none (message not signed) header.d=none; nxp.com; dmarc=fail action=none header.from=nxp.com; nxp.com; dkim=none (message not signed) header.d=none; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BN1AFFO11FD020.mail.protection.outlook.com (10.58.52.80) with Microsoft SMTP Server (TLS) id 15.1.539.16 via Frontend Transport; Wed, 27 Jul 2016 02:30:02 +0000 Received: from shlinux2.ap.freescale.net (shlinux2.ap.freescale.net [10.192.224.44]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id u6R2T9Kk016285; Tue, 26 Jul 2016 19:29:57 -0700 From: Peter Chen To: CC: , , , , , , , , , , , , , , , , , Peter Chen Subject: [PATCH 07/15] ethernet: hisilicon: hns: hns_dsaf_main: add missing of_node_put after calling of_parse_phandle Date: Wed, 27 Jul 2016 10:20:40 +0800 Message-ID: <1469586048-15697-8-git-send-email-peter.chen@nxp.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1469586048-15697-1-git-send-email-peter.chen@nxp.com> References: <1469586048-15697-1-git-send-email-peter.chen@nxp.com> X-EOPAttributedMessage: 0 X-Matching-Connectors: 131140602030899136; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(7916002)(2980300002)(1110001)(1109001)(339900001)(199003)(189002)(11100500001)(87936001)(5003940100001)(50466002)(189998001)(76176999)(19580395003)(19580405001)(97736004)(33646002)(50986999)(48376002)(110136002)(86362001)(36756003)(229853001)(92566002)(85426001)(2351001)(68736007)(106466001)(586003)(8676002)(4326007)(81166006)(2906002)(2950100001)(104016004)(8666005)(77096005)(356003)(105606002)(47776003)(8936002)(6806005)(50226002)(7846002)(81156014)(305945005)(7059030); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR03MB2488; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1AFFO11FD020; 1:aChhn9JaB696hopfnyjagS2nqgghnix3Wlt74X9rFDNeitYmziF7ihZEXl1Lcscc0do99RojP2eZ0+9BkywnE4XJKHYy4vZiNWHFKD8Q2zvgctcO4BFCtcOzV2JVS4KCFLHqvI9od8xcKrIlUR0Bj7B52nsLlhwJ0FWuRWODWiIw4mrjMgdqDRLH9Sv0Ohw8TZBFHPj7F2YUTWpahKedIt2K30DqguLisDb7zNcu1N+638ZlQgvBMs3i57UhZsBDxuselE4ZTb8zFdWJd7etI1tqv2W6x69qSRHZlVTotW1DzmCyOUf2BnIC0JCCa435+bN8MHn0wfJAfPqqRK6+BOCxb8iQrJw/oq37VwBpLGFpBHuTyQlMVXrTQtlGjc/uiJ3HS8xaTf5YDUgxpELdhkvNVlk7naUfxo4vHCM8oWx1T/JZSkBS30csNfwpVmkay9qC34QiIfqXDdHl4WU5USC40MR9hMqmKxpXBPD7j8EuAFkjoHT/PN5Lcv5uDzco+1qitfLbGVjoLDmPgAPhNpBVJZpGlnXswZSs9sblaWPqDb/WHY8ABX9IXxEWw1Z4Xjy5XdWYTQp3PT3yaBfD2+cuXS2OeNgZfvUhgp9xzXCBDvzwnsKYlzo+lJEYHaQi1FWyGR2+jfG5Gee2ILb8+er2lzlH7GG8YwolNrzpPNfcSQVNVBPOBFf0DSt/2eaPbWY8SsHSUHy/oR+P9sLSiCY+/AIrnaBUpEV+ayxwdE8= MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 93d8d6e2-f65e-489c-5e5f-08d3b5c5ea23 X-Microsoft-Exchange-Diagnostics: 1; CY4PR03MB2488; 2:TjUBmpVygnT5FYNfpLb1IG0t0gXsKhQunG0B4Zl15p6FF5YAQKbC8WLN9zZCNL2dlF9E9FFOB0bJuc2W/wF1ObeWmZI7ymDTRv7upN0GVijut0XBXhuLlDHvueAC68pd6dOO5/s+xItWFJi/I2KWVs79+F0vNJldgHIElhDZI7GV+GEn5+W8dda9/6SX4SYY; 3:VVKoESmsTaEXlfnvfJ3VEnqFGks6sE+7JzscSyAFGyuu2dMIv+LPdzN4jP6/SYzVkeV/oej7qRFxQypzEfJ+bfKAlj1WuYQIJfGECP3ef5Ur0Xn1yWNtdgLo54Ux9q5ZQeYzTKVJHhoXL8FDRLIkIwtmZlk7mtZrqP1E90tyIHL1iR+k45cv1+N+T7C28eg6rha2gTE0LPL5AECJT8Ju6vFpdQ4qH9PWKsNN7DT2R3U= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY4PR03MB2488; X-Microsoft-Exchange-Diagnostics: 1; CY4PR03MB2488; 25:Ig04qplh4RyJHxihXpfDACKLLgtNKqysD4298puitSJ7cIdyWqSmYog91yTBZtCPmKckXhk4rMHMkaJHCz4BiYrO+Bh81UO+wCC4xkixmNkeMlcymw/YTpZgRm7jJLYsJQYdi0VrxVF9IZuNSuqzQiTQgSxhUuxgIyLw6U0hDFRVVr2DUdDU90rngS33FvwDgrRz80rp8goxjFw+NY9Cm6YURCa7VojYRpsTTrV9YnPIqzjM7y8ripBAHJjBA/R0cbsxRydUGw4yHwTJgK047IeFomnvSrVkq61yLg1f3sIOxJK6/FXCEGvHb/zAAJC8ChY+/Eudpqjkk1GXFlrF2Rpo2XB0DF5X7WjiukrMzDPu+Ls4Im5jNBI1LmPqEQa7a29K8rV1u343K2YKYzsE2qH+loQp2y3cme22RpYvzGl5pGJECnglVjYWOnCIBqCKbB/LdE9EVp70hkm9d6y7Yo8dKuzB7zjmMXiobX0H/dAvIqG5/pLOYQ5rZ/tV7tRRKYOoXIIJUlxuHgFyg2JOTCXT4GBdcCjAp/csv+sklZY78V78+ipqVYl3g2bpwWA7G2oNvbyMYtZdIlECdyoxb2uyR6EWdO+jst1ZAQ5d6oybzOc1m7d2q1EVeFOsf1KPGKoc4usFgqi1Oy9sT7dxmfOp7Bxzmsg1I9EVPJHzLDg50+u7eN6L71zkmgEV6DVIdHrZEyxSjOw4TLblWgrFgg==; 31:gTYB9fITsFrRBudM26YpknEW3WGxZBXUTPWGKDfS7g+XUgitBiTnhYDPGYFKRzIqP/hOadSMju+F13aHVD6/OF+IfrKtWRZyHW0igesCvsBRkUCaOtR8euDXaDroJiC5t17J67d2FxbiSLcs4hkhEtQVOSWrCx1CrjGOr6t7Js/UFUIGS7x71+dRuipZn1guRgHRUo/CvLGnsBTzfL3NjQ== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(2401047)(8121501046)(13024025)(13017025)(13023025)(13015025)(13018025)(5005006)(3002001)(10201501046)(6055026); SRVR:CY4PR03MB2488; BCL:0; PCL:0; RULEID:(400006); SRVR:CY4PR03MB2488; X-Microsoft-Exchange-Diagnostics: 1; CY4PR03MB2488; 4:paX5xSlgYMtHlI1NzcLEyuSYZ7pW+neQg0eS/0+hMhQNIFbw0V60wNI4469neNwYkoUuy4d393ORtl5kMaBvJhTeQH5eLYmjsQ3je+0sYk4n3OEpqXE76Pd4SVVSp+O8bBQHkmTWbhJCZycMQprjSizsvX9j+0FTFBJIKXmzsKJ+nytQoStLwO6fsAy6JuxneinU3nlL+INbKepM62hfM3U65yJSzei20pKJWrcdw6m87hPvRC9mmb6mOxee8ysxuTlIGZaYax2SpaFBM5sabCJGhZ6dGGz4JiNpTbgamLQN3fRz2B99XJlSgmKMgfzoUF8/G/Joenuw21ofjlhOs5iS5BIf4cGRAa04JpYgR4ZAkXr8jpHwsDbx9dy0MHufhiN8yBWsXMcQL6A0hg9mVfbDu8jqx8zX3EK6J9bhuEAMXuSYxzkcHYEgb2rbYATjEyq2co62pgkJ/RzunWyNKKkfnKgFZO7R5kE0aZfX10glvkUytzSXMF5U3WMCfPfthoihrjbMczmFYXtEBPUx+Q== X-Forefront-PRVS: 0016DEFF96 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY4PR03MB2488; 23:RolEK7kCRQuO3acoh7isFZqpKY/RFFX4ohmFWWmHJ?= =?us-ascii?Q?hcm6FpcdJDshE3GT6g6lFAfK3NUAzi5qQlpvZuGd0MSnRdKjPFmDrGcPmvsW?= =?us-ascii?Q?guht/ffdfYhrGOkopSWYdQdmdiCVfcsRDEUBEkDfh9+1kXl6ChCEY0Fb4pjw?= =?us-ascii?Q?2GcR3gL77JmK2SCuVFEpnI30b5rC3y+RRKUw+K5l0PC4lFFe0z9ZLuS02/SQ?= =?us-ascii?Q?rzlfzzLVatCl0J61teGfBCUPCb7WBTvVbl1dGNoXUUMo+7xscY4C6L/vPOvN?= =?us-ascii?Q?u46p86Ii7jHWLju7ZEMdz93O+K8ctaGGnHvdetSuVROP8JOxNSLu3ISCGYCp?= =?us-ascii?Q?dCOZ6DDOdSV2kIEfsT0nXfjMqszNtRXDfITyPijjp2WGRJ/1mrQc4tOy9eHF?= =?us-ascii?Q?CBzqdfx0A3tEf3NhVUJYAQFdSklZYeUaALKnI7hT6pMx83lTEypsfiyb9fxF?= =?us-ascii?Q?DJXprZkteVXq4DrbAjh4+cjaW+WYA8ytxjTD/0WrZHgCbyh4JiZcoXM36DsS?= =?us-ascii?Q?HRtAg0j1hVQhMjWedWTG0gBN+jI7L7cGRtjYwkUEg+Q3pt4rkSimJI4bb31+?= =?us-ascii?Q?JCS1zysDpDYRHchuYMkhjATADoJOB6V0nb4WkHvQf5ynRMM7ESfVS6xG9MOf?= =?us-ascii?Q?s5BSNVViHtLfm3Ep4YYrMu+9P9qTdZ6yFQcKcYbTcBrA/nSavPxK5Id0A9zX?= =?us-ascii?Q?pZeoDKL/jXOPw9rsu7x9RCcv1R8VZjVTTkvneAB5GktcqkxdoCv9NAidC8Gg?= =?us-ascii?Q?WtB9dX4QM7UYnCUxIfPh3ycQSX3Hn7eYIYxVhQ3ZI/AxZFXBt9ayazIeEKaS?= =?us-ascii?Q?3qz/72pxVpjvAmRiSZHpJy8ORTePAQqjL08AsIi9pDdc6iC3Y0b0x8Kfqyo1?= =?us-ascii?Q?ORjxos7oW3y8ecFShTObyxdk6jBA9IBTjYW0sVgxx9QvWDkoJLAHLa88VtLO?= =?us-ascii?Q?XhJcMY+I8TS+6IBC3pDSfde6LzuOm4aYgjBfyH+TP8YSua6Iu6xYA2Vadc0F?= =?us-ascii?Q?1gA/v71w74lrSKXEponFrhwOZQm1LwQazjrfKmXh8uIoF683Bmht2C6nYq0I?= =?us-ascii?Q?ODyDMy+g6N7k0hEHxGLgWPKlIgLkjScPU9mEA1z/vFzkVae+R9bY9oOKXgLn?= =?us-ascii?Q?3D8zovh1BDh/aroT/BvewMUOTvuRLgI?= X-Microsoft-Exchange-Diagnostics: 1; CY4PR03MB2488; 6:U1Uw0xdZsT0XLrDCFtFwSyk29vPbMtZk6XwU6tphLiazD1jyzkDyq7/pfL5ErkskjaJaOZgvRN5F+zsfP8wPfYOjZynrgoMiVyacoxF3PVWAbPi9MYpiUkQd0EPxacVdcNJPJGzmFfnCGG7LBfQ7c5RmQQsdZvw9DpBT6MM41zUaVGEIVKHqujwNV+LObDtK2mziAwpEJNTu0EaqHXePuajuBs7YgHsoEPvVhV1PIpEHgqCvOH2z+XDraoDoJi3jEt2md/4q0tT+Hw7WvsfeoOq4oUojwjVChmPzGCQ39vc=; 5:xZ3UyCQEv5TIgIWni4fDsykUL8ZJTZPEzRhz+MIjO8nH5933d8HIKZtVNqiCDmI1G+FxTdKTesMHHQfXJJQvgHuJ02i5KXsi1bFiktZOi3IpTYq4by2RXUljuwQax2UE8eBGr3xzkOaupzrh/uHSuIyy7zXZiDI42kNBFIEHpVo=; 24:MQ6sD5JNOnUfU73q9CMaRv1nV7b3rnMrMTi5j/oEXsmhh0nuVZ32Y/v9SR5tC3qaGGoXCLUd0UDsGei6udDFpvJTbR5s/TDrXNsec2b8h5Y=; 7:IgBDPXxuMWAvBgw//3T08owMGceRjUAL56fYjfrN7sx5ut/qPMSxU5Q1t6kUQ9BmjRevaM88d0DLE5dIrtvq7J5lBgg2bLiuQE6Tg9tei5dEzZumrHF6mnK+CJogTePK3iR7sxgZOTtemC55gHlZK2ardlxiBY4xzyrARaH0FNBm7CwrR5KQm1PxOTZqMNp6jEOyRA3laZAlOZoQLbwFEuOR7rouXstP4v6OiIhCoqrP0bbZBV3nNTcbqWrVEtat SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2016 02:30:02.8403 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR03MB2488 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org of_node_put needs to be called when the device node which is got from of_parse_phandle has finished using. Signed-off-by: Peter Chen --- drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c index 2ef4277..afb5daa 100644 --- a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c +++ b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c @@ -51,7 +51,7 @@ int hns_dsaf_get_cfg(struct dsaf_device *dsaf_dev) const char *mode_str; struct regmap *syscon; struct resource *res; - struct device_node *np = dsaf_dev->dev->of_node; + struct device_node *np = dsaf_dev->dev->of_node, *np_temp; struct platform_device *pdev = to_platform_device(dsaf_dev->dev); if (dev_of_node(dsaf_dev->dev)) { @@ -102,8 +102,9 @@ int hns_dsaf_get_cfg(struct dsaf_device *dsaf_dev) dsaf_dev->dsaf_tc_mode = HRD_DSAF_4TC_MODE; if (dev_of_node(dsaf_dev->dev)) { - syscon = syscon_node_to_regmap( - of_parse_phandle(np, "subctrl-syscon", 0)); + np_temp = of_parse_phandle(np, "subctrl-syscon", 0); + syscon = syscon_node_to_regmap(np_temp); + of_node_put(np_temp); if (IS_ERR_OR_NULL(syscon)) { res = platform_get_resource(pdev, IORESOURCE_MEM, res_idx++);