From patchwork Wed Jul 27 02:20:39 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Chen X-Patchwork-Id: 653054 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3rzfW446zPz9stc for ; Wed, 27 Jul 2016 12:45:52 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161403AbcG0Cps (ORCPT ); Tue, 26 Jul 2016 22:45:48 -0400 Received: from mail-co1nam03on0051.outbound.protection.outlook.com ([104.47.40.51]:37568 "EHLO NAM03-CO1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1161399AbcG0Cpq (ORCPT ); Tue, 26 Jul 2016 22:45:46 -0400 Received: from DM2PR03CA0009.namprd03.prod.outlook.com (10.141.96.19) by CY4PR03MB2488.namprd03.prod.outlook.com (10.168.165.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.544.10; Wed, 27 Jul 2016 02:29:56 +0000 Received: from BY2FFO11FD015.protection.gbl (2a01:111:f400:7c0c::117) by DM2PR03CA0009.outlook.office365.com (2a01:111:e400:2428::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.549.15 via Frontend Transport; Wed, 27 Jul 2016 02:29:56 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; nxp.com; dkim=none (message not signed) header.d=none; nxp.com; dmarc=fail action=none header.from=nxp.com; nxp.com; dkim=none (message not signed) header.d=none; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BY2FFO11FD015.mail.protection.outlook.com (10.1.14.131) with Microsoft SMTP Server (TLS) id 15.1.539.16 via Frontend Transport; Wed, 27 Jul 2016 02:29:57 +0000 Received: from shlinux2.ap.freescale.net (shlinux2.ap.freescale.net [10.192.224.44]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id u6R2T9Kj016285; Tue, 26 Jul 2016 19:29:51 -0700 From: Peter Chen To: CC: , , , , , , , , , , , , , , , , , Peter Chen Subject: [PATCH 06/15] ethernet: hisilicon: hns: hns_dsaf_mac: add missing of_node_put after calling of_parse_phandle Date: Wed, 27 Jul 2016 10:20:39 +0800 Message-ID: <1469586048-15697-7-git-send-email-peter.chen@nxp.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1469586048-15697-1-git-send-email-peter.chen@nxp.com> References: <1469586048-15697-1-git-send-email-peter.chen@nxp.com> X-EOPAttributedMessage: 0 X-Matching-Connectors: 131140601972688603; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(7916002)(2980300002)(1110001)(1109001)(339900001)(199003)(189002)(11100500001)(87936001)(5003940100001)(50466002)(189998001)(76176999)(19580395003)(19580405001)(97736004)(33646002)(50986999)(48376002)(110136002)(86362001)(36756003)(229853001)(92566002)(85426001)(2351001)(68736007)(106466001)(586003)(8676002)(4326007)(81166006)(2906002)(2950100001)(104016004)(8666005)(77096005)(356003)(105606002)(47776003)(8936002)(6806005)(50226002)(7846002)(81156014)(305945005)(7059030); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR03MB2488; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BY2FFO11FD015; 1:818ENkvV0OVycy7oO4Sp2taXX0ASR4bb9Bd+Q3wY3nsxqhFA4zQdwlm9lF5rxfeQmhXd6sCVBqvE19b00ClA7E43aMI1a6vWApw33gw1zAOpQSxjT8BgY4ugpSa2FvhsCxP+GltApOGZ9MZ2aAGw0SgxU8s+c6SCsJUQqYB8qcW+iqtRKllQW/K9BI6GMEG4iUmcUgzKKuFeROEOUtfFQEN15BSvcFTJ/VCLV6QiRoeGd7bH37yrvLDsVB0JXNXEEXyTs6/qi6iQ0Ur11+bx9OQGG/AsVeBck+FWyZ+lxclGpweHvswlKOa6rKqywPcPZCE51SKoz9tHlr50yTO8G/wn3F/QMqIRBimCoBniFS0jK/HveGU7Pm2ylwWrg2yOaAVDR649zWaORdGTZaozcAHmPYfn2v9o4eg90zuWBjO8T0GofOogGeR18+ZDjkXPZWGEhPrmTaVTYGpOn/ix0bLHSDhexGXc1+Ha9+GJOGDNxG54L8Ad3/acW9qqdYf3jmQwwO98sRLKpjNw401s6CaqNIFVg8r7T9viR6FIzQLKKnuHqf94aRRK9XJHSjDjHZQQOSS7b6I5XLL541KHcQoQ/3edrvScbRm4cGQQMbM9lWdnV4Dvpzz87pRyUv6kNMVpie0plTf8hzoZzvXDxGAtBu6W65Dp3rj+WjgV8/jmc2PB8nYgAvb0vOdN27+u4ceJ46KPIQVTLzY12/OIUgyw0qT+NMzZGGuX/niDMoY= MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: d11e5a7c-1413-4689-2579-08d3b5c5e6ab X-Microsoft-Exchange-Diagnostics: 1; CY4PR03MB2488; 2:ax9XPq61fFsn9TM65qn7OgCiLpuvk0yBITqpBlbpzRiRbtUwvvJ0hIeIvukWIF6MGDoXSgZBIbhxzfGc6t3hBCCxrTNgZbRlor3UyMG7veacZV1NG8K5FcWAlyPI/MqyLczmzloLvjZJ446nvJXo1jgf0AqgD3yWGNwsusoiqHDtdais7MCe66WTeHzvbEH7; 3:scby/nquQTOhyUhMHkg/Gtd2NBkw63tUQKRmQRP1EHkR+PJd3JpoV6HvcjGn4blP5HWX6ftdtVrlOEvcLsgzjfbjUqOr8v8dxr8krD8sqvro6tNakQxgE8mvApGM5V2auS2Y2DRTCKuEBHQENPmibanHxkrAuWumHTCYVboaE41N4IldXSdeH4aRt0dHPTQC6ro/qXxhFrWo4lKJ/Wvz7uzTgGOUY6YkJA8r0z7SvZk= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY4PR03MB2488; X-Microsoft-Exchange-Diagnostics: 1; CY4PR03MB2488; 25:zGJaHNtrHZkdPX5XVzIF496xBTRJmKJGgxF0Vu3kQcVBuN7LCzJ19D0nOJuQ348Uyu4rayBC9oAR1MjlwGVoB1H1H8Y+vRPxHHyuts7Gnl2McdNCVUz9M1/eG5l6yOOtgzk6j4sFaOEpr7IDoqLNlQjFSfHvcfgFyJ22eVbrij3TWcRFjHmVbDOKUltovIZLTDYX3DjtnHzRFhb4dGcjQZCwiuhlIz7NOPWi8TYlcwop7y+ew1wTPwNRzVJ8AeGiZRPUiQthYVXizJG4CVr2nA+fNHqL2RXXx0+fU8G3Bw2q69nQYsuvgN8rq1M8/xkeZiO8l0GN0/NQKG4ZHORbNNTpYUakrnH7KaBLsiOXGU0gnAdIxc01nTiYubv13bEqJJJdRjgdyjbpAliTddUSS1SIEhQJs2r2ablTk6I3BYaG1S5MJUprBqhTsH924WP0Wc0PXRUqcNWpNCkttI2/l95H1b06F7KlFSYMesLAUn4htvBTEUifLK0tRkFWboWMmTSePPcJCck8Wq8jMUj3sUwIWNYIDQhjrf/2cD479+Cg5zYR4pq9f1AKGG4IisyckcM4tZ44rkM6g7HUnFEWBHp3lSOVJ5K+B8CJQvlTFQlk5TUxC4DfjF1TsK0lyNY1s/OLrnMH6ydYdnvtn2vEYVCmm/FD+PuEuvzEBEEhl9v6mGsBBY6TjYo9foilhgdLGvFZsqKtkQmK46ofFAeAQA==; 31:ZEDfW8agjsVJe22QquQ6FMzsFwP5yoIYuaw/iAR66wgLho+qsFU0MhPLr3g9P/gKff4DWNNtcrMBucH4yxOYU4fDzQ6zgX38RmJFnirqvE5G1dNg8MFyaMTiU0dbJohyO8owlyH71IaW9BJ+LFWaGYNoT8nNbNdarXeFTv7ui3cDXPU9MjerTl7yM8wRLeV421kpZZMgqWwnnIRTsuT4Pg== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(2401047)(8121501046)(13024025)(13017025)(13023025)(13015025)(13018025)(5005006)(3002001)(10201501046)(6055026); SRVR:CY4PR03MB2488; BCL:0; PCL:0; RULEID:(400006); SRVR:CY4PR03MB2488; X-Microsoft-Exchange-Diagnostics: 1; CY4PR03MB2488; 4:rnjm1LbCTIxjW+J/DEVtYQa3dVj3uGe3LgNGxyM5aGgn6Hxf+RMKsynFZQVzT5331yOzkKKDNceB33dkXFW0trSdLE9cXJr/d9ZGKYk48x5Oxvz703zBpSXhIbNzw6xoYErBoy0fYPuSHSZaLUs5duoyVgdHRfveQizauKqa8ZFkfQtxPtHdI3bDBK03Jr2KYVHVRpo/u6I84PBORm6bNXFM8E1R+SJvL9ntdrmBK62yECn0ZjtGVwG4w4a6cQ4OAr5J8SVAvfLVji1UPmbf0iQRROcWEBQVgh1ktIKjQSW22g/XMUILJCy7H3KjCGGAjIgBk/Jr3On3tBtEefz9puSTpOBFW5tCkITshpV3uodq6Tc5eUkv2IqbPgilb/qpOKLtHtlQ+fY2nJmUY/XZH7+4wlB5COQsUijnkm73BRpCcZCIL45OD4QuXdU+qn0GWenTn6WC07HFD10AFisFajaUdg2ZgsfLbTGr0jlEKel2+iif3VecLHZ+NlIxqgyTg02OJZ9dpuYgC9RL4VjT5g== X-Forefront-PRVS: 0016DEFF96 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY4PR03MB2488; 23:Eu7UoeOFBShFJdSjMUK5WF0HLx3E9T2c0cjCrJsv+?= =?us-ascii?Q?BXIFBfew2YZne0Yk6zH4sPFwY9L7KDTgtHvLdnmnZiqEiiGRNneqkfDwFTt+?= =?us-ascii?Q?Sh17SNp/Ur5SHx7jgkaGm1iq7/q4iZYiozJuSAUB24CKvldWtT6r7uyDOI08?= =?us-ascii?Q?uLfSyeFpJnrmU1UjmtaAmE5C4DTSECMVePsDWOKOfQEfZLGW0YAQY95kx6Va?= =?us-ascii?Q?PHyxvEvzum1LX98upQaqLFqCIfSPauuBc3IGQi5keNJjVE9PrRESp2bITGda?= =?us-ascii?Q?dww1LaPL3QsaJ6iYk4sRfp6slmyQkUDIxHOwBROJeQ8Uu0fH0QTkbOQ6dSRh?= =?us-ascii?Q?VsGeqFqkgXXk85zbqd8a+dZSdvdFkeJiB+gMWP2mGxT8/3OVpeqAkH6382eX?= =?us-ascii?Q?+Ba772p3beO0K/fTMgx9ycKzDMGBSU2gzg293Y3xBRdqwDa0Hj8xHSmctBmt?= =?us-ascii?Q?l3vqVfS0k9vYLEJi6hBr5mLeI02aNxjegojR5BRNP5u3gYi9AroMxgp/PjR8?= =?us-ascii?Q?a41MKSIvNh1/N6USglzUsj5jQOn30vdMwG4ho40bQhoBS0fs4zVmBpxgx8W7?= =?us-ascii?Q?NxvXvKMFysB+BK5aD+Kdc4ExWhfkKPXZMgI1/dO5CI8RRlcr2nJvdhVVgAN/?= =?us-ascii?Q?4n+CGpkhxJYVpOeK79RRniZPQaoqvhrPQcdTcMptKJBXsfZFuCMkaBMvD3v0?= =?us-ascii?Q?xdW3SXcQ27m7hQBbgANg8nJs5OfxiVPWE0PEFl3TYW/AvRmBkWvrgDJST1b2?= =?us-ascii?Q?Z5LcgQLxmDSOQGjvISl+YUgDAZN/qqQ/81AjNSn3Ol29FlImGKJD6EyCkJLo?= =?us-ascii?Q?1s2MWEqSh0enLUWO6pUoDAHsRYM3mYdN8dttp7fOOkN3xaqYjlT3tlvszmKW?= =?us-ascii?Q?/vyN85HDGGDvK2pVVAAVTmCoyYxsVVi9lWiyzATd2lS0efUlm5dxSGhnv34+?= =?us-ascii?Q?hiZb4xiZ+/UsbE5Cx4UBurhChhzYCKJRGA00XNLzP0VZLyN06dbUSX2/w1Bm?= =?us-ascii?Q?58qMUu1yoZibpVsJ+u61hNuLWtHY4j9FA2QFWJGBf4SJ9Lw8Ktfts2mVct+8?= =?us-ascii?Q?O/OFMSUqjNuUJd2oL2FD8a0gVBvLtxSnfzcKgqmVaCeI5wf5MOj/JXp1EuVj?= =?us-ascii?Q?YhKnMzBtI0yy9mL7OSgT9srWLwOuHvM?= X-Microsoft-Exchange-Diagnostics: 1; CY4PR03MB2488; 6:j11Ykh7RePtRvyLRP8yRJfkR4OUrwc3aZR+EKCvdDrN7E+R27Esym1hFpXOKi7GA8M4D6q08G89QF2MpKrRHlL+SY5sEvWq3wQg0iDLLKKX2jLR2Xo4ZHnIsAXL2kXr55xb/Vj/fSyfpq2+1LRAEVpirEVG6vwMvS2s99GWuV7c27IsyvVhBgC6kQucF7BZFCUtVTIpl2LJm9AyJaBlb7nyjZmEpIOU6yDkMHMn/DuHRdu1sKDFII6N1CXbJpGu1MUsyx5E1kRUGs1DiHXQcY6+NgazluDv5AQ12eYLwzIA=; 5:Bte9Z5czy9+p695sw2upZakP6im5gzWWGKEfL4yz/hamXOeM5hgBqFUKlLY7Lrm390D2UwzZiGSlxXCOAv448xMyNGRanxjk0gXMCOCQwSfl8qhUaQ3ZBbM7N2TuMUP88yFoF+vNljbVCFfZTzsATuQ3CsrIx0deK8ZPxwigSAs=; 24:M410HH+QEM8V2h4bUaX0wqq6t+JHo3EbtZbY8/dYZlTcvev5Y2GPfXiqddKHrGNI4pBPO7U5ZtOw+1NImMvd7oLYJCBnXU+APqKdmIioau4=; 7:WXEnVTwDqH4J5fnWlrVFWJsTKZnUOYgNTu19q9pu+hHTYobKal0or0Ljem/C0k5Xaku5OC3/p1FWoiz9EYYwFjcUIDEWyCTS2CShdMcMHaZxSh+FL/yYZzGY1Pgj0E0vmL3vlTvAzfN6pEEsSFfc8VRdBx4dcT3FhsB7y6UOPUvGD1Q8N37o9hpJ10vfV2td0rU7IwOHmD3XlglJLpBBt+9YXBMf8hwQnABF1SKaMlgEKjne+D5SARmA2yZEYh90 SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2016 02:29:57.0036 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR03MB2488 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org of_node_put needs to be called when the device node which is got from of_parse_phandle has finished using. Signed-off-by: Peter Chen --- drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c index 3fb87e2..18d72ea 100644 --- a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c +++ b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c @@ -786,6 +786,7 @@ static int hns_mac_get_info(struct hns_mac_cb *mac_cb) np = of_parse_phandle(mac_cb->dev->of_node, "phy-handle", mac_cb->mac_id); mac_cb->phy_dev = of_phy_find_device(np); + of_node_put(np); if (mac_cb->phy_dev) { /* refcount is held by of_phy_find_device() * if the phy_dev is found @@ -804,6 +805,7 @@ static int hns_mac_get_info(struct hns_mac_cb *mac_cb) np = of_parse_phandle(to_of_node(mac_cb->fw_port), "phy-handle", 0); mac_cb->phy_dev = of_phy_find_device(np); + of_node_put(np); if (mac_cb->phy_dev) { /* refcount is held by of_phy_find_device() * if the phy_dev is found @@ -813,9 +815,10 @@ static int hns_mac_get_info(struct hns_mac_cb *mac_cb) mac_cb->mac_id, np->name); } - syscon = syscon_node_to_regmap( - of_parse_phandle(to_of_node(mac_cb->fw_port), - "serdes-syscon", 0)); + np = of_parse_phandle(to_of_node(mac_cb->fw_port), + "serdes-syscon", 0); + syscon = syscon_node_to_regmap(np); + of_node_put(np); if (IS_ERR_OR_NULL(syscon)) { dev_err(mac_cb->dev, "serdes-syscon is needed!\n"); return -EINVAL;