From patchwork Wed Jul 27 02:20:36 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Chen X-Patchwork-Id: 653048 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3rzfTM6njDz9t1v for ; Wed, 27 Jul 2016 12:44:23 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161303AbcG0CoS (ORCPT ); Tue, 26 Jul 2016 22:44:18 -0400 Received: from mail-co1nam03on0089.outbound.protection.outlook.com ([104.47.40.89]:9952 "EHLO NAM03-CO1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1757924AbcG0CoN (ORCPT ); Tue, 26 Jul 2016 22:44:13 -0400 X-Greylist: delayed 870 seconds by postgrey-1.27 at vger.kernel.org; Tue, 26 Jul 2016 22:44:13 EDT Received: from BN3PR0301CA0052.namprd03.prod.outlook.com (10.160.152.148) by MWHPR03MB2496.namprd03.prod.outlook.com (10.169.201.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.549.15; Wed, 27 Jul 2016 02:29:40 +0000 Received: from BL2FFO11FD054.protection.gbl (2a01:111:f400:7c09::118) by BN3PR0301CA0052.outlook.office365.com (2a01:111:e400:401e::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.549.15 via Frontend Transport; Wed, 27 Jul 2016 02:29:39 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; nxp.com; dkim=none (message not signed) header.d=none; nxp.com; dmarc=fail action=none header.from=nxp.com; nxp.com; dkim=none (message not signed) header.d=none; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BL2FFO11FD054.mail.protection.outlook.com (10.173.161.182) with Microsoft SMTP Server (TLS) id 15.1.539.16 via Frontend Transport; Wed, 27 Jul 2016 02:29:40 +0000 Received: from shlinux2.ap.freescale.net (shlinux2.ap.freescale.net [10.192.224.44]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id u6R2T9Kg016285; Tue, 26 Jul 2016 19:29:35 -0700 From: Peter Chen To: CC: , , , , , , , , , , , , , , , , , Peter Chen Subject: [PATCH 03/15] ethernet: arc: emac_main: add missing of_node_put after calling of_parse_phandle Date: Wed, 27 Jul 2016 10:20:36 +0800 Message-ID: <1469586048-15697-4-git-send-email-peter.chen@nxp.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1469586048-15697-1-git-send-email-peter.chen@nxp.com> References: <1469586048-15697-1-git-send-email-peter.chen@nxp.com> X-EOPAttributedMessage: 0 X-Matching-Connectors: 131140601809450220; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(7916002)(2980300002)(1110001)(1109001)(339900001)(199003)(189002)(104016004)(5003940100001)(92566002)(8936002)(36756003)(586003)(110136002)(2950100001)(86362001)(85426001)(81156014)(77096005)(2351001)(50226002)(106466001)(81166006)(305945005)(47776003)(8676002)(356003)(229853001)(7846002)(6806005)(8666005)(189998001)(76176999)(50986999)(2906002)(19580395003)(97736004)(33646002)(68736007)(19580405001)(48376002)(105606002)(87936001)(4326007)(50466002)(7059030); DIR:OUT; SFP:1101; SCL:1; SRVR:MWHPR03MB2496; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BL2FFO11FD054; 1:Pzv+cBT+xVkE4YSjKuacVs52OqZxjoWtl2CKNSEhlk9Op3RL8xBw49QbrLzQ7rMClSir6DNNggWgfuI28OqN42PFht0doq8lxeqi2XPmK2TljzXY/ewe9DlHoHQsAoEqS+JAQL3Lru1iWCBDrWU6S/3yhrvv+wleCcsyM4ecOIkWx6ifo4r5lRxhAZ8LDvVyV09rjvWZS+0uL2shdG+/eNuBx7gSNzwiRUl5w0qwx0o5+hy3xLsNhLZxhlEuB/DNkekXmWqbBS6h4s90n076phUgVT4eHfEwQejgJnbQWdhiKl5ef63FsUP6+rszBvGMZsUOQ0zt+qGmAXo81TMQHJk27Uc2mefgyktji0ZmDqgMbnj5mwMbxa3fnQ/z7Oo1yXxG5LpKORtxwtp4JmwqheUr0upwxOeo7bmZqNhP6nPFPcjDdMpNsBox8bUYkGnIAb6FLGLDL1MhIz8CiLBcW0Rnu4VgXhPtEANsWkTej/5RqrmUnde5CCbMvHfSYaZ1xwI3Lhi9KOqjD2mBFnV8JE7TCiFMS4Mqk2UI/xQ+TAImw+5KDP5K1cu05l9beV6F5RA5S/UFKbJ/F7WMwiexRTMfZoFdGQdttTZCMyx+nawTZSwvCZE80I3cNFXOSmyfiJy2SdbhD1Y/1VdOPijR5AaOt+9HCWfL0jzguIkfpQCrBUDNAAtkODjG7rjwoONaXQqy+quQFPezdzPeOdlRvar5Hpk6Na6J4emeOBfF2Rs= MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 425ca04c-9f42-4b3f-538d-08d3b5c5dcf0 X-Microsoft-Exchange-Diagnostics: 1; MWHPR03MB2496; 2:U/Vhybpbwf5mCsXefFOvD0JenbIj+jfpcQcEZN2Gk/MmpWNCcPfzkvLm+2EP3CXfi/b98o1eVv2zd4ngLt8DgQ3itNt2xpifItCzMR+3u7f5pTViTsEst5tfvPbTb2iddAGj5Jb3Qe+hbYeaLB7a1jpIGuku5EJBiqpBtBXoHFt6Yeq8YcqkZuKZO1EMxOyM; 3:tn+I3AevFvU3yJibKC+2bVkXw40KrCRxiP+kPvrjYRZKdlNFRxxWWU8UNm3tsaXJgGrwJ/hs9rKPhm3bAsFyXJHRfMmmMUukfhk83ccj4g4l0R2ApAoiLHHbiLEjSmOY5u6fi4eMWFNbdiiK/XT+gQ+f6QgIiBAsavA4CwYFIeyjHo1j0BEZOTlLb0r5QyOa9eM3x0nxwQoyVYSL6yJiTqkgAGOX0DJ+TbBbd6oP14A=; 25:J2XHSlWUC072+sR87o+4I3zAfYcmo17F/6Bv9YzunN3m3Svd3J1vNZXwgRqIOlleeTk1rWiaWVrgZOO3RTGhRX748iqbfA+00bbIdwD7/JZdyqhzvUOGdPkOGcIVOb7735JQc89VPRjuoxI/w7PQ9+oAMP8f8dMmfkhTlGGpMDUTHBuFhQSmVG4q11zzer9AGTH56VsX9GpKtsXKBTrZcghFl7JG6tSZFE9vbh7iEw+EqGs4JkVJlLfmYQpss6GZuaqzSEsLuCjPYFxGPeleTv8i5izxXdwcAPeukRL/wd0nM1kwIoUdf72/ONCM3Veqe4PyIlbW5aTDyjKEd9U5ElfZQ8Ttv/QBxiwhoxakJYNT/WCGnsDMdER7Y72BgsUZ55PdO90IUB6CNHr/CVKLF98IzoW+VtfDB8mYS91fFNM= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:MWHPR03MB2496; X-Microsoft-Exchange-Diagnostics: 1; MWHPR03MB2496; 31:VTdB9PT0WdEYk02udJcJW6/3HTXmcSJ0maBIHd3pEMcwfnMaKh0YI+C3yR8wfsTLtuIexzVrkxdmbX3Yhh7CojzBUWUS59cE8r5EUiEqeN9knVlQkwr2m4P1Mii4ixQsOhg37SDPb0HGJxBQXPZDQCVS4h0ASCDryyvhsGLjIdSdNKt2nlWbjDLTxg8RAoRhjk2+x6KGYSM6K5CoVykWbA==; 4:K6IvkVS+hEkPq9yWbi1anZGAZMyr8iwuqXnTNjkCwBBCy+NNEAEoLvOVivCNXz2IzjDF2aC5e6vfgawStqjFzPN46FXNcPxuwmQdgnTNY0Zfd4ux6lX2/0alCiauVCzRUeY+K50tfD3hdNjlqIai4Z3+G/ciFdjTZH8OIIcJxNGe/WsW/v6vwPTS8m6CL8oZOqKX9qrjmqscQxv9N+yHYJVW0GR7Q0DsZ4I4kKBPRswQtG1GdShFBCTNpwFmJ84czwgCJe8ThVv4yJkK0RtDkKNVJxSiEjy3Zpsm8jF0aBl271r3T3qGQQjA7e182UX6tBpUIuY7KVVvKCsw94P6AaaqP6XtbmCyrmPvNxFwmo2q8usck7XCyskfXG7M2QR2uKVybmSq/YQpDYHTgeyP/AAJAc8cKhrgUuI6DjkJxXgnsu8mAqaaA/LfwwZzgrtIkxKD/SuaW6kqLAVXfJlv9kjNrrWjwLHsNqJdoI5o6+Un5zMVUDkjxxo7GV8QFoI6CzKpwAavHSeu85M7HOy3Sg== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(2401047)(13023025)(13024025)(13015025)(13018025)(13017025)(5005006)(8121501046)(3002001)(10201501046)(6055026); SRVR:MWHPR03MB2496; BCL:0; PCL:0; RULEID:(400006); SRVR:MWHPR03MB2496; X-Forefront-PRVS: 0016DEFF96 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; MWHPR03MB2496; 23:AQ8MrKWpO4LZ6Q53owD9ZEg4v7Bgmbu1GOqFk0tir?= =?us-ascii?Q?h6g6l7BedMZjZLjnO/23USuZpyMUv3NntJegdYRoCdY+qkyc5zfrQ3t8TtxR?= =?us-ascii?Q?4VpmLI3Qu7NEJQHix4853Fj57M/evbhD7LF/LbBYFyUHoLIxhum7eVzY2Gr8?= =?us-ascii?Q?kpCnYCdRj6ppRsgfrg8Mksnbpla7fgTzrz5uAjfpWeFHyaV6loqyBsWU3aYW?= =?us-ascii?Q?TrCM39w2C58TxuA/+4RplmMABVgK1uQFJOu8/5CS49mFR+Osy3bA09p4R69C?= =?us-ascii?Q?abAa79jQSE/jmplDwLTtw3Nzi3y3gOT1ZvTecrjh6RLkz/RtRxjJPn4hcac2?= =?us-ascii?Q?T6/Fdsnqjom50Rpwb3/q2AW4RpUaqqnmMqZYcTQ2MXWI9ZtBabVQ1BFAihpH?= =?us-ascii?Q?vakFQimPZtI4ZEGYT335vKVDj5Iy9pz5vBCsIbsDNtUp4NZxhrRbaVZDgcKD?= =?us-ascii?Q?8Z+UOJiX9tOf/RQfOk1FZRGmzsLYn9+ZO28fTCshAqum+uMPFcoscpulzqXV?= =?us-ascii?Q?KOYKudR9lLBKiwVjPql5cepi6pDyc6XUWADdMgKS1kvK1OOjqwvVsH4T7cnc?= =?us-ascii?Q?UMcfHXIjsynO/ftMeQxPHnESXfMq5UXnhNgx+8M5J+zE5HVl1LeXJuDpv2n7?= =?us-ascii?Q?e83DRVz8wd2rFu2KND+Y1dPyzoMomEmcOEa4DDRUvBlPwj1m06arBJtkiGAE?= =?us-ascii?Q?CD12NscR3e6lSPAFUS0o3PGiuHcniv/5rcKMTDnOlIRWzgBFSFSm3N+pkBcF?= =?us-ascii?Q?ML2GMnCqXJV9azzffoaM5bIpA01goKZ5bWznQsLeMPBT8gUO1fSonCk3pedp?= =?us-ascii?Q?bv5ZPZBRu/mpYbii8+/s27PweywerVlukC8s788UWjNbrk0rQ6Oz+H7fBbLY?= =?us-ascii?Q?fl99oZay0+Z6R9bX7dTGW3Lj1YOEOKka0QaBTQkNBBtx19CouSZlCHsVxXyD?= =?us-ascii?Q?kkPqzcx0weVmqlyTgiDS7xzwwdpTHw3zJoySxvrjtE8Unw0vcrIa64+o2Oeq?= =?us-ascii?Q?78XpwFzPBUhs1ltde9oJE0tgjQkACsGNt5iyJ7G6Y5XUf1KjJ0fQ8bh6h9eR?= =?us-ascii?Q?FCqWTBPUR/1H1fjlGaOx+8JC99da9ogOkgBj/mAOoaVHqmIeC6ZXt4uwYYZA?= =?us-ascii?Q?G/TtVihl2k=3D?= X-Microsoft-Exchange-Diagnostics: 1; MWHPR03MB2496; 6:yIBTQZsbLfNLFPllJZp9NbOXYAvqTci4t1rXi+VfCkg7l6AP1kkILowZeQkKABCZY75v5N4uY58nAAK68Frp2SV9cyd5EyqsioSoG4T5mAW6UMk5aYsgbEBl4//4+7Om8LP0OfqMKB5RDxHcyT5V0UhrPjrsw8SzX1W5zpXMmM9dPesIvwfn1kcm1HM4F07eyiQXMCTJogE/JLX/4llYq8IpGyWeqnElUJkQ35/WZ1rKqpxd7WEZ8hEJB3Ms3wsJWWSwK6oJqQ/4msJgMesGPujJAajOaTV6D0N2Wxh9TaI=; 5:jRrnVFAmZSyIVywoe0GzPSfj0hdgpD4z6MwZIIi7d5GjSZOZAswVnC73CBOED7C7GFBS/DnnaEpiPsIpomMThyl6patdeG+09V4DYa3a8bpI+lKM7je3A8wlukV84RJR5sRjWttHdaYLSdkQXmYLGpwHckMjRGJWOfHL5w6GX+8=; 24:VgSfjx7Pzz5EgMMn50i3/0NBWx+U8/AMlurSKH5s73TCcqQy8KYcAuKlnnLl2oY+EMtYeVWX3cisaukuEyugsKfvshtQYE2uoFnVAL0gzVU=; 7:lR6TTigcu/9l/aQZFnwiPhvUDrSrpuB4llOLHvzgpkvDDApO0KXV8qxTepswVE5PUzR+fiA0ketOor5hFHYAJ7D9Ec0nW83T/bDzsZ1tYS01b0ljQfzGxodihTtbLIldhpQBamDln67i7p2k6qskwRh7M8EaIJdsTRO368l/ksOasF/8vvBTXva51kPwZ0fBIs97AjZqFChgMy8NdMJU9i8LnjcWXQkW31XnANPvCDMmti7FnTHn/ozVdnFjOQ46 SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2016 02:29:40.7110 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR03MB2496 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org of_node_put needs to be called when the device node which is got from of_parse_phandle has finished using. Signed-off-by: Peter Chen --- drivers/net/ethernet/arc/emac_main.c | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/arc/emac_main.c b/drivers/net/ethernet/arc/emac_main.c index 586beda..0e6331c 100644 --- a/drivers/net/ethernet/arc/emac_main.c +++ b/drivers/net/ethernet/arc/emac_main.c @@ -749,14 +749,16 @@ int arc_emac_probe(struct net_device *ndev, int interface) err = of_address_to_resource(dev->of_node, 0, &res_regs); if (err) { dev_err(dev, "failed to retrieve registers base from device tree\n"); - return -ENODEV; + err = -ENODEV; + goto out_put_node; } /* Get IRQ from device tree */ irq = irq_of_parse_and_map(dev->of_node, 0); if (!irq) { dev_err(dev, "failed to retrieve value from device tree\n"); - return -ENODEV; + err = -ENODEV; + goto out_put_node; } ndev->netdev_ops = &arc_emac_netdev_ops; @@ -778,7 +780,7 @@ int arc_emac_probe(struct net_device *ndev, int interface) err = clk_prepare_enable(priv->clk); if (err) { dev_err(dev, "failed to enable clock\n"); - return err; + goto out_put_node; } clock_frequency = clk_get_rate(priv->clk); @@ -787,7 +789,8 @@ int arc_emac_probe(struct net_device *ndev, int interface) if (of_property_read_u32(dev->of_node, "clock-frequency", &clock_frequency)) { dev_err(dev, "failed to retrieve from device tree\n"); - return -EINVAL; + err = -EINVAL; + goto out_put_node; } } @@ -877,6 +880,9 @@ out_mdio: out_clken: if (priv->clk) clk_disable_unprepare(priv->clk); +out_put_node: + of_node_put(phy_node); + return err; } EXPORT_SYMBOL_GPL(arc_emac_probe);