From patchwork Wed Jul 27 02:20:47 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Chen X-Patchwork-Id: 653056 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3rzfWF4ThBz9stc for ; Wed, 27 Jul 2016 12:46:01 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758567AbcG0Cp4 (ORCPT ); Tue, 26 Jul 2016 22:45:56 -0400 Received: from mail-bl2nam02on0062.outbound.protection.outlook.com ([104.47.38.62]:36800 "EHLO NAM02-BL2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1161400AbcG0Cpq (ORCPT ); Tue, 26 Jul 2016 22:45:46 -0400 Received: from BLUPR0301CA0001.namprd03.prod.outlook.com (10.162.113.139) by CO2PR03MB2296.namprd03.prod.outlook.com (10.166.92.153) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.549.15; Wed, 27 Jul 2016 02:30:39 +0000 Received: from BN1AFFO11FD047.protection.gbl (2a01:111:f400:7c10::167) by BLUPR0301CA0001.outlook.office365.com (2a01:111:e400:5259::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.549.15 via Frontend Transport; Wed, 27 Jul 2016 02:30:39 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; nxp.com; dkim=none (message not signed) header.d=none; nxp.com; dmarc=fail action=none header.from=nxp.com; nxp.com; dkim=none (message not signed) header.d=none; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BN1AFFO11FD047.mail.protection.outlook.com (10.58.53.62) with Microsoft SMTP Server (TLS) id 15.1.539.16 via Frontend Transport; Wed, 27 Jul 2016 02:30:40 +0000 Received: from shlinux2.ap.freescale.net (shlinux2.ap.freescale.net [10.192.224.44]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id u6R2T9Kr016285; Tue, 26 Jul 2016 19:30:35 -0700 From: Peter Chen To: CC: , , , , , , , , , , , , , , , , , Peter Chen Subject: [PATCH 14/15] ethernet: stmicro: stmmac: stmmac_platform: add missing of_node_put after calling of_parse_phandle Date: Wed, 27 Jul 2016 10:20:47 +0800 Message-ID: <1469586048-15697-15-git-send-email-peter.chen@nxp.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1469586048-15697-1-git-send-email-peter.chen@nxp.com> References: <1469586048-15697-1-git-send-email-peter.chen@nxp.com> X-EOPAttributedMessage: 0 X-Matching-Connectors: 131140602410111600; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(7916002)(2980300002)(1109001)(1110001)(339900001)(199003)(189002)(48376002)(97736004)(106466001)(36756003)(68736007)(33646002)(229853001)(11100500001)(47776003)(50986999)(4326007)(189998001)(2351001)(76176999)(105606002)(110136002)(87936001)(7846002)(81166006)(5003940100001)(2906002)(77096005)(81156014)(92566002)(50466002)(305945005)(8676002)(2950100001)(575784001)(50226002)(86362001)(104016004)(19580395003)(8666005)(8936002)(356003)(6806005)(586003)(85426001)(19580405001)(7059030); DIR:OUT; SFP:1101; SCL:1; SRVR:CO2PR03MB2296; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1AFFO11FD047; 1:Nqmyr2fNcFGmvLVJuQG1dDoRunyTx+It0JcDiudNbf/cf4QATpTwxyzbCVEhsXEHKrt9QkrDyNUJcQMA/8h7RUjD1wUjHv9ey6WPfcxfhiipSBWrXpxHKl+ygGtQZ+RP9kWXuFYa+LLbpic/2eDnBV6CK4mzWHD41Od8x650hUWm8gCByHBfvUTGfsvKd1KucS3k4aOsYotpnvbbq5wLN4X2WYtmFyQTgrlPtbhGb3HMT7bv5nQ7SOEDSieQx/2SL/GZbQ7MkSg+1LZP0uvGT9ECD+agXcEl84TOnB2BnMOImOB9ElDpvS937c/Qt1CJib2BhpY5/TMMPPrOjrARN+csV9eJOGi7EIRNXBQALIfbnFfaIGDsZ+ie2nm9L+fwokgE+HkjngAL7/4fRBHQKx4NiyvJhsZni+4EuY3jl/Jrn0z+jwy+lxPE8djooORSUe/AWH+/mqNuP+8fTEMCOP6LwUaOMUWFPbho+yFh2bCNxZRk2PiIH/91V0z5WAKQEyTEr/gyqFEtxCU8j6+e8+FPHOMj3/wNtqN/MvrD//jRclNZlCnR1wa+0+TKss/VDbRLdHN1THHbBqPH4NkwxW1yMvGiyWBpvlSEDcyG1QajlfwzaUqeanicCgAamHFC+T+my0v6viU32dnc1fB+s9GoqgYCs7U1TSjdeJGQNScxbVkUWbUabENSjrkC+++FijUoyxYSu/5SZXJriqHDtShRXcymjXBvp/YN+adZ1A4= MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 8dc521e6-8e27-4b5b-1270-08d3b5c600c0 X-Microsoft-Exchange-Diagnostics: 1; CO2PR03MB2296; 2:0qdnQKgyj+Kj+x1RUGWwi982GrpwYDLaCwUd8N00P3fyuz3tQiWQ02HLcVrqKJfWB95Da6lE0gv17saUmxM5hzMcV9UorDmcBg10TlcHTfqPFOHXwna84nQN0eN4SOpgvCn1lpw7AzX4tV4BCtK1SSUebnwrbWIMu4VjRQc00FmP7qcRfZSUZTcbaU6+GRbe; 3:J/alkkA76o9lKojY7pdcCdHeR5WPjHG/JYRqDaM8HOvk49PxBh+DkZj/e4kqVopjzxPCVXUqKsbHLrHsM820H7YRmFoD5tPwmg04qq+TccOZy78IrSkK1BobIQ6VnV096qyLHW2WnjvMKAkZUkmZz+J2L+ncvpKyEXm6N+gJ0l/AeZkVPFVcfeAf9p8J8jVj+LXpILERuWR7jGxhzX8bvcDEs0NxDBSbvjMcZZSahA4=; 25:HcmWdayA/GjUJBY94Wrbdv6/UbFVl20jqpU8iqPSdm5khO5Sid5BwO2FRmxiaj5RRCw9RVdgVUH7o3V1AmsP9wn/TXQt0oXRaLa3S5ylbaG/bBjMCuh2Qj9JemGff5yJn5kpNuI0toxz888cuipSsR+5ZKTd02dl9pPS/AnPFxtCPg1+Xmr1CWp+O0Tyri92Ba8+YoERsYJLSahhUD4PwDjsAWoTVbsvQ0xF7kBur2nJCIrcA9H0NxS4TfKowVCR36QVMcoDWB0sJ2Oq5i799CMB9W3T240LIrYJdyVjzbS5F1dSobJQbKRvyeXxC26682ZzfYLP3DKRVAdU2horgPYKNmpDazlI5z2Bx51ck/y+CFLXTNlPKgGgTKYTGpc0B4nKGsR9yBCBjA0de/JbVqM32cPgBei2aoLZ8/xfeAM= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CO2PR03MB2296; X-Microsoft-Exchange-Diagnostics: 1; CO2PR03MB2296; 31:apdInDdztkRzu9efy1BO6yuggsfC0xSBnDnZkr4qkTHShAeQLonMX+PDGorzr4ZlO05EQB2R1iOZ7Qw8SrU0Kxyq3sSBTmRJA9TPj8zZwiJRJBGLuFqkLLLxX0YpMOpQPK0ptxC9ltmg9xm306nUD010oR8l3qLsJeD83Pe4IkaUQ2hq1M2pRSoEL5jF5kYpEmAP84xvyL1L4uaFeV5I0w==; 4:FC7gQkO13psyt7mlxtsjcy9wzTMmngnksaOfFl4WpUrW7WdmwcySDM9gV3m8uTP0JFvKyzPoZSyChK6oA6ptRDuZfzQ/AYl7iyEcK2IcNYIvUWYAvr6Gu9mzYRJBKW0F6eycUnQNdYtnP+dGBW2bRvQhwyZRf8yWhnkTH7UdvIkuKw25M1ItJIk/SLYGSCEcqPOs1yEheAQ8umvmypCA/YQBITtEx7X09ELbVOpNl0xXyg3w1GGOFPCiYdTEE7qtrQghPnfrHVz5xV4o2h5+YtAAlKk3Zb4CtqZbrrBdYOFIJN+a2DZhZd5uRq0g0GJMfOAb4iHwiq47Keo1kp2hgsMuIhT9BzQYMdAlyrHy1JYkVQHrNh3W0ymODIYLeicN6uSo69zPWqp+zoA4lM+dLjSI6cJ5N1YuMs2HvM+qUk2DbdsSrlpQGeokRjxyG3AQPTVR6KMA6hP8dvTI93/29MeV60hAIIEhKXSXK++qrGMM3glxclO0UUFgH3pOhcua8kzr1uJlyqeMeHmhbUdzaQ== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(2401047)(8121501046)(13018025)(5005006)(13024025)(13017025)(13023025)(13015025)(3002001)(10201501046)(6055026); SRVR:CO2PR03MB2296; BCL:0; PCL:0; RULEID:(400006); SRVR:CO2PR03MB2296; X-Forefront-PRVS: 0016DEFF96 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CO2PR03MB2296; 23:trD1JLriR2wDGO0s6iF5GCOpZ+9t++YPkMFxy8XO2?= =?us-ascii?Q?5HddY25dloBll5255/1nnVJK80iDrPYlV+63TS65xN8gNiKa+QwEOtvTtEsc?= =?us-ascii?Q?Ym1pNKiCyuv+NpcZpecqJy/wlCijNuR1le/I199M49t1dKMtXksBpQahXTAZ?= =?us-ascii?Q?QaMhgmLgMTHToyYT09JP/F/Zm2TDjUjKpJInUAtQaoHlYfZlFJslwTBth54Q?= =?us-ascii?Q?EHhQBoSzXyqXg2uuohfzd5RfP1v/te06tt8FKgMblgSWfGEu941qmj6slYc2?= =?us-ascii?Q?O4tP44uoSCjT6hJcZR0k0Y4673tMT9MqPO2IdM8LYNwBV2fdkXUHNOWLmkNg?= =?us-ascii?Q?or6nB6H+ijSmNFXBJPDCOLuSoplOQCGxZtbQXzkK5+b9EobgJRmbliqRU0lq?= =?us-ascii?Q?lj+UZcGFMIdxb38fvzKziyxEra/QgUqqS3/gTlWU6tsMRCr99vxgcpey9FX1?= =?us-ascii?Q?zO+yk6bRjUY9CXrk+C26iMTrbeEyEDE64JoRW1FKIo+H2YQSjHISnIEoO+X2?= =?us-ascii?Q?CbRRFX+aX2CDM9jSF1JAv4X3wJPryOcc6CcXX34xGiLh1i0GY0PG1PV083wA?= =?us-ascii?Q?IBIwfj1FB9BLFaE+UaobgjZYmooOSBgzaWFW+EAocHJEQLG2IQeyaDI7WkoG?= =?us-ascii?Q?6WoFymk9pJk8ugyfGP+wcE7CEy7sjMkSvjcZNBeqVHrs4h6NT7r4FuU0lCU0?= =?us-ascii?Q?prppm7uvVM8EjocLRhCO+yjlWzMnxrXqwbPxfreZhtL5A+iGA97GMukYaker?= =?us-ascii?Q?kTJnIJpATx4r6ORuwW6zV0cUamO/gsF2aOfbWTsAFKbi7loUbVLOpUCOW5HQ?= =?us-ascii?Q?aN8P3sM/vJdvw83y2syy27xz/mCyWVMYsyL5svztgwyoLsS3ozyYvsc/OJwm?= =?us-ascii?Q?a+ijRGjEEEf4W2PpbRKHaz9R2f9W9y4rFMi1cUZAyOitx8QjQaN8XJ+CwbqP?= =?us-ascii?Q?lyCuzMy5N12GzyydYqeTI3no+wY8YVjvv52f8+PJSaSiamb0he7vbw15/uoc?= =?us-ascii?Q?lFlAskwl7y3In2O5XZduiRGfeJ61wDDUAGVZg2mvnMkijxjtfHnColPHCiBq?= =?us-ascii?Q?JgM8WFi4vjz0KLYtG/Y1NR0P0b+nfyfZ/Ip6EZJeIUnrzgpVbJkTU85p3XTC?= =?us-ascii?Q?/OZ9rh1LtVnumClLravlBuswTN5Q0evbdrDC0ysdm/2wSmm71mFrlATEq80o?= =?us-ascii?Q?lus748PS8E28Pk=3D?= X-Microsoft-Exchange-Diagnostics: 1; CO2PR03MB2296; 6:QYn7ehKGh9Gwv7aBuRlU66cw7AB7fUmbhnoJXWdHw5P4lUYK5/86u34CswZ4KmFSkqvVOy3zjq1wFFWAWlEF3MNX31TJrJsKPNmmoRXKMoL9TrKdGdLjpNzLBiaAhiz9J5XckLTF2js+VFRT29EkdTZkhsUunYWcdosPrOgrXlYF1l/qN1wYOu5MVVtWfIqQZBJHb0J/5DVmZsOSys/MEwP/0A7EAaNujvCWiBQjWh/2E2IwRUD+s3zZhBR+JRjCD9zmc1zO0A/C5Wsb7UJWSDKOLaw5SjivJYicZR+zdSs=; 5:yHTOFWqseDJwh9jtOraVoYrv6j5FzYBSk4+KFMxOhwmCdYrXISLLquZrCDUUVeyg0aA/nhPD/+gZfogtF+mWfo9yuk290IzORTYrN8RxWc13JwHZMUQSnXXgNOGuXCmGAb2D7EcePqAxB4anmyuKLtewcO41M97/GrqZwqmP1As=; 24:4eMtbZ4c1NBdvsCekSTRsiVHtSIx+0z9/Dxz3AwesStw0dJpMSz7WYxt6Z6GWamImAhRJkyS6sXdGlrHI7nptp077lU0bCG+XiOXH0JLlTU=; 7:FrVaaV2U/Htu9kR/RonpXkEE2t/kZB5d3Nn20Yz6Zomon+K3PnyiWpDG9Kf6YI58ll+0dkGIXJ5CTT6JHiSXYZj2URA7+mocLrwG17yB84mwsPEPb2gq1E9V4TtJTFIdNAAepeQEzEsYhCrPPzwIM50/vamBkY+coW6k3n5U/J03N/TwRb1fX31icn+Zx2T0uMDxOznrf70vwYrgklm5/FTQvG0IMLwIVWQFKFsKfMgU1nNvOqes9Ufdsw95LYgm SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2016 02:30:40.7771 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO2PR03MB2296 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org of_node_put needs to be called when the device node which is got from of_parse_phandle has finished using. Signed-off-by: Peter Chen --- drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c index f7dfc0a..8d88782 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c @@ -113,8 +113,10 @@ static struct stmmac_axi *stmmac_axi_setup(struct platform_device *pdev) return NULL; axi = kzalloc(sizeof(*axi), GFP_KERNEL); - if (!axi) + if (!axi) { + of_node_put(np); return ERR_PTR(-ENOMEM); + } axi->axi_lpi_en = of_property_read_bool(np, "snps,lpi_en"); axi->axi_xit_frm = of_property_read_bool(np, "snps,xit_frm"); @@ -127,6 +129,7 @@ static struct stmmac_axi *stmmac_axi_setup(struct platform_device *pdev) of_property_read_u32(np, "snps,wr_osr_lmt", &axi->axi_wr_osr_lmt); of_property_read_u32(np, "snps,rd_osr_lmt", &axi->axi_rd_osr_lmt); of_property_read_u32_array(np, "snps,blen", axi->axi_blen, AXI_BLEN); + of_node_put(np); return axi; }