From patchwork Wed Jul 20 14:55:52 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brenden Blanco X-Patchwork-Id: 650713 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3rvg3R1RCDz9t1N for ; Thu, 21 Jul 2016 00:56:35 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=plumgrid-com.20150623.gappssmtp.com header.i=@plumgrid-com.20150623.gappssmtp.com header.b=vaMKvKR/; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754515AbcGTO4b (ORCPT ); Wed, 20 Jul 2016 10:56:31 -0400 Received: from mail-pa0-f51.google.com ([209.85.220.51]:35874 "EHLO mail-pa0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754371AbcGTO42 (ORCPT ); Wed, 20 Jul 2016 10:56:28 -0400 Received: by mail-pa0-f51.google.com with SMTP id pp5so19072608pac.3 for ; Wed, 20 Jul 2016 07:56:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=plumgrid-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=xGvO76Zy9ngvpXJJrtOsx/IOz32kruyXvuNv/LnY/J0=; b=vaMKvKR/HoI3m1m4flOD/lchryLfce1uil7SXquKbFVqOo6AWJpeVsPVnFVri1dALs kixKgzP0fKEW0cX1rlaRHeYDGnj7rgWu4b/QR7t8XtkvWISWI/x01erDrFOkhW9eHfpz FKC2NEkPxMB8aiKh0tvecg9/jjTBtWs66uHZ8PT6PBbXjHgENcBuTLW2R2L/JIxozj88 hzAbvzZ6iK9qHay9pqZbWmH+45Mn4o3vKxy+c3Nr8CUequEFCulhjuXIP/F1NtuSYfzv Cu3LQgu+vbrNyaflbowWjTvGw/Bw3u96LS+wghI2ayemtNEOde87jHR1kPCEQ2nT8aIX 6iPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=xGvO76Zy9ngvpXJJrtOsx/IOz32kruyXvuNv/LnY/J0=; b=PGddOSQS6ngZLqL+sfJMWPWojtmx39zgiTWhQKktb/VFNZhriyGYR6WtbXWX9/cNE7 zJyZSFUlILqM5H5qyW+NbAXXWqJ40j/X5DN7cHaQsRTWGIBt3+RwtbXD9LZA+TCX8nlS +8Wq+q3N+WzJgODLYnEARzPPIHde4OraefiT4DV466sSrajTIKnDu4nFEgJUd3uIcNrQ zj6ihwBHK8WrdT6ib7vjNnrKoeSCRtCg+86tPGtycu65VRLZUSmcNUj94/b6z51cHknw +aDt2adFYwn462ssft89mpGKxFBrDKlmGfFVkRta2EmNV9eV7ZFTZIKyW+WMzLIj+DJG L9nQ== X-Gm-Message-State: ALyK8tLFgU7/DX75eyFUhD0eHUG8w+Xf80REUVmj4Ab0F9TLIyACWTKg6j7qtr4KovJv4XHe X-Received: by 10.66.82.42 with SMTP id f10mr34163428pay.17.1469026587741; Wed, 20 Jul 2016 07:56:27 -0700 (PDT) Received: from iovisor-test1.plumgrid.com ([12.97.19.201]) by smtp.gmail.com with ESMTPSA id b186sm5372380pfa.61.2016.07.20.07.56.26 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 20 Jul 2016 07:56:27 -0700 (PDT) From: Brenden Blanco To: davem@davemloft.net, netdev@vger.kernel.org Cc: Brenden Blanco , Tariq Toukan Subject: [PATCH] bpf: fix implicit declaration of bpf_prog_add Date: Wed, 20 Jul 2016 07:55:52 -0700 Message-Id: <1469026552-8975-1-git-send-email-bblanco@plumgrid.com> X-Mailer: git-send-email 2.8.2 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org For the ifndef case of CONFIG_BPF_SYSCALL, an inline version of bpf_prog_add needs to exist otherwise the build breaks on some configs. drivers/net/ethernet/mellanox/mlx4/en_netdev.c:2544:10: error: implicit declaration of function 'bpf_prog_add' prog = bpf_prog_add(prog, priv->rx_ring_num - 1); The function is introduced in 59d3656d5bf50 ("bpf: add bpf_prog_add api for bulk prog refcnt") and first used in 47f1afdba2b87 ("net/mlx4_en: add support for fast rx drop bpf program"). Fixes: 47f1afdba2b87 ("net/mlx4_en: add support for fast rx drop bpf program") Reported-by: kbuild test robot Reported-by: Tariq Toukan Signed-off-by: Brenden Blanco Acked-by: Alexei Starovoitov --- include/linux/bpf.h | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/include/linux/bpf.h b/include/linux/bpf.h index 75a5ae6..36da074 100644 --- a/include/linux/bpf.h +++ b/include/linux/bpf.h @@ -289,6 +289,10 @@ static inline struct bpf_prog *bpf_prog_get_type(u32 ufd, { return ERR_PTR(-EOPNOTSUPP); } +static inline struct bpf_prog *bpf_prog_add(struct bpf_prog *prog, int i) +{ + return ERR_PTR(-EOPNOTSUPP); +} static inline void bpf_prog_put(struct bpf_prog *prog) {