From patchwork Tue Jun 7 05:22:58 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zi Shen Lim X-Patchwork-Id: 631318 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3rP0Nm6sfFz9t3c for ; Tue, 7 Jun 2016 15:24:08 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=zCDRESIf; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752561AbcFGFXf (ORCPT ); Tue, 7 Jun 2016 01:23:35 -0400 Received: from mail-pa0-f66.google.com ([209.85.220.66]:32971 "EHLO mail-pa0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750792AbcFGFXd (ORCPT ); Tue, 7 Jun 2016 01:23:33 -0400 Received: by mail-pa0-f66.google.com with SMTP id di3so13319542pab.0; Mon, 06 Jun 2016 22:23:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=nZPasN6tI6QXLDiAJ2+l/ubtbMdPxfZAzs2ouU9GSwk=; b=zCDRESIfOJCnZo0Ceq71xEGgwBwPPcYFfGhlrsPQLE4gR0c/K+O9tl5UsXoFrDV4hT YTkk7190l7ycaicZJn9zZDNZW+fEeJUaAE11hnonX5el927BbMgiCG28u3T9BARLRq5z gXMsiSIzBWdh0Sn5jmLI1K+6Ff+7IS6e923NT5Cvwps2FEMOlruxal7NJxONoThVrKPK +HR3bACZwlHHaAH/t1UNIay2FB7u2JGQ5zujO9z9bbAo/tfHa1fzNP+3RWEcwzkLv7rs L8LAgJ1kHIShEEtu+LvKALxdeeWxM2suI3lZJoAVf7un/z5KYkf5Lo+nYlCo56TkKxBP 3U2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=nZPasN6tI6QXLDiAJ2+l/ubtbMdPxfZAzs2ouU9GSwk=; b=d0BdlLgA6DUQRY4V1FLnM95xrnZbdEXSqVOQbCj9y6fAwlkmWBnzNBowsiXhclBkH1 GqhrbyqOjPVHge4ozY1XGdOeCffLsnMbfW+2+zsB0XdnFdtzAunMWP1pDiZExuPX2I4L q/1cmqrt1qyy7C/U/wCEzPH0a54lWCfxEnezR+mRZ8CkEHjIZf3J7dr/TFqX1l3V8KzZ H1ybSnYVrxPDOgzG99w7LTQL24UBSvDf5SPvO/qOqW0dxwoj0zao3gkNiziyW1tgeR2+ n7orbKxb68vl+7Xu9MOHxczj1+H/EGYg+f+lsRMFxlpX+T4WBC3ORf7AM6PuLUC0zk12 YNGA== X-Gm-Message-State: ALyK8tI5a8RS0PFo+67XLibvDFhSlD5vqSZcKrcIQG3PmeLZCelb+wHeAeB3Jw/OzpC3/Q== X-Received: by 10.66.245.111 with SMTP id xn15mr29124906pac.76.1465277012562; Mon, 06 Jun 2016 22:23:32 -0700 (PDT) Received: from localhost.localdomain (c-73-223-118-172.hsd1.ca.comcast.net. [73.223.118.172]) by smtp.gmail.com with ESMTPSA id 4sm31609674pfz.35.2016.06.06.22.23.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 06 Jun 2016 22:23:31 -0700 (PDT) From: Zi Shen Lim To: "David S. Miller" , Catalin Marinas , Will Deacon Cc: Zi Shen Lim , Yang Shi , Alexei Starovoitov , Daniel Borkmann , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH net-next v2 3/4] arm64: bpf: optimize JMP_CALL Date: Mon, 6 Jun 2016 22:22:58 -0700 Message-Id: <1465276979-10147-4-git-send-email-zlim.lnx@gmail.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1465276979-10147-1-git-send-email-zlim.lnx@gmail.com> References: <1465276979-10147-1-git-send-email-zlim.lnx@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Remove superfluous stack frame, saving us 3 instructions for every JMP_CALL. Signed-off-by: Zi Shen Lim --- arch/arm64/net/bpf_jit_comp.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/arch/arm64/net/bpf_jit_comp.c b/arch/arm64/net/bpf_jit_comp.c index 51abc97..7ae304e 100644 --- a/arch/arm64/net/bpf_jit_comp.c +++ b/arch/arm64/net/bpf_jit_comp.c @@ -578,11 +578,8 @@ emit_cond_jmp: const u64 func = (u64)__bpf_call_base + imm; emit_a64_mov_i64(tmp, func, ctx); - emit(A64_PUSH(A64_FP, A64_LR, A64_SP), ctx); - emit(A64_MOV(1, A64_FP, A64_SP), ctx); emit(A64_BLR(tmp), ctx); emit(A64_MOV(1, r0, A64_R(0)), ctx); - emit(A64_POP(A64_FP, A64_LR, A64_SP), ctx); break; } /* tail call */