From patchwork Tue May 17 23:31:08 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heinrich Schuchardt X-Patchwork-Id: 623324 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3r8YWZ2HtVz9vKf for ; Wed, 18 May 2016 09:31:54 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751860AbcEQXbc (ORCPT ); Tue, 17 May 2016 19:31:32 -0400 Received: from mout.gmx.net ([212.227.15.19]:59514 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751410AbcEQXba (ORCPT ); Tue, 17 May 2016 19:31:30 -0400 Received: from LT001.lan ([62.143.92.134]) by mail.gmx.com (mrgmx002) with ESMTPSA (Nemesis) id 0M4WRI-1bo3MP32nE-00yimv; Wed, 18 May 2016 01:31:17 +0200 From: Heinrich Schuchardt To: Johannes Berg , Emmanuel Grumbach , Luca Coelho , Kalle Valo Cc: Intel Linux Wireless , Eyal Shapira , Gregory Greenman , Alexander Bondar , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Heinrich Schuchardt Subject: [PATCH 1/1] iwlwifi: rs: remove superfluous check Date: Wed, 18 May 2016 01:31:08 +0200 Message-Id: <1463527868-12226-1-git-send-email-xypron.glpk@gmx.de> X-Mailer: git-send-email 2.1.4 X-Provags-ID: V03:K0:Vhe1r4g3GZjvbVYvnitCNOPmOItuoU4pffWA7QvW3j8e9zNeckf nnc/CsyBjy44XUcgWmidJG7NbnQ6N+Z6wQkwj7//dqpROjZoYn4Dej6DhNOSBE7cETxJyIY hUyha2NnqLMhtGqckoaKRKla+COlnauPbw3Pz0r0RAqjH2c6tSyUVx267IgN+Ks0P8VmDu7 hSczOpg6n2OgwiNLdF1Ww== X-UI-Out-Filterresults: notjunk:1; V01:K0:mBzk8ODTfus=:JKRkgiWGFEfCK6gOIbYhE/ ROorUIby50C8+Ds2M+BA+OGaLOx+cDQCflndC2qQryinpdAPWmfnlgrTbtxTTeSW2AgHU5lDU 3EgIgqlx1i2wIJk3ueH8UVQ2VLhiAvb0wknOjfytvcej6db0JRhi9AxBjQwxMoGi0IOShKpE6 2yeHY0w0lGfEiYN2CRYsqSSedCaBFjeGBG9pacPOcA1TbjIEvzD2uJgH0F8qrWKqEVzvHhsmr 0wC7YkaLlIRKsLI+Gm2sy/kRz/u83yT5rfxMlfxEuLH0Nzam83CPcnpagvkYdL3IfnqRmmDle kIcedITjuYwzACEgH2v1nYe+a7Piu1pPc+OeMvGyOXnVnIFlZqkTKDwV1MSLFXxIDWMzNua3U VBUE/LbtqkMS1mqL71GqpInKWjdDN0USLnMyjtMgMP9/4A4OAgH0jPd+oyCp6Bxnd0nso3juc 4Itx1IHa052oYWVFid1vytKT+K3ZvXRkACRPjKQpIui7UAhbdFEw15N2HF5AzEYQAQVSX40Sp Xn81NCUKE9vUYEvzKBlsn2gIVG2XuTtsD+WgKGTuX9dn+vgsc5ZgEeY6dh62OiWY15R5Y9p5d L258aNtf1sVSi361/OequMmi/lv1AmVX/WX8MLB0kAZQ8b9WQE4F4MXnGfLhWDLV9VutK+tTe ZD3OASaV6q9CrFfirxZS8tvbHBR8d/3SBx7oMgzPsp+pG1ynrrIPCuPxrnlUz4D8jjkvHYIfd kVqU1mettB8kXtSjwAE1ITcsNYixzpIf4OdUan0eCibPDU1+r7XYm4LKDQ8= Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org If we dereference a variable anyway in other parts of the code, there is no need to check against NULL in a single place. Signed-off-by: Heinrich Schuchardt --- drivers/net/wireless/intel/iwlwifi/mvm/rs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/rs.c b/drivers/net/wireless/intel/iwlwifi/mvm/rs.c index 81dd2f6..bab01ea 100644 --- a/drivers/net/wireless/intel/iwlwifi/mvm/rs.c +++ b/drivers/net/wireless/intel/iwlwifi/mvm/rs.c @@ -2867,7 +2867,7 @@ static void rs_get_rate(void *mvm_r, struct ieee80211_sta *sta, void *mvm_sta, /* TODO: handle rate_idx_mask and rate_idx_mcs_mask */ /* Treat uninitialized rate scaling data same as non-existing. */ - if (lq_sta && !lq_sta->pers.drv) { + if (!lq_sta->pers.drv) { IWL_DEBUG_RATE(mvm, "Rate scaling not initialized yet.\n"); mvm_sta = NULL; }