From patchwork Tue May 17 22:06:02 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heinrich Schuchardt X-Patchwork-Id: 623300 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3r8Wf16m7Yz9t0t for ; Wed, 18 May 2016 08:07:21 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751666AbcEQWHB (ORCPT ); Tue, 17 May 2016 18:07:01 -0400 Received: from mout.gmx.net ([212.227.15.18]:64302 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751119AbcEQWHA (ORCPT ); Tue, 17 May 2016 18:07:00 -0400 Received: from LT001.lan ([62.143.92.134]) by mail.gmx.com (mrgmx002) with ESMTPSA (Nemesis) id 0M0gww-1brsJi0QxS-00uqvV; Wed, 18 May 2016 00:06:32 +0200 From: Heinrich Schuchardt To: Samuel Ortiz Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Heinrich Schuchardt Subject: [PATCH 1/1] net: irda: avoid null pointer dereference Date: Wed, 18 May 2016 00:06:02 +0200 Message-Id: <1463522762-11144-1-git-send-email-xypron.glpk@gmx.de> X-Mailer: git-send-email 2.1.4 X-Provags-ID: V03:K0:vp0fVfqRxrTYSu6yLV10MXz+v5yIW5S6XWut9MYoWoSOdHAisX/ 1gMjIbh/C17TKHHAcTs8b8oFbrtfBMyUqbzJZCsmiOFlXgf3J1B9ZgBNx5xC5i3wPJ1B4v0 4n7w2J0qZlbxwZr9Kx7XnR3gLaYmxWJxjPuFAfIH7G2PU1o5c17pvhH4sUyYMqS4KH1uKdQ O6FBKbpqdg0BXd3dUu4tw== X-UI-Out-Filterresults: notjunk:1; V01:K0:jz6ZVfXx2Qo=:9p54TFq9/7IR9n2UHDt6Js YTGtFrlXdqfbzzWlGV187h/AWuoxdZeud06trbQ0jdruyMa9I/YQgeoiEjlejIIwd7GF9IT7I 62xcYCCeAeTrjKMcnLsoALWCBW92WJ1aPOkgRqmxx9uA2KBsxbX9+1Kbov7agmUJa1GEfVxxJ qUb26O4xf4I/qYoBMR6iiR8IBShLs+Qrf8JPfCajUd2oCXlVlRAw/oGcZ4Ge3HP+IDeXdDkRf Z4zPggRWhSsgueQmhgLTN6x2DsraQZZvO1WtdAgFvvN2D+wZ/FG3iYXoYv+BQNmB/0DQJv9yT XIWZd1yX0RdcggRg2Dbg3vSrFmR5ZH7NZCGw/AyJLu9GUp8zKtBkZ1j46ODGY1HaOhugXmuXQ kvUuAv0maOrQUlq4Alk2KIKYaHwaA34PmeUEb67t2HglO3n4Vc90qJlXOpdjeM5LeDC+lWN0o atVkG8Sde7H9MAcq0356p/+Fj/s35eo2M8SWW6irf9CYK4CP9vJgOhkFDITHafMw4Ae2UY0DT 0xZ8ShLreaLQrdXbpYI6WEHne44Bua+A7afWwKuaoZe7kEHM8fb3tmU7TmJtKHzDhl5NVXbeP 8QlDPOXASC7mNRvirOOecAPKFQc8Q3rc7HrbkpDX3zPXYuJqziByw+nsi84s3N/hCFVxZHGM2 6jjDOB+C9DBnWWFE7t1gc1KUluosLgh1KT1HmCAlt/QcKlDEJDTwd5vQSVHUQNh4Kt8edcwgO XS3UTNM4spRj5pEV23WfqUbl7xiTrXvcouVsClW7Sn+6kdeAB3Vkvo+rX2Y8GAxvVJc0IbaJ/ nO6FYVqdM9L0fifO/HZezYFx7FEZw== Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Only dereference variable self after checking it is not NULL. Signed-off-by: Heinrich Schuchardt --- drivers/net/irda/nsc-ircc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/irda/nsc-ircc.c b/drivers/net/irda/nsc-ircc.c index 9ef13d8..aaecc3b 100644 --- a/drivers/net/irda/nsc-ircc.c +++ b/drivers/net/irda/nsc-ircc.c @@ -1253,7 +1253,7 @@ static void nsc_ircc_change_dongle_speed(int iobase, int speed, int dongle_id) */ static __u8 nsc_ircc_change_speed(struct nsc_ircc_cb *self, __u32 speed) { - struct net_device *dev = self->netdev; + struct net_device *dev; __u8 mcr = MCR_SIR; int iobase; __u8 bank; @@ -1263,6 +1263,7 @@ static __u8 nsc_ircc_change_speed(struct nsc_ircc_cb *self, __u32 speed) IRDA_ASSERT(self != NULL, return 0;); + dev = self->netdev; iobase = self->io.fir_base; /* Update accounting for new speed */