From patchwork Tue May 17 19:40:38 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heinrich Schuchardt X-Patchwork-Id: 623256 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3r8SQn1PX9z9t87 for ; Wed, 18 May 2016 05:42:25 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751248AbcEQTmF (ORCPT ); Tue, 17 May 2016 15:42:05 -0400 Received: from mout.gmx.net ([212.227.15.15]:62596 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750792AbcEQTmE (ORCPT ); Tue, 17 May 2016 15:42:04 -0400 Received: from LT001.lan ([62.143.92.134]) by mail.gmx.com (mrgmx003) with ESMTPSA (Nemesis) id 0Lm3bl-1bboVD3IQ5-00Zcuw; Tue, 17 May 2016 21:41:18 +0200 From: Heinrich Schuchardt To: Sunil Goutham , Robert Richter Cc: linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Heinrich Schuchardt Subject: [PATCH 1/1] net: thunderx: avoid null pointer dereference Date: Tue, 17 May 2016 21:40:38 +0200 Message-Id: <1463514038-9008-1-git-send-email-xypron.glpk@gmx.de> X-Mailer: git-send-email 2.1.4 X-Provags-ID: V03:K0:xKtSCyJleFEkJJwSkGOr19y9pXZR+NDU05iDctt58soUbqWlni2 +cWuv/R1gi6lOPUXRW5m5rQHnHssdybLHmzXLHPLlX5P7SXA5SjExh3bt49bJgO1BdcWKeQ 1yUEs7btmM1cM8vxLMagSt3gTv0W9FUA7dAhY0o7VOnYJ+/dw3S8/fH+1qUS9owiS+NTr8t i+vMct8LPWiznUpJ/vT7w== X-UI-Out-Filterresults: notjunk:1; V01:K0:VCReLxKjLYk=:xceJxwpwkkjuxV4/XeGEqJ xmF/i6LzJ7fSjMSh6MaJ2OGajNm9bWP7FSUhtg3t5wjCY1AZpojgbqEPKNI+TGYbxGeKfhgVj Uxz2wUaJkJFXs0qPlZlgbIPEdJQ+Wz2cvc7MMAn4a16TgS1WaAkn9FzxhVSA7iT2RNoN7qwhb hdtFx4IR8hWw7OgHYMqHzrabpwP0KMRPJUKNyQPjTjiM6/YPq7i7zyPO6abNjIvO1nFNRkMA2 ERMp9hNLaVvYttWqLPMRow0PNmF8ZCANNcwPEV1SW0Kkrxoom5goa6IzKZtj7Rg+LHIIK62bH nWBqV6OXeuZTvebbSt88uO4Lx/oCiXa/erObbxvZ1dzE4+wG9DGvG5gYtjGnBCArU3Cvudh7a dHIdhVIgm+JOXyb8eZzo68IFp3r2kPlAyVoQYjJwdcicKhQ72qvzq0mvw7WBBvdM6Dpeb39JF XQVzLHDN+9he1xjP7bQFeumuiDugcwH28sXKlxx7mm7namwR/R3jhc1T5Oh78hVR9JdvCORJ4 QQFsCg9KLCiIZeaaXpq7N7j09xwnTtAhEsxEkhv486HlPOOIgY4m+H0t6Tr55mCU9UR6rc7bS U6sx//dFPySy8KSm3tJfKP7iJbzPVu9aldUwumdAAOLSqmxfIhQ6Xb0ww85AuPK7jwbx0HyIu WObyApKUI4m8L/e0j0QT64A1URhTiYqkeMWVh/VaeExTsVPr4DrjiENB8lo1swEQAs4LH0Owk QmtwKW0fVitIsCTvlznJWdwj/VR51EdSjU0ds3y5KuOFJNs+98hLh8Z2oINIIp6SBubNzrlrZ 1WnUAkUIIRO0rY3kCtN54eWG2RXCQ== Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org In function bgx_lmac_handler only use a member of lmac after checking it is not null. Signed-off-by: Heinrich Schuchardt Acked-by: David Daney --- drivers/net/ethernet/cavium/thunder/thunder_bgx.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/cavium/thunder/thunder_bgx.c b/drivers/net/ethernet/cavium/thunder/thunder_bgx.c index d20539a..3ed2198 100644 --- a/drivers/net/ethernet/cavium/thunder/thunder_bgx.c +++ b/drivers/net/ethernet/cavium/thunder/thunder_bgx.c @@ -274,12 +274,14 @@ static void bgx_sgmii_change_link_state(struct lmac *lmac) static void bgx_lmac_handler(struct net_device *netdev) { struct lmac *lmac = container_of(netdev, struct lmac, netdev); - struct phy_device *phydev = lmac->phydev; + struct phy_device *phydev; int link_changed = 0; if (!lmac) return; + phydev = lmac->phydev; + if (!phydev->link && lmac->last_link) link_changed = -1;