| Message ID | 1460030256-16791-2-git-send-email-shamir.rabinovitch@oracle.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
On 4/7/2016 4:57 AM, Shamir Rabinovitch wrote: > When PAGE_SIZE > 4k single page can contain 2 RDS fragments. If > 'rds_ib_cong_recv' ignore the RDS fragment offset in to the page it > then read the data fragment as far congestion map update and lead to > corruption of the RDS connection far congestion map. > > Signed-off-by: Shamir Rabinovitch <shamir.rabinovitch@oracle.com> > --- Acked-by: Santosh Shilimkar <santosh.shilimkar@oracle.com>
diff --git a/net/rds/ib_recv.c b/net/rds/ib_recv.c index 977fb86..abc8cc8 100644 --- a/net/rds/ib_recv.c +++ b/net/rds/ib_recv.c @@ -796,7 +796,7 @@ static void rds_ib_cong_recv(struct rds_connection *conn, addr = kmap_atomic(sg_page(&frag->f_sg)); - src = addr + frag_off; + src = addr + frag->f_sg.offset + frag_off; dst = (void *)map->m_page_addrs[map_page] + map_off; for (k = 0; k < to_copy; k += 8) { /* Record ports that became uncongested, ie
When PAGE_SIZE > 4k single page can contain 2 RDS fragments. If 'rds_ib_cong_recv' ignore the RDS fragment offset in to the page it then read the data fragment as far congestion map update and lead to corruption of the RDS connection far congestion map. Signed-off-by: Shamir Rabinovitch <shamir.rabinovitch@oracle.com> --- net/rds/ib_recv.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)