Message ID | 1459541870-26938-1-git-send-email-cascardo@redhat.com |
---|---|
State | Accepted, archived |
Delegated to: | David Miller |
Headers | show |
Le 01/04/2016 22:17, Thadeu Lima de Souza Cascardo a écrit : > When creating an ip6tnl tunnel with ip tunnel, rtnl_link_ops is not set > before ip6_tnl_create2 is called. When register_netdevice is called, there > is no linkinfo attribute in the NEWLINK message because of that. > > Setting rtnl_link_ops before calling register_netdevice fixes that. > > Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@redhat.com> Fixes: 0b112457229d ("ip6tnl: add support of link creation via rtnl") Acked-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
From: Thadeu Lima de Souza Cascardo <cascardo@redhat.com> Date: Fri, 1 Apr 2016 17:17:50 -0300 > When creating an ip6tnl tunnel with ip tunnel, rtnl_link_ops is not set > before ip6_tnl_create2 is called. When register_netdevice is called, there > is no linkinfo attribute in the NEWLINK message because of that. > > Setting rtnl_link_ops before calling register_netdevice fixes that. > > Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@redhat.com> Applied and queued up for -stable.
diff --git a/net/ipv6/ip6_tunnel.c b/net/ipv6/ip6_tunnel.c index eb2ac4b..1f20345 100644 --- a/net/ipv6/ip6_tunnel.c +++ b/net/ipv6/ip6_tunnel.c @@ -252,12 +252,12 @@ static int ip6_tnl_create2(struct net_device *dev) t = netdev_priv(dev); + dev->rtnl_link_ops = &ip6_link_ops; err = register_netdevice(dev); if (err < 0) goto out; strcpy(t->parms.name, dev->name); - dev->rtnl_link_ops = &ip6_link_ops; dev_hold(dev); ip6_tnl_link(ip6n, t);
When creating an ip6tnl tunnel with ip tunnel, rtnl_link_ops is not set before ip6_tnl_create2 is called. When register_netdevice is called, there is no linkinfo attribute in the NEWLINK message because of that. Setting rtnl_link_ops before calling register_netdevice fixes that. Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@redhat.com> --- net/ipv6/ip6_tunnel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)