From patchwork Wed Mar 30 02:11:14 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Moritz Fischer X-Patchwork-Id: 605617 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3qdMVl3GBJz9t4D for ; Mon, 4 Apr 2016 03:26:55 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=ettus-com.20150623.gappssmtp.com header.i=@ettus-com.20150623.gappssmtp.com header.b=QmtPNAD3; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754257AbcDCR0m (ORCPT ); Sun, 3 Apr 2016 13:26:42 -0400 Received: from mail-oi0-f51.google.com ([209.85.218.51]:33042 "EHLO mail-oi0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753642AbcDCR0h (ORCPT ); Sun, 3 Apr 2016 13:26:37 -0400 Received: by mail-oi0-f51.google.com with SMTP id w85so8662855oiw.0 for ; Sun, 03 Apr 2016 10:26:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ettus-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=2llDr8pLbRyRB2j1eTaP1/3BsAR6KGaOPoElnFz5n9I=; b=QmtPNAD34LSWklExTotn1ebGhXyfUZ5z+rjuXwjtO4+fY3EjYqLtRU2s3h3t4/cujn TZiH1lQwOtmwGPcS5hcMbk3UlZz0KZfs5B1Qs0GEouVkTUh/xsCkjbC7EM5+lZ0zGUiW wBqU8FGKtm+eRetYiJyzQXFhjhCo/hrrs1JShb2W3JGnlcgNdVTD7N/Gho47B9/IS8xJ zqmcJ8hnYlB+hevjsdmF3f4oglx8l/DQ/Y9uI7VCh9cJaNIE5u3Eho7xOBGTj/+L0YPu wGQZO14XqpqT9R72ZK8EGqAJUHot+KmcCTODk8qiiFjy6laISZBcSh/DG2lGMv4IRHIP zcSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=2llDr8pLbRyRB2j1eTaP1/3BsAR6KGaOPoElnFz5n9I=; b=URNqEDnq3HN3NG8zCnYP62eUUO9sAAwo4h0uBKTT6t+x2w3dDZF6Q0y9epmF7p+w27 bFiBgiZJd5FjX+WNjVuH2Lt4E04uGOvdJhSjjHrzGDLQ0SfemO+yqhxfvdJgRjvTrJIF +I5yFN9svqEjg8s043AT4bv927uX5GYBuRyfOUqqhmrKOCAQxVM+4TNhrZ3GyJENfPPE KJ3ue3KmjN+75zxp3DfJ5+a7nK/4jxlOTt0679dF12jyx3wpO77a9wWLRw4H0ST826qH WJTl/FqjRKPTVbMWXuX+4GprbJ+piOjw8No1jh653rQSyCd0YPmQ66a9PZNme0tyhpsQ a3Jg== X-Gm-Message-State: AD7BkJJKWaEh52oBaVBWNPEQfLR9OuyFp0Z7ZwQt+rK+QGYTa21roZCRq1HxRCsTKvh4Q2ku X-Received: by 10.157.19.93 with SMTP id q29mr7991987otq.171.1459704397078; Sun, 03 Apr 2016 10:26:37 -0700 (PDT) Received: from archbook.ni.corp.natinst.com ([156.39.10.45]) by smtp.gmail.com with ESMTPSA id s3sm7256402obf.29.2016.04.03.10.26.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sun, 03 Apr 2016 10:26:36 -0700 (PDT) From: Moritz Fischer To: nicolas.ferre@atmel.com Cc: michal.simek@xilinx.com, joe@perches.com, davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, moritz.fischer.private@gmail.com, Moritz Fischer Subject: [PATCH v3 4/5] net: macb: Use ether_addr_copy over memcpy Date: Tue, 29 Mar 2016 19:11:14 -0700 Message-Id: <1459303875-3362-5-git-send-email-moritz.fischer@ettus.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1459303875-3362-1-git-send-email-moritz.fischer@ettus.com> References: <1459303875-3362-1-git-send-email-moritz.fischer@ettus.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Checkpatch suggests using ether_addr_copy over memcpy to copy the mac address. Acked-by: Michal Simek Acked-by: Nicolas Ferre Signed-off-by: Moritz Fischer --- drivers/net/ethernet/cadence/macb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/cadence/macb.c b/drivers/net/ethernet/cadence/macb.c index 2ba0934..01a8ffb 100644 --- a/drivers/net/ethernet/cadence/macb.c +++ b/drivers/net/ethernet/cadence/macb.c @@ -2973,7 +2973,7 @@ static int macb_probe(struct platform_device *pdev) mac = of_get_mac_address(np); if (mac) - memcpy(bp->dev->dev_addr, mac, ETH_ALEN); + ether_addr_copy(bp->dev->dev_addr, mac); else macb_get_hwaddr(bp);