From patchwork Tue Mar 22 15:31:19 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lance Richardson X-Patchwork-Id: 600866 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3qTxW5607Nz9ryQ for ; Wed, 23 Mar 2016 02:31:29 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755312AbcCVPb2 (ORCPT ); Tue, 22 Mar 2016 11:31:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56954 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751493AbcCVPb0 (ORCPT ); Tue, 22 Mar 2016 11:31:26 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id 6A6F7804FC for ; Tue, 22 Mar 2016 15:31:26 +0000 (UTC) Received: from localhost.localdomain.com (vpn1-6-251.ams2.redhat.com [10.36.6.251]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u2MFVNh3018533 for ; Tue, 22 Mar 2016 11:31:25 -0400 From: Lance Richardson To: netdev@vger.kernel.org Subject: [PATCH net] ipv4: initialize flowi4_flags before calling fib_lookup() Date: Tue, 22 Mar 2016 11:31:19 -0400 Message-Id: <1458660679-7279-1-git-send-email-lrichard@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Field fl4.flowi4_flags is not initialized in fib_compute_spec_dst() before calling fib_lookup(), which means fib_table_lookup() is using non-deterministic data at this line: if (!(flp->flowi4_flags & FLOWI_FLAG_SKIP_NH_OIF)) { Fix by initializing fl4.flowi4_flags to zero. Signed-off-by: Lance Richardson --- net/ipv4/fib_frontend.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/ipv4/fib_frontend.c b/net/ipv4/fib_frontend.c index 21add55..896844a 100644 --- a/net/ipv4/fib_frontend.c +++ b/net/ipv4/fib_frontend.c @@ -304,6 +304,7 @@ __be32 fib_compute_spec_dst(struct sk_buff *skb) fl4.flowi4_scope = scope; fl4.flowi4_mark = IN_DEV_SRC_VMARK(in_dev) ? skb->mark : 0; fl4.flowi4_tun_key.tun_id = 0; + fl4.flowi4_flags = 0; if (!fib_lookup(net, &fl4, &res, 0)) return FIB_RES_PREFSRC(net, res); } else {