From patchwork Sun Mar 13 19:10:46 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Moritz Fischer X-Patchwork-Id: 596804 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3qNVqV04w6z9sXQ for ; Mon, 14 Mar 2016 06:11:50 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=ettus-com.20150623.gappssmtp.com header.i=@ettus-com.20150623.gappssmtp.com header.b=ZzoRCwKx; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932148AbcCMTLk (ORCPT ); Sun, 13 Mar 2016 15:11:40 -0400 Received: from mail-pa0-f44.google.com ([209.85.220.44]:36395 "EHLO mail-pa0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754139AbcCMTLI (ORCPT ); Sun, 13 Mar 2016 15:11:08 -0400 Received: by mail-pa0-f44.google.com with SMTP id tt10so140549549pab.3 for ; Sun, 13 Mar 2016 12:11:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ettus-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=6ifG8X/+Obgmlx598MKTIwYQHnAVSSDIcx/EpBORd+o=; b=ZzoRCwKxslqMyRaPyiu+AWYm0I2Ad37gNB2i3hohDrvqW6g7FuULlOULwn049AJ2dW dGcUkhPf2GPZw8vdUrIlfLiFb5+XTd4rQd4SC8x458Lf0IV2K/aQLX+7QWvenwVyc69V vlRzMy+HddXh9nRlCM0cWt4P2SPXa8uWNrrce2ThlXS3z+CZxz2iOEsKBmtW9HyINMdH Nk9tJ0Dxhbgx6DmHJHV7PaHVmqt72ehpiEmXa+SeUyCO/fgHcGz3FYsplghlUWJpHhcP z1C/zzQ3vs/bLvMHvgFoN0V1rr1WD/wY90WORZ8jwxPSmW/0je1N5EbD+sL6gh7GqMne 3gJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=6ifG8X/+Obgmlx598MKTIwYQHnAVSSDIcx/EpBORd+o=; b=fB5OrQS0FKAubasurFMb1BgLLeDnuBMXie82YNIlm5nRhP80BN+9/2mp5LEZMWAKe2 tH2cD7GYAlpv1tEGXYE0EhsoO0HoNX6U7b7tST9d/anhm8xDhhn+JpfbZIg4QfMgr/Lr eNMtnubsH7TkT5JIjS2lvLXw25pOZpmRSYY8+W2N9eekgcEpsh6sTJgqdH3465/Y0TZT jxaxHIDPw1FmKpfME7qJtnrsgTr7uN4brmNFs5Xy2ZZahI51rcbxE+yArDjErCw+r/Nz B5Kv1Pf1L+i5AT3P3s4QZpyQNH5a1gJTQqMiM2YgqYq1ehhEeYjuGK6R3Ir1B0Ebz9WX 8lqg== X-Gm-Message-State: AD7BkJK+iQVs3Bhha0IGr0gnDHwwo+OU+pfvB0Lx90pboHEzOtC5RitxtETpfuWZzFTjVUQO X-Received: by 10.67.23.202 with SMTP id ic10mr31376016pad.127.1457896267834; Sun, 13 Mar 2016 12:11:07 -0700 (PDT) Received: from beastybook.lan (c-50-185-0-126.hsd1.ca.comcast.net. [50.185.0.126]) by smtp.gmail.com with ESMTPSA id i11sm26646052pfi.55.2016.03.13.12.11.06 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 13 Mar 2016 12:11:07 -0700 (PDT) From: Moritz Fischer To: nicolas.ferre@atmel.com Cc: michal.simek@xilinx.com, joe@perches.com, davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, moritz.fischer.private@gmail.com, Moritz Fischer Subject: [PATCH 4/5] net: macb: Use ether_addr_copy over memcpy Date: Sun, 13 Mar 2016 12:10:46 -0700 Message-Id: <1457896247-25934-5-git-send-email-moritz.fischer@ettus.com> X-Mailer: git-send-email 2.4.3 In-Reply-To: <1457896247-25934-1-git-send-email-moritz.fischer@ettus.com> References: <1457896247-25934-1-git-send-email-moritz.fischer@ettus.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Checkpatch suggests using ether_addr_copy over memcpy to copy the mac address. Signed-off-by: Moritz Fischer Acked-by: Michal Simek Acked-by: Nicolas Ferre --- drivers/net/ethernet/cadence/macb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/cadence/macb.c b/drivers/net/ethernet/cadence/macb.c index 53400f6..a0c01e5 100644 --- a/drivers/net/ethernet/cadence/macb.c +++ b/drivers/net/ethernet/cadence/macb.c @@ -2891,7 +2891,7 @@ static int macb_probe(struct platform_device *pdev) mac = of_get_mac_address(np); if (mac) - memcpy(bp->dev->dev_addr, mac, ETH_ALEN); + ether_addr_copy(bp->dev->dev_addr, mac); else macb_get_hwaddr(bp);