From patchwork Fri Mar 4 07:19:04 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrzej Hajda X-Patchwork-Id: 591786 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id D658F1401E7 for ; Fri, 4 Mar 2016 18:19:32 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758013AbcCDHTM (ORCPT ); Fri, 4 Mar 2016 02:19:12 -0500 Received: from mailout4.w1.samsung.com ([210.118.77.14]:22713 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751080AbcCDHTK (ORCPT ); Fri, 4 Mar 2016 02:19:10 -0500 Received: from eucpsbgm1.samsung.com (unknown [203.254.199.244]) by mailout4.w1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0O3I0040Z6ZUSD60@mailout4.w1.samsung.com>; Fri, 04 Mar 2016 07:19:06 +0000 (GMT) X-AuditID: cbfec7f4-f79026d00000418a-1b-56d936eac181 Received: from eusync3.samsung.com ( [203.254.199.213]) by eucpsbgm1.samsung.com (EUCPMTA) with SMTP id 83.E1.16778.AE639D65; Fri, 4 Mar 2016 07:19:06 +0000 (GMT) Received: from AMDC1061.digital.local ([106.116.147.88]) by eusync3.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0O3I00ALS6ZUG480@eusync3.samsung.com>; Fri, 04 Mar 2016 07:19:06 +0000 (GMT) From: Andrzej Hajda To: Giuseppe Cavallaro , netdev@vger.kernel.org Cc: Andrzej Hajda , Bartlomiej Zolnierkiewicz , Marek Szyprowski , linux-kernel@vger.kernel.org Subject: [PATCH] stmmac: Fix type of local variable in stmmac_xmit Date: Fri, 04 Mar 2016 08:19:04 +0100 Message-id: <1457075944-6959-1-git-send-email-a.hajda@samsung.com> X-Mailer: git-send-email 1.9.1 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrNJMWRmVeSWpSXmKPExsVy+t/xq7qvzG6GGVxbqWpxa905VouNM9az WlzeNYfNYu2Ru+wWxxaIWfx/vZXRgc2jb8sqRo+nP/Yye3zeJBfAHMVlk5Kak1mWWqRvl8CV sXy3VcE1jop3vc1sDYxb2bsYOTkkBEwkJk25CWWLSVy4t56ti5GLQ0hgKaPE/4PbWSGcJiaJ l4+Os4JUsQloSvzdfJMNxBYRcJdYdPgBE0gRs8AaRomOSdtYQBLCAk4Sex/tZ+xi5OBgEVCV +PpDFiTMCxT+MrOXEWKbnMTJY5NZJzByL2BkWMUomlqaXFCclJ5rqFecmFtcmpeul5yfu4kR EgRfdjAuPmZ1iFGAg1GJh/dGw/UwIdbEsuLK3EOMEhzMSiK86/VvhgnxpiRWVqUW5ccXleak Fh9ilOZgURLnnbvrfYiQQHpiSWp2ampBahFMlomDU6qBcdP+x1tPqjtnvJulapC1Sjp6XZ91 os1qXr0/Ny//Dt6nxv98399m1WubZzro8K7L3nuLgW+LxD5mz8Ztv9wdGJZ2WxVtCTV6J8/9 3Sol4bqZv5dvteK0+Yy6qySEXgpdnBx4YM3NIyznd77g1Jx2x9bhpLFK43mtVZvzi1a/qsjP 23H+igCfhxJLcUaioRZzUXEiAHELtSz+AQAA Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Variable entry holds result of jumbo_frm callback. It can be negative, so the variable should be signed. The patch changes also type of related first_entry variable to make code compact and coherent. The problem has been detected using patch scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci. Signed-off-by: Andrzej Hajda --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c index 4c5ce98..cd31a3c 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c @@ -1955,7 +1955,7 @@ static netdev_tx_t stmmac_xmit(struct sk_buff *skb, struct net_device *dev) unsigned int nopaged_len = skb_headlen(skb); int i, csum_insertion = 0, is_jumbo = 0; int nfrags = skb_shinfo(skb)->nr_frags; - unsigned int entry, first_entry; + int entry, first_entry; struct dma_desc *desc, *first; unsigned int enh_desc;