From patchwork Sat Feb 13 14:03:15 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sudip Mukherjee X-Patchwork-Id: 582400 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 6783F140326 for ; Sun, 14 Feb 2016 01:03:47 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=1AR7h+ZI; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751481AbcBMODc (ORCPT ); Sat, 13 Feb 2016 09:03:32 -0500 Received: from mail-pf0-f174.google.com ([209.85.192.174]:33131 "EHLO mail-pf0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751231AbcBMODa (ORCPT ); Sat, 13 Feb 2016 09:03:30 -0500 Received: by mail-pf0-f174.google.com with SMTP id q63so62438553pfb.0; Sat, 13 Feb 2016 06:03:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=aaICQhUEnzawIzSBe1G5PDx+W43YZx0kc+w+OIVsdKc=; b=1AR7h+ZIsdF4zr/X7D8s9kXPgBHl1RFyb4awdftOmFAciZfDrxluJuXgqEtty2/QHX +Vb79mnxvt0ymMuiLgtIHIkBUivg1SrvTADucBWNV92utOXA0/FW87n9OlVhXiH6Y0bp h2EyQzo1NqxOsYzFdl6KfKlbqYyBgpX/u6+c8Ite0lzWIy97wmUu5oVJN102qcnMYLMh QQsfnTKutYOh1CJJKa+/vBffb1c6ytZ2HYUqUfiSHv7IM1cJdzsGI6uYk+Qc1fB/AQLC EDxaCAaari2pAv0fmuZtkeyuArljp8bEMPfrexsrZU6dw9s53ThYyaxNkXPb3sG1wIYO MvvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=aaICQhUEnzawIzSBe1G5PDx+W43YZx0kc+w+OIVsdKc=; b=Pr8ZDqh5CUtdDgY7Z3vFv1Rjv1eGtnTr7db/3SDcKF/AOH3D6nuGJRl+cpipaRLbgo FDgivWr1r6mlDDIhSGCmjOQGtNRWNSDQHi8dhIqzpxwEI0O8/VdutcaQuM/VCKM/3G2b JRynyptlnv2jJEjGStaHmDmKGWCGsAVqFotr6aTY22+p4Fru82vmGoSixJGxnoBDmy3k a91Ib/c0UQqdYFY2Zp/hD8zjoaBLiHyf+dlwuynSTHduGfLFNIlUQiJKwtkDIvSo4zza Y4oko5XhSPvACFWhyT3nCuKzDDa820x2oc5zYFHKT6GpndgjdoeRkePjYeDaCBPawsnd B4Bg== X-Gm-Message-State: AG10YOQEIvNY+PdgvMFXY5xK8+Iuffw+0tnKNLugxGLRhKFenVhSEaggpiP4QIPtmkmkJg== X-Received: by 10.98.16.150 with SMTP id 22mr10021760pfq.128.1455372209458; Sat, 13 Feb 2016 06:03:29 -0800 (PST) Received: from localhost.localdomain ([103.24.124.194]) by smtp.gmail.com with ESMTPSA id l21sm26512764pfi.63.2016.02.13.06.03.25 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 13 Feb 2016 06:03:28 -0800 (PST) From: Sudip Mukherjee To: Florian Fainelli , "David S. Miller" Cc: linux-kernel@vger.kernel.org, kernel-testers@vger.kernel.org, netdev@vger.kernel.org, Geert Uytterhoeven , Sudip Mukherjee , Helmut Buchsbaum Subject: [PATCH v2] net: phy: spi_ks8995: add dependency on GPIO Date: Sat, 13 Feb 2016 19:33:15 +0530 Message-Id: <1455372195-10825-1-git-send-email-sudipm.mukherjee@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The builds of allmodconfig of s390, m68k, tilegx, tilepro is failing with the error: drivers/net/phy/spi_ks8995.c:477:3: error: implicit declaration of function 'gpiod_set_value' drivers/net/phy/spi_ks8995.c:477:19: error: implicit declaration of function 'gpio_to_desc' GPIO is now used to reset the switch so we should have a dependency on GPIOLIB. While adding the dependency also add COMPILE_TEST so that we can build test it. Fixes: cd6f288cbaab ("net: phy: spi_ks8995: add support for resetting switch using GPIO") Cc: Helmut Buchsbaum Signed-off-by: Sudip Mukherjee --- v2: added COMPILE_TEST and gpio/consumer.h drivers/net/phy/Kconfig | 1 + drivers/net/phy/spi_ks8995.c | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig index f0a7702..186f202 100644 --- a/drivers/net/phy/Kconfig +++ b/drivers/net/phy/Kconfig @@ -262,3 +262,4 @@ endif # PHYLIB config MICREL_KS8995MA tristate "Micrel KS8995MA 5-ports 10/100 managed Ethernet switch" depends on SPI + depends on GPIOLIB || COMPILE_TEST diff --git a/drivers/net/phy/spi_ks8995.c b/drivers/net/phy/spi_ks8995.c index 5e7340f..55000f6 100644 --- a/drivers/net/phy/spi_ks8995.c +++ b/drivers/net/phy/spi_ks8995.c @@ -20,6 +20,7 @@ #include #include #include +#include #include #include