From patchwork Mon Jan 25 07:35:20 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sudip Mukherjee X-Patchwork-Id: 572625 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 81BBE140291 for ; Mon, 25 Jan 2016 18:35:46 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=Asl8gP8F; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755254AbcAYHf3 (ORCPT ); Mon, 25 Jan 2016 02:35:29 -0500 Received: from mail-pa0-f66.google.com ([209.85.220.66]:33858 "EHLO mail-pa0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753293AbcAYHf2 (ORCPT ); Mon, 25 Jan 2016 02:35:28 -0500 Received: by mail-pa0-f66.google.com with SMTP id yy13so6206087pab.1; Sun, 24 Jan 2016 23:35:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=jMaX9ArYkIk0wNQkL0OoI70vGPBvuCqkDxy6kxr2ZsM=; b=Asl8gP8FuNNY2HZVdJTS6h0z8rmG1FijpuI02VVNES7WFPX7ZMNpIm0+U57qSvHtDM Yn5egbCzF1k2VNJWiMmiSiQJMYT+wEloQx1MP++0Ql3c7C2rhqnEfYuwRD6w3YhQpTS2 e6sFdxXwqB1iZL57okve80V3pMV+MTJV9Cdt/KViYOlu9Ms+7wByFW4iN3XROPhJ/PJL XJ0kI2xTWmAJPwKk3sT5N/KmBwaT3i4CiJ1yKJm47GbzkKfZ7CFso7tfu4ySKRXIowKE +StbbSoRm8WQz6hE4xGjwyBv8JliWyXYHVsrc9lbt5j/24GkFmAJLmWJ8m8G27ps+Hqc oXTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=jMaX9ArYkIk0wNQkL0OoI70vGPBvuCqkDxy6kxr2ZsM=; b=Vx7uIQMpMf5wKBDgsmdCqh2bBDUHvS0W6lhgYF2gvL/RJjE7L7MokpbgHp0c+UoJYd lugCDXyOrwS3Qfr8yRvVw32xoCEQJbV/krL0BTt7sLlrBA3KbcdCugc/9TdHhVVrPu0x i10v93TbWNNm9sugBJHvYvzj0qK3290wiQzLjIY5WAZ4WWPM5Zb/ArRAGUnyvRM/HAll APKl3bqO7YN97Qzpqf3+XVBB/O2PHHYAkCfaZyoZ/OD9DCQbjuAY4k9P6ukIq2koVidZ b6LFsQmg3pi+VvLzW6n6ZZJlrbomDLuFjAagoP4yGPFtI3ICIunrGlgiZGWfIRVfyxQB 5aEw== X-Gm-Message-State: AG10YOTWGCTN033wMZ9r7tS87eCvp99Ni6omDJUliauhtFIAT2Azt1gndZq6frEuOn1NeQ== X-Received: by 10.66.190.7 with SMTP id gm7mr23897378pac.79.1453707327830; Sun, 24 Jan 2016 23:35:27 -0800 (PST) Received: from sudip-pc.vectortproxy.org ([183.82.226.133]) by smtp.gmail.com with ESMTPSA id m70sm26031065pfi.90.2016.01.24.23.35.25 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sun, 24 Jan 2016 23:35:27 -0800 (PST) From: Sudip Mukherjee To: "David S. Miller" , "Maciej W. Rozycki" Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Sudip Mukherjee Subject: [PATCH v2] defxx: fix build warning Date: Mon, 25 Jan 2016 13:05:20 +0530 Message-Id: <1453707320-30556-1-git-send-email-sudipm.mukherjee@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org We are getting many build warnings about: 'bar_start' may be used uninitialized and 'bar_len' may be used uninitialized They are not actually uninitialized as dfx_get_bars() will initialize them properly. But still lets have them initialized just to satisfy the compiler (gcc 4.8.2). Signed-off-by: Sudip Mukherjee Acked-by: Maciej W. Rozycki --- v2: only the first element is zeroed. drivers/net/fddi/defxx.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/fddi/defxx.c b/drivers/net/fddi/defxx.c index 7f975a2..de5eaa6 100644 --- a/drivers/net/fddi/defxx.c +++ b/drivers/net/fddi/defxx.c @@ -533,8 +533,8 @@ static int dfx_register(struct device *bdev) const char *print_name = dev_name(bdev); struct net_device *dev; DFX_board_t *bp; /* board pointer */ - resource_size_t bar_start[3]; /* pointers to ports */ - resource_size_t bar_len[3]; /* resource length */ + resource_size_t bar_start[3] = {0}; /* pointers to ports */ + resource_size_t bar_len[3] = {0}; /* resource length */ int alloc_size; /* total buffer size used */ struct resource *region; int err = 0; @@ -3697,8 +3697,8 @@ static void dfx_unregister(struct device *bdev) int dfx_bus_pci = dev_is_pci(bdev); int dfx_bus_tc = DFX_BUS_TC(bdev); int dfx_use_mmio = DFX_MMIO || dfx_bus_tc; - resource_size_t bar_start[3]; /* pointers to ports */ - resource_size_t bar_len[3]; /* resource lengths */ + resource_size_t bar_start[3] = {0}; /* pointers to ports */ + resource_size_t bar_len[3] = {0}; /* resource lengths */ int alloc_size; /* total buffer size used */ unregister_netdev(dev);