| Message ID | 1453707320-30556-1-git-send-email-sudipm.mukherjee@gmail.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
On Mon, 25 Jan 2016, Sudip Mukherjee wrote: > We are getting many build warnings about: > 'bar_start' may be used uninitialized > and > 'bar_len' may be used uninitialized > > They are not actually uninitialized as dfx_get_bars() will initialize > them properly. But still lets have them initialized just to satisfy the > compiler (gcc 4.8.2). > > Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org> > --- Acked-by: Maciej W. Rozycki <macro@linux-mips.org> Thanks, Maciej
From: Sudip Mukherjee <sudipm.mukherjee@gmail.com> Date: Mon, 25 Jan 2016 13:05:20 +0530 > We are getting many build warnings about: > 'bar_start' may be used uninitialized > and > 'bar_len' may be used uninitialized > > They are not actually uninitialized as dfx_get_bars() will initialize > them properly. But still lets have them initialized just to satisfy the > compiler (gcc 4.8.2). > > Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org> Applied.
diff --git a/drivers/net/fddi/defxx.c b/drivers/net/fddi/defxx.c index 7f975a2..de5eaa6 100644 --- a/drivers/net/fddi/defxx.c +++ b/drivers/net/fddi/defxx.c @@ -533,8 +533,8 @@ static int dfx_register(struct device *bdev) const char *print_name = dev_name(bdev); struct net_device *dev; DFX_board_t *bp; /* board pointer */ - resource_size_t bar_start[3]; /* pointers to ports */ - resource_size_t bar_len[3]; /* resource length */ + resource_size_t bar_start[3] = {0}; /* pointers to ports */ + resource_size_t bar_len[3] = {0}; /* resource length */ int alloc_size; /* total buffer size used */ struct resource *region; int err = 0; @@ -3697,8 +3697,8 @@ static void dfx_unregister(struct device *bdev) int dfx_bus_pci = dev_is_pci(bdev); int dfx_bus_tc = DFX_BUS_TC(bdev); int dfx_use_mmio = DFX_MMIO || dfx_bus_tc; - resource_size_t bar_start[3]; /* pointers to ports */ - resource_size_t bar_len[3]; /* resource lengths */ + resource_size_t bar_start[3] = {0}; /* pointers to ports */ + resource_size_t bar_len[3] = {0}; /* resource lengths */ int alloc_size; /* total buffer size used */ unregister_netdev(dev);
We are getting many build warnings about: 'bar_start' may be used uninitialized and 'bar_len' may be used uninitialized They are not actually uninitialized as dfx_get_bars() will initialize them properly. But still lets have them initialized just to satisfy the compiler (gcc 4.8.2). Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org> --- v2: only the first element is zeroed. drivers/net/fddi/defxx.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)