From patchwork Mon Jan 25 06:15:07 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sudip Mukherjee X-Patchwork-Id: 572611 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 7AFFA14018C for ; Mon, 25 Jan 2016 17:15:34 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=ESJUgYne; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753548AbcAYGPR (ORCPT ); Mon, 25 Jan 2016 01:15:17 -0500 Received: from mail-pa0-f65.google.com ([209.85.220.65]:36612 "EHLO mail-pa0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751031AbcAYGPO (ORCPT ); Mon, 25 Jan 2016 01:15:14 -0500 Received: by mail-pa0-f65.google.com with SMTP id a20so6152298pag.3; Sun, 24 Jan 2016 22:15:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=nXi+KJP4u/WdMykt8nVFGMAFEKe67FCoN+UoFIov6j4=; b=ESJUgYneE8ThEuAEvbXUzJnfNBvdxfTvdJegP19yzKrdJzNmvF7kaf4hev6wGIwbv5 HNURq1FSlgTF2Qnhp3/1qSGXfmdVZO+y76pbJA95xu/kB0EtiJH4KTJXkpr8Azi4hQgm F+FKhvBV+g3FZnE8Fl2q5+XDC+LCMFFVJ4jzvjRxWOCNGks7Dd/TLTNiNj98Skx/1u/y js0Asp4+EVrcbzBlue7NaJJB2CzS2nJAkRPJA0rsXbexl7Mt8x+MmEvLaUE0S9rrsMDQ y9Jz2/Md7tSvnkBIdgGlefvkqZhvo//ChdBTiKlhhP0aBE9jBPAksL1KRRRcSk3WTkfV IG7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=nXi+KJP4u/WdMykt8nVFGMAFEKe67FCoN+UoFIov6j4=; b=CvICaEecv+vdT4I5aCfQ+JlvlcKiyVentyMTg46yEhtmOO4eeXxzdNqkfFhZftXHA1 upKrJssOReOupU8MPlJOfgQcGFEw+2wifitGbl6bnNeQugW1Oel1QSjQuWy9HjuH/8He w7G8dajSV9kQH8eFlFXNM+/fAVEwDI5Tn+y/p47flZLzYqD7rJ1ed+Wp18Dj5V4MjZyi vJ1wNFwSZaKN1cj5e8pAidvgLyU9Z6eRyONijQd167FaGHOmha3QQhFDaP6tcdSLf+z4 HDLGnOs1x3imK7mpt2jf9Ejas9ZA9AQKhTwzvnqf93oOvomH1nemfVoIbX3x9+7TJ5F5 dh5A== X-Gm-Message-State: AG10YOT2capo1IWCrZbDzMkBBsaiNxm2zz0eiBHMyU5R53/KTrBSWwNtFT4NZFBwBYK+Ig== X-Received: by 10.66.163.231 with SMTP id yl7mr22852973pab.141.1453702514312; Sun, 24 Jan 2016 22:15:14 -0800 (PST) Received: from sudip-pc.vectortproxy.org ([183.82.226.133]) by smtp.gmail.com with ESMTPSA id 63sm25400258pfo.67.2016.01.24.22.15.12 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sun, 24 Jan 2016 22:15:13 -0800 (PST) From: Sudip Mukherjee To: "Maciej W. Rozycki" Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Sudip Mukherjee Subject: [PATCH 3/3] defxx: fix build warning Date: Mon, 25 Jan 2016 11:45:07 +0530 Message-Id: <1453702507-736-1-git-send-email-sudipm.mukherjee@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org We are getting many build warning about: 'bar_start' may be used uninitialized and 'bar_len' may be used uninitialized They are not actually uninitialized as dfx_get_bars() will initialize them properly. But still lets have them initialized just to satisfy the compiler. Signed-off-by: Sudip Mukherjee --- drivers/net/fddi/defxx.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/fddi/defxx.c b/drivers/net/fddi/defxx.c index 7f975a2..4113535 100644 --- a/drivers/net/fddi/defxx.c +++ b/drivers/net/fddi/defxx.c @@ -533,8 +533,8 @@ static int dfx_register(struct device *bdev) const char *print_name = dev_name(bdev); struct net_device *dev; DFX_board_t *bp; /* board pointer */ - resource_size_t bar_start[3]; /* pointers to ports */ - resource_size_t bar_len[3]; /* resource length */ + resource_size_t bar_start[3] = {0, 0, 0}; /* pointers to ports */ + resource_size_t bar_len[3] = {0, 0, 0}; /* resource length */ int alloc_size; /* total buffer size used */ struct resource *region; int err = 0; @@ -3697,8 +3697,8 @@ static void dfx_unregister(struct device *bdev) int dfx_bus_pci = dev_is_pci(bdev); int dfx_bus_tc = DFX_BUS_TC(bdev); int dfx_use_mmio = DFX_MMIO || dfx_bus_tc; - resource_size_t bar_start[3]; /* pointers to ports */ - resource_size_t bar_len[3]; /* resource lengths */ + resource_size_t bar_start[3] = {0, 0, 0}; /* pointers to ports */ + resource_size_t bar_len[3] = {0, 0, 0}; /* resource lengths */ int alloc_size; /* total buffer size used */ unregister_netdev(dev);