| Message ID | 1453702389-601-1-git-send-email-sudipm.mukherjee@gmail.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
Le 25/01/2016 07:13, Sudip Mukherjee a écrit : > We are getting build warning about: > macb.c:2889:13: warning: 'tx_clk' may be used uninitialized in this function > macb.c:2888:11: warning: 'hclk' may be used uninitialized in this function > > In reality they are not used uninitialized as clk_init() will initialize > them, this patch will just silence the warning. > > Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org> Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com> Thanks for your patch. Bye, > --- > drivers/net/ethernet/cadence/macb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/cadence/macb.c b/drivers/net/ethernet/cadence/macb.c > index 9d9984a..50c9410 100644 > --- a/drivers/net/ethernet/cadence/macb.c > +++ b/drivers/net/ethernet/cadence/macb.c > @@ -2823,7 +2823,7 @@ static int macb_probe(struct platform_device *pdev) > struct device_node *np = pdev->dev.of_node; > struct device_node *phy_node; > const struct macb_config *macb_config = NULL; > - struct clk *pclk, *hclk, *tx_clk; > + struct clk *pclk, *hclk = NULL, *tx_clk = NULL; > unsigned int queue_mask, num_queues; > struct macb_platform_data *pdata; > bool native_io; >
From: Sudip Mukherjee <sudipm.mukherjee@gmail.com> Date: Mon, 25 Jan 2016 11:43:09 +0530 > We are getting build warning about: > macb.c:2889:13: warning: 'tx_clk' may be used uninitialized in this function > macb.c:2888:11: warning: 'hclk' may be used uninitialized in this function > > In reality they are not used uninitialized as clk_init() will initialize > them, this patch will just silence the warning. > > Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org> Applied.
diff --git a/drivers/net/ethernet/cadence/macb.c b/drivers/net/ethernet/cadence/macb.c index 9d9984a..50c9410 100644 --- a/drivers/net/ethernet/cadence/macb.c +++ b/drivers/net/ethernet/cadence/macb.c @@ -2823,7 +2823,7 @@ static int macb_probe(struct platform_device *pdev) struct device_node *np = pdev->dev.of_node; struct device_node *phy_node; const struct macb_config *macb_config = NULL; - struct clk *pclk, *hclk, *tx_clk; + struct clk *pclk, *hclk = NULL, *tx_clk = NULL; unsigned int queue_mask, num_queues; struct macb_platform_data *pdata; bool native_io;
We are getting build warning about: macb.c:2889:13: warning: 'tx_clk' may be used uninitialized in this function macb.c:2888:11: warning: 'hclk' may be used uninitialized in this function In reality they are not used uninitialized as clk_init() will initialize them, this patch will just silence the warning. Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org> --- drivers/net/ethernet/cadence/macb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)