From patchwork Thu Jan 21 05:32:58 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wengang Wang X-Patchwork-Id: 571044 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 773481401CA for ; Thu, 21 Jan 2016 16:29:53 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751427AbcAUF3u (ORCPT ); Thu, 21 Jan 2016 00:29:50 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:16533 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750788AbcAUF3s (ORCPT ); Thu, 21 Jan 2016 00:29:48 -0500 Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id u0L5Th1d031866 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Thu, 21 Jan 2016 05:29:44 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userv0021.oracle.com (8.13.8/8.13.8) with ESMTP id u0L5ThWd006508 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Thu, 21 Jan 2016 05:29:43 GMT Received: from abhmp0009.oracle.com (abhmp0009.oracle.com [141.146.116.15]) by userv0121.oracle.com (8.13.8/8.13.8) with ESMTP id u0L5Thfc002224; Thu, 21 Jan 2016 05:29:43 GMT Received: from oracle.com (/10.182.64.160) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 20 Jan 2016 21:29:42 -0800 From: Wengang Wang To: netdev@vger.kernel.org Cc: wen.gang.wang@oracle.com, sd@queasysnail.net, jay.vosburgh@canonical.com, zyjzyj2000@gmail.com Subject: [PATCH] net: take care of bonding in build_skb_flow_key (v4) Date: Thu, 21 Jan 2016 13:32:58 +0800 Message-Id: <1453354378-3018-1-git-send-email-wen.gang.wang@oracle.com> X-Mailer: git-send-email 2.1.0 X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org In a bonding setting, we determines fragment size according to MTU and PMTU associated to the bonding master. If the slave finds the fragment size is too big, it drops the fragment and calls ip_rt_update_pmtu(), passing _skb_ and _pmtu_, trying to update the path MTU. Problem is that the target device that function ip_rt_update_pmtu actually tries to update is the slave (skb->dev), not the master. Thus since no PMTU change happens on master, the fragment size for later packets doesn't change so all later fragments/packets are dropped too. The fix is letting build_skb_flow_key() take care of the transition of device index from bonding slave to the master. That makes the master become the target device that ip_rt_update_pmtu tries to update PMTU to. Signed-off-by: Wengang Wang --- net/ipv4/route.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/net/ipv4/route.c b/net/ipv4/route.c index 85f184e..7e766b5 100644 --- a/net/ipv4/route.c +++ b/net/ipv4/route.c @@ -524,10 +524,19 @@ static void build_skb_flow_key(struct flowi4 *fl4, const struct sk_buff *skb, { const struct iphdr *iph = ip_hdr(skb); int oif = skb->dev->ifindex; + struct net_device *master; u8 tos = RT_TOS(iph->tos); u8 prot = iph->protocol; u32 mark = skb->mark; + if (netif_is_bond_slave(skb->dev)) { + rcu_read_lock(); + master = netdev_master_upper_dev_get_rcu(skb->dev); + if (master) + oif = master->ifindex; + rcu_read_unlock(); + } + __build_flow_key(fl4, sk, iph, oif, tos, prot, mark, 0); }