From patchwork Tue Jan 19 15:42:37 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?UTF-8?q?Jo=C3=A3o=20Paulo=20Rechi=20Vita?= X-Patchwork-Id: 570014 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 50D45140307 for ; Wed, 20 Jan 2016 02:44:36 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=UExIobJb; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756639AbcASPoY (ORCPT ); Tue, 19 Jan 2016 10:44:24 -0500 Received: from mail-qg0-f68.google.com ([209.85.192.68]:34162 "EHLO mail-qg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754881AbcASPoF (ORCPT ); Tue, 19 Jan 2016 10:44:05 -0500 Received: by mail-qg0-f68.google.com with SMTP id 94so65239741qgt.1; Tue, 19 Jan 2016 07:44:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=wZGzh8/V4kRlxbShu+U2aMhwVFLdnPc3i9eE5G8nHtM=; b=UExIobJb+f/e/h6EmbGZH2Fom/4ALM1PEbcXstwxQYqeFt4606kP75qSoKkksm1P73 8hS6wrJB9e5DhMpOHNs8QxVeY1OTslb1xdisLe1yGcciEC1w0mGwrMofRRElia5FULxR i7OONkF9rteta7IDgB8xE2iz/O0+KHvHAjeH3KuTdsALDgzUKOqMNrQCTThE35w043lA 51pqUFEh32dclsTtJHi1v4/JSc5NQ8mjV5Hp+Xykmdo4pysbsS0GBvZlOxUHZ/3tfced EbCO70qNhterSXPU7y5lbTwGI+dlYmlQxfLMu8YUFrAviTl+POBqPyviSKS5/ZnmoMOI HMng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-type:content-transfer-encoding; bh=wZGzh8/V4kRlxbShu+U2aMhwVFLdnPc3i9eE5G8nHtM=; b=KXXVAGystr1qJ1wH/lfM+JSKz7RkPY06zVnymY0HDzb7nN3qNeuxEM7dW0klyufUmS HYFjY2DAmNxfdeq4dHoPM0fxto386Sc36tcPbQV7HZVafv4+ZFOGckmM9oYc4BlCzI0C 60TPWXrG8xuXQ2iaTetX0ln6B5AriD4ylEdw/t/mUEVtUdh1uPE0NbTATppBue1EyLw7 EveOrogFG8vAgjqP1HNIzaJrs2HiUH9Q4zx4iQ2GrDraGvvmgGPTW+3t3yOQd/H9UFJE 1s19O7ySCQUwPy14Hbrm+S6ALmKbloKxZwO5/76QmfNaIOOVB7IhPMrrhQxVk8L6BSVZ m3Ow== X-Gm-Message-State: ALoCoQk98JivZXwbetE9gFYjsGpAfkFQV4GP505Zpj5u1TQGwFExSyEzWRpftqDsitchyCVAk1gJpattwenHfznFHkJrGXKo9w== X-Received: by 10.140.81.80 with SMTP id e74mr38535492qgd.27.1453218244954; Tue, 19 Jan 2016 07:44:04 -0800 (PST) Received: from localhost.localdomain (c-98-239-150-235.hsd1.wv.comcast.net. [98.239.150.235]) by smtp.gmail.com with ESMTPSA id z10sm12336759qhz.5.2016.01.19.07.44.04 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 19 Jan 2016 07:44:04 -0800 (PST) From: "=?UTF-8?q?Jo=C3=A3o=20Paulo=20Rechi=20Vita?=" X-Google-Original-From: =?UTF-8?q?Jo=C3=A3o=20Paulo=20Rechi=20Vita?= To: johannes@sipsolutions.net Cc: marcel@holtmann.org, linux-wireless@vger.kernel.org, davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, jprvita@endlessm.com, linux@endlessm.com Subject: [PATCH 2/8] rfkill: Improve code readability Date: Tue, 19 Jan 2016 10:42:37 -0500 Message-Id: <1453218163-31998-3-git-send-email-jprvita@endlessm.com> X-Mailer: git-send-email 2.5.0 In-Reply-To: <1453218163-31998-1-git-send-email-jprvita@endlessm.com> References: <1453218163-31998-1-git-send-email-jprvita@endlessm.com> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org RFKILL_BLOCK_SW value have just been saved to prev, no need to check it again in the if expression. This makes code a little bit easier to read. Signed-off-by: João Paulo Rechi Vita --- net/rfkill/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/rfkill/core.c b/net/rfkill/core.c index 4d6d726..838e869 100644 --- a/net/rfkill/core.c +++ b/net/rfkill/core.c @@ -285,7 +285,7 @@ static void rfkill_set_block(struct rfkill *rfkill, bool blocked) spin_lock_irqsave(&rfkill->lock, flags); prev = rfkill->state & RFKILL_BLOCK_SW; - if (rfkill->state & RFKILL_BLOCK_SW) + if (prev) rfkill->state |= RFKILL_BLOCK_SW_PREV; else rfkill->state &= ~RFKILL_BLOCK_SW_PREV;