From patchwork Thu Dec 17 12:15:53 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sudip Mukherjee X-Patchwork-Id: 558273 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 9BCB6140213 for ; Thu, 17 Dec 2015 23:16:24 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=W+VxYPFN; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755997AbbLQMQE (ORCPT ); Thu, 17 Dec 2015 07:16:04 -0500 Received: from mail-pa0-f44.google.com ([209.85.220.44]:34534 "EHLO mail-pa0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752659AbbLQMQC (ORCPT ); Thu, 17 Dec 2015 07:16:02 -0500 Received: by mail-pa0-f44.google.com with SMTP id wq6so41763709pac.1; Thu, 17 Dec 2015 04:16:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=TcAV480yzDKOI6yhRvSbBbTUFjk0TZT9xleRiMwpjag=; b=W+VxYPFNuuJf7JXmhITGjUiw/qNDq/LeluYM23Prhz4XWFdkWfbgyJ+03z61vmBPju Wi4MIS0zjLJ1vky/S9rixlJbdD2nSu4/mLD2leBPCJYVLFSw+JgatmI93WxhlKvpDb1X g1nTdla5dow2ciaaTmO7O93VJtyyF6AALsVfL7pfYFbvkLk8dFKHgd2z6ILNNfieUdKv /ZG+4XFezXXFMhqdYA/CaRiNJ6hgbdpTqSo6CtRzM7V8It3i5lC6/kRXnFjjZpHn9ysh pdIBe0DdnczPI+lL0ZdWagl3bXVWgH2zRs+JX+9RhTQtX0yUsMIkEjRxPJEssoF+bQtA NvEg== X-Received: by 10.66.222.101 with SMTP id ql5mr71713739pac.144.1450354561175; Thu, 17 Dec 2015 04:16:01 -0800 (PST) Received: from sudip-pc.vectortproxy.org ([49.206.205.82]) by smtp.gmail.com with ESMTPSA id ud10sm15588492pab.27.2015.12.17.04.15.58 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 17 Dec 2015 04:16:00 -0800 (PST) From: Sudip Mukherjee To: Nicolas Ferre Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Sudip Mukherjee , "David S . Miller" , Gregory CLEMENT Subject: [PATCH] net/macb: add proper header file Date: Thu, 17 Dec 2015 17:45:53 +0530 Message-Id: <1450354553-18745-1-git-send-email-sudipm.mukherjee@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org mips allmodconfig build fails with the error: drivers/net/ethernet/cadence/macb.c: In function 'macb_probe': drivers/net/ethernet/cadence/macb.c:2908:2: error: implicit declaration of function 'devm_gpiod_get_optional' [-Werror=implicit-function-declaration] bp->reset_gpio = devm_gpiod_get_optional(&bp->pdev->dev, "phy-reset", ^ drivers/net/ethernet/cadence/macb.c:2909:8: error: 'GPIOD_OUT_HIGH' undeclared (first use in this function) GPIOD_OUT_HIGH); ^ drivers/net/ethernet/cadence/macb.c:2909:8: note: each undeclared identifier is reported only once for each function it appears in drivers/net/ethernet/cadence/macb.c: In function 'macb_remove': drivers/net/ethernet/cadence/macb.c:2979:3: error: implicit declaration of function 'gpiod_set_value' [-Werror=implicit-function-declaration] gpiod_set_value(bp->reset_gpio, 0); ^ Add the proper header file to resolve it. Fixes: 5833e0526820 ("net/macb: add support for resetting PHY using GPIO") Cc: Gregory CLEMENT Signed-off-by: Sudip Mukherjee --- build log with next-20151217 is at: https://travis-ci.org/sudipm-mukherjee/parport/jobs/97388463 drivers/net/ethernet/cadence/macb.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/cadence/macb.c b/drivers/net/ethernet/cadence/macb.c index 0123646..988ee14 100644 --- a/drivers/net/ethernet/cadence/macb.c +++ b/drivers/net/ethernet/cadence/macb.c @@ -19,6 +19,7 @@ #include #include #include +#include #include #include #include