| Message ID | 1450354553-18745-1-git-send-email-sudipm.mukherjee@gmail.com |
|---|---|
| State | Not Applicable, archived |
| Delegated to: | David Miller |
| Headers | show |
Hi Sudip, On jeu., déc. 17 2015, Sudip Mukherjee <sudipm.mukherjee@gmail.com> wrote: > mips allmodconfig build fails with the error: > > drivers/net/ethernet/cadence/macb.c: In function 'macb_probe': > drivers/net/ethernet/cadence/macb.c:2908:2: error: implicit declaration of function 'devm_gpiod_get_optional' [-Werror=implicit-function-declaration] > bp->reset_gpio = devm_gpiod_get_optional(&bp->pdev->dev, "phy-reset", > ^ > drivers/net/ethernet/cadence/macb.c:2909:8: error: 'GPIOD_OUT_HIGH' undeclared (first use in this function) > GPIOD_OUT_HIGH); > ^ > drivers/net/ethernet/cadence/macb.c:2909:8: note: each undeclared identifier is reported only once for each function it appears in > drivers/net/ethernet/cadence/macb.c: In function 'macb_remove': > drivers/net/ethernet/cadence/macb.c:2979:3: error: implicit declaration of function 'gpiod_set_value' [-Werror=implicit-function-declaration] > gpiod_set_value(bp->reset_gpio, 0); > ^ > > Add the proper header file to resolve it. A proper fix already has been posted along with the proper device tree bindinsg too: http://marc.info/?l=linux-netdev&m=145034590619620&w=2 Thanks, Gregory > > Fixes: 5833e0526820 ("net/macb: add support for resetting PHY using GPIO") > Cc: Gregory CLEMENT <gregory.clement@free-electrons.com> > Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org> > --- > > build log with next-20151217 is at: > https://travis-ci.org/sudipm-mukherjee/parport/jobs/97388463 > > drivers/net/ethernet/cadence/macb.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/ethernet/cadence/macb.c b/drivers/net/ethernet/cadence/macb.c > index 0123646..988ee14 100644 > --- a/drivers/net/ethernet/cadence/macb.c > +++ b/drivers/net/ethernet/cadence/macb.c > @@ -19,6 +19,7 @@ > #include <linux/init.h> > #include <linux/io.h> > #include <linux/gpio.h> > +#include <linux/gpio/consumer.h> > #include <linux/interrupt.h> > #include <linux/netdevice.h> > #include <linux/etherdevice.h> > -- > 1.9.1 > > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
Le 17/12/2015 13:15, Sudip Mukherjee a écrit : > mips allmodconfig build fails with the error: > > drivers/net/ethernet/cadence/macb.c: In function 'macb_probe': > drivers/net/ethernet/cadence/macb.c:2908:2: error: implicit declaration of function 'devm_gpiod_get_optional' [-Werror=implicit-function-declaration] > bp->reset_gpio = devm_gpiod_get_optional(&bp->pdev->dev, "phy-reset", > ^ > drivers/net/ethernet/cadence/macb.c:2909:8: error: 'GPIOD_OUT_HIGH' undeclared (first use in this function) > GPIOD_OUT_HIGH); > ^ > drivers/net/ethernet/cadence/macb.c:2909:8: note: each undeclared identifier is reported only once for each function it appears in > drivers/net/ethernet/cadence/macb.c: In function 'macb_remove': > drivers/net/ethernet/cadence/macb.c:2979:3: error: implicit declaration of function 'gpiod_set_value' [-Werror=implicit-function-declaration] > gpiod_set_value(bp->reset_gpio, 0); > ^ > > Add the proper header file to resolve it. > > Fixes: 5833e0526820 ("net/macb: add support for resetting PHY using GPIO") > Cc: Gregory CLEMENT <gregory.clement@free-electrons.com> > Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org> This one is fixed and handled by Gregory here: http://lists.infradead.org/pipermail/linux-arm-kernel/2015-December/394433.html Thanks a lot anyay, bye, > --- > > build log with next-20151217 is at: > https://travis-ci.org/sudipm-mukherjee/parport/jobs/97388463 > > drivers/net/ethernet/cadence/macb.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/ethernet/cadence/macb.c b/drivers/net/ethernet/cadence/macb.c > index 0123646..988ee14 100644 > --- a/drivers/net/ethernet/cadence/macb.c > +++ b/drivers/net/ethernet/cadence/macb.c > @@ -19,6 +19,7 @@ > #include <linux/init.h> > #include <linux/io.h> > #include <linux/gpio.h> > +#include <linux/gpio/consumer.h> > #include <linux/interrupt.h> > #include <linux/netdevice.h> > #include <linux/etherdevice.h> >
On Thu, Dec 17, 2015 at 01:41:59PM +0100, Gregory CLEMENT wrote: > Hi Sudip, > > On jeu., déc. 17 2015, Sudip Mukherjee <sudipm.mukherjee@gmail.com> wrote: > > > mips allmodconfig build fails with the error: > > > > drivers/net/ethernet/cadence/macb.c: In function 'macb_probe': > > drivers/net/ethernet/cadence/macb.c:2908:2: error: implicit declaration of function 'devm_gpiod_get_optional' [-Werror=implicit-function-declaration] > > bp->reset_gpio = devm_gpiod_get_optional(&bp->pdev->dev, "phy-reset", > > ^ > > drivers/net/ethernet/cadence/macb.c:2909:8: error: 'GPIOD_OUT_HIGH' undeclared (first use in this function) > > GPIOD_OUT_HIGH); > > ^ > > drivers/net/ethernet/cadence/macb.c:2909:8: note: each undeclared identifier is reported only once for each function it appears in > > drivers/net/ethernet/cadence/macb.c: In function 'macb_remove': > > drivers/net/ethernet/cadence/macb.c:2979:3: error: implicit declaration of function 'gpiod_set_value' [-Werror=implicit-function-declaration] > > gpiod_set_value(bp->reset_gpio, 0); > > ^ > > > > Add the proper header file to resolve it. > > > A proper fix already has been posted along with the proper device tree > bindinsg too: > http://marc.info/?l=linux-netdev&m=145034590619620&w=2 Thanks, just compiled with it and the build error for which I posted this patch is now gone. regards sudip -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/ethernet/cadence/macb.c b/drivers/net/ethernet/cadence/macb.c index 0123646..988ee14 100644 --- a/drivers/net/ethernet/cadence/macb.c +++ b/drivers/net/ethernet/cadence/macb.c @@ -19,6 +19,7 @@ #include <linux/init.h> #include <linux/io.h> #include <linux/gpio.h> +#include <linux/gpio/consumer.h> #include <linux/interrupt.h> #include <linux/netdevice.h> #include <linux/etherdevice.h>
mips allmodconfig build fails with the error: drivers/net/ethernet/cadence/macb.c: In function 'macb_probe': drivers/net/ethernet/cadence/macb.c:2908:2: error: implicit declaration of function 'devm_gpiod_get_optional' [-Werror=implicit-function-declaration] bp->reset_gpio = devm_gpiod_get_optional(&bp->pdev->dev, "phy-reset", ^ drivers/net/ethernet/cadence/macb.c:2909:8: error: 'GPIOD_OUT_HIGH' undeclared (first use in this function) GPIOD_OUT_HIGH); ^ drivers/net/ethernet/cadence/macb.c:2909:8: note: each undeclared identifier is reported only once for each function it appears in drivers/net/ethernet/cadence/macb.c: In function 'macb_remove': drivers/net/ethernet/cadence/macb.c:2979:3: error: implicit declaration of function 'gpiod_set_value' [-Werror=implicit-function-declaration] gpiod_set_value(bp->reset_gpio, 0); ^ Add the proper header file to resolve it. Fixes: 5833e0526820 ("net/macb: add support for resetting PHY using GPIO") Cc: Gregory CLEMENT <gregory.clement@free-electrons.com> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org> --- build log with next-20151217 is at: https://travis-ci.org/sudipm-mukherjee/parport/jobs/97388463 drivers/net/ethernet/cadence/macb.c | 1 + 1 file changed, 1 insertion(+)