From patchwork Mon Nov 30 12:27:43 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marcin Wojtas X-Patchwork-Id: 549977 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id DB04C1401AF for ; Mon, 30 Nov 2015 23:28:49 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=semihalf-com.20150623.gappssmtp.com header.i=@semihalf-com.20150623.gappssmtp.com header.b=B/fEcMJJ; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754050AbbK3M1r (ORCPT ); Mon, 30 Nov 2015 07:27:47 -0500 Received: from mail-lf0-f45.google.com ([209.85.215.45]:33364 "EHLO mail-lf0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753288AbbK3M1o (ORCPT ); Mon, 30 Nov 2015 07:27:44 -0500 Received: by lfaz4 with SMTP id z4so194181094lfa.0 for ; Mon, 30 Nov 2015 04:27:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=ldwirp3J2a1Gd7QokcV3qvkSL/NOiaqMEkdPC/FjDOU=; b=B/fEcMJJc8KmE8lbhaEKtqTZWy/uFcFoeGBGIuXd6pl8Gvlm7P7TslRJREKp4oxVKK FOV6UdCwH0hRbw5x9o/hBPtwmN+xhoi75srAQVYx0A1P66CJr68fak/cIw6QtMC9KO55 U8H7Yw9UPyEnjEi9qsEySrW8Q+7rMpg2O1ZYfkBVH43kJzrrNdz1ERsyRMksqTLNBVOI bMTmvmlc8Tx7tbCB/lFZqEPmzI7P2H5MtK7+3llHdjqJjFnaSALpzGo7gNCtwoVKJshS FbOVnHhthZDH4gbC4ot78RC0mucedm7DhJgbwzxqq1wzO72glVXjFGbw2xnoZtVqdd5+ 00RA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=ldwirp3J2a1Gd7QokcV3qvkSL/NOiaqMEkdPC/FjDOU=; b=bbqLeKlq9a9bmO0IzhGh15N3LxvCc+jkxC8DQ7U/BFAiDwd2PvvbJpJ0+2O61tCegM Va91dqTvgaG4LGdnbkT5Vur1oWBdDCgt8t6Z3I4C0RrdeJQotFqYLf3vtxoI/r24++Ve SLtS4kfQYw/auN9ehStgyHUcz+4HQF9vip6OLqsIyeXO+C6pBjbHwITjTaT246kMGWr5 f8JF95exRtN5r4Xo392qYkjcPP/MlSRRggdlzCAqLj5/h1UkXM9FjEInLS0HWoOHt/Dx 1HF+MQ5tLeLBU2LQSEtbSQVDEwSgbpwWt0udNiz1eSibeP4Laon47QLk1yVaBEMfaNiD iVAQ== X-Gm-Message-State: ALoCoQkHGkE7hOK3ohjZKLicSZ6FdrZas5QclFY+AYSk4Ixubp2NjsqjeGwET/QWS3ikkiVfUa0v X-Received: by 10.112.25.40 with SMTP id z8mr25820388lbf.13.1448886463449; Mon, 30 Nov 2015 04:27:43 -0800 (PST) Received: from enkidu.semihalf.local ([80.82.22.190]) by smtp.gmail.com with ESMTPSA id l67sm7325249lfl.26.2015.11.30.04.27.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 30 Nov 2015 04:27:42 -0800 (PST) From: Marcin Wojtas To: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org Cc: davem@davemloft.net, linux@arm.linux.org.uk, sebastian.hesselbarth@gmail.com, andrew@lunn.ch, jason@lakedaemon.net, thomas.petazzoni@free-electrons.com, gregory.clement@free-electrons.com, simon.guinot@sequanux.org, nadavh@marvell.com, alior@marvell.com, xswang@marvell.com, myair@marvell.com, nitroshift@yahoo.com, mw@semihalf.com, jaz@semihalf.com, tn@semihalf.com Subject: [PATCH v4 net 3/6] net: mvneta: fix bit assignment for RX packet irq enable Date: Mon, 30 Nov 2015 13:27:43 +0100 Message-Id: <1448886466-31538-4-git-send-email-mw@semihalf.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1448886466-31538-1-git-send-email-mw@semihalf.com> References: <1448886466-31538-1-git-send-email-mw@semihalf.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org A value originally defined in the driver was inappropriate. Even though the ingress was somehow working, writing MVNETA_RXQ_INTR_ENABLE_ALL_MASK to MVNETA_INTR_ENABLE didn't make any effect, because the bits [31:16] are reserved and read-only. This commit updates MVNETA_RXQ_INTR_ENABLE_ALL_MASK to be compliant with the controller's documentation. Signed-off-by: Marcin Wojtas Fixes: c5aff18204da ("net: mvneta: driver for Marvell Armada 370/XP network unit") --- drivers/net/ethernet/marvell/mvneta.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c index 64c46f0..5dffb68 100644 --- a/drivers/net/ethernet/marvell/mvneta.c +++ b/drivers/net/ethernet/marvell/mvneta.c @@ -160,7 +160,7 @@ #define MVNETA_INTR_ENABLE 0x25b8 #define MVNETA_TXQ_INTR_ENABLE_ALL_MASK 0x0000ff00 -#define MVNETA_RXQ_INTR_ENABLE_ALL_MASK 0xff000000 // note: neta says it's 0x000000FF +#define MVNETA_RXQ_INTR_ENABLE_ALL_MASK 0x000000ff #define MVNETA_RXQ_CMD 0x2680 #define MVNETA_RXQ_DISABLE_SHIFT 8