From patchwork Mon Nov 30 12:27:42 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marcin Wojtas X-Patchwork-Id: 549978 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id ECC851401AF for ; Mon, 30 Nov 2015 23:28:57 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=semihalf-com.20150623.gappssmtp.com header.i=@semihalf-com.20150623.gappssmtp.com header.b=cmsmih7D; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754133AbbK3M2y (ORCPT ); Mon, 30 Nov 2015 07:28:54 -0500 Received: from mail-lf0-f43.google.com ([209.85.215.43]:34867 "EHLO mail-lf0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754021AbbK3M1n (ORCPT ); Mon, 30 Nov 2015 07:27:43 -0500 Received: by lfdl133 with SMTP id l133so193328319lfd.2 for ; Mon, 30 Nov 2015 04:27:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=vw6MdU/KrIB1EpAqv4fMg/7qeavg1yt+BasdtGU6gmI=; b=cmsmih7D8ByjMJLJk+Bbp/0LzPy5mgkvzSrLEfKd7JyeDK1kAMQ9nUqcdbrI+ddMTn h8jz5zYc+1nem9eYBQFp4lp+Gf1xh3byFOGUMKmRHnTxtMkti72LQvnC4ZT12z2f33AN 5UHfnxW4Gx1mNADMyXUfKis1DbkYvu5QWfH6d4umYYAh+V1reM03ohT9WEUSYaOg9nUh G/U3d32li76bqBIxmz/tvyFPAn3btojzchZCOF4AnHcTDWa8iu6yCaMI3FhDuhfWWZEL TZFtJpt20WvVAcbv8SHnlxsZ5P7A66T879lEbzOiswQRoje2N8u67NgJfTpErVSF6LLk 22sQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=vw6MdU/KrIB1EpAqv4fMg/7qeavg1yt+BasdtGU6gmI=; b=NYqsIZ3nOSR1n78UYEfCShIHOV5745qXGqJ9NOofncFLYrOO1e63zlriIwpIMwSEWt fJ2SOjPcmF7ELRAjNVzr8i1nXj/jr+ZbO341GhO4XssYgGoFPGR5y3dhwnsh3Z1BZG20 FYLHnvEtmbzvmPD63dEvszEiDhr9Qi18yxFKQcDrXa6EFHMJLQzZCzAx1Dcx/YOAoPjY Q7ZGgZEa6JSIsmyIXXqQ1OuC8Kuy7Ci1ETwYbbCDyCGdx9mqNWR+4adDF+AX0vsoJKao G4xwmS/NHGISu2+LxtltF3QTeRB5T4SgXgnyUScaKQ//Ad8C+WFcCVOAcXmc5Y549gNX cfPw== X-Gm-Message-State: ALoCoQnK5DIx63OQQKe8xR0TgwJjLj9D6a1RFO8aTgFeAlkGZQ2uTDDpkQyTtrC1xe8zBHJf5Vu6 X-Received: by 10.112.130.138 with SMTP id oe10mr25365398lbb.54.1448886462074; Mon, 30 Nov 2015 04:27:42 -0800 (PST) Received: from enkidu.semihalf.local ([80.82.22.190]) by smtp.gmail.com with ESMTPSA id l67sm7325249lfl.26.2015.11.30.04.27.40 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 30 Nov 2015 04:27:41 -0800 (PST) From: Marcin Wojtas To: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org Cc: davem@davemloft.net, linux@arm.linux.org.uk, sebastian.hesselbarth@gmail.com, andrew@lunn.ch, jason@lakedaemon.net, thomas.petazzoni@free-electrons.com, gregory.clement@free-electrons.com, simon.guinot@sequanux.org, nadavh@marvell.com, alior@marvell.com, xswang@marvell.com, myair@marvell.com, nitroshift@yahoo.com, mw@semihalf.com, jaz@semihalf.com, tn@semihalf.com Subject: [PATCH v4 net 2/6] net: mvneta: fix bit assignment in MVNETA_RXQ_CONFIG_REG Date: Mon, 30 Nov 2015 13:27:42 +0100 Message-Id: <1448886466-31538-3-git-send-email-mw@semihalf.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1448886466-31538-1-git-send-email-mw@semihalf.com> References: <1448886466-31538-1-git-send-email-mw@semihalf.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org MVNETA_RXQ_HW_BUF_ALLOC bit which controls enabling hardware buffer allocation was mistakenly set as BIT(1). This commit fixes the assignment. Signed-off-by: Marcin Wojtas Reviewed-by: Gregory CLEMENT Fixes: c5aff18204da ("net: mvneta: driver for Marvell Armada 370/XP network unit") --- drivers/net/ethernet/marvell/mvneta.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c index 2d80256..64c46f0 100644 --- a/drivers/net/ethernet/marvell/mvneta.c +++ b/drivers/net/ethernet/marvell/mvneta.c @@ -36,7 +36,7 @@ /* Registers */ #define MVNETA_RXQ_CONFIG_REG(q) (0x1400 + ((q) << 2)) -#define MVNETA_RXQ_HW_BUF_ALLOC BIT(1) +#define MVNETA_RXQ_HW_BUF_ALLOC BIT(0) #define MVNETA_RXQ_PKT_OFFSET_ALL_MASK (0xf << 8) #define MVNETA_RXQ_PKT_OFFSET_MASK(offs) ((offs) << 8) #define MVNETA_RXQ_THRESHOLD_REG(q) (0x14c0 + ((q) << 2))