| Message ID | 1448178839-3541-11-git-send-email-mw@semihalf.com |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
Hello. On 11/22/2015 10:53 AM, Marcin Wojtas wrote: > Armada 38x network controller supports hardware buffer management (BM). > Since it is now enabled in mvneta driver, appropriate nodes can be added > to armada-38x.dtsi - for the actual common BM unit (bm@c8000) and its > internal SRAM (bm-bppi), which is used for indirect access to buffer > pointer ring residing in DRAM. > > Pools - ports mapping, bm-bppi entry in 'soc' node's ranges and optional > parameters are supposed to be set in board files. > > Signed-off-by: Marcin Wojtas <mw@semihalf.com> > --- > arch/arm/boot/dts/armada-38x.dtsi | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > > diff --git a/arch/arm/boot/dts/armada-38x.dtsi b/arch/arm/boot/dts/armada-38x.dtsi > index b7868b2..b9f4ce2 100644 > --- a/arch/arm/boot/dts/armada-38x.dtsi > +++ b/arch/arm/boot/dts/armada-38x.dtsi > @@ -539,6 +539,14 @@ > status = "disabled"; > }; > > + bm: bm@c8000 { The ePAPR standard tells us to give generic names to the device nodes, hence this should be named "buffer-manager" (?). [...] > @@ -617,6 +625,16 @@ > #size-cells = <1>; > ranges = <0 MBUS_ID(0x09, 0x15) 0 0x800>; > }; > + > + bm_bppi: bm-bppi { And this one "memory" (?). [...] MBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/boot/dts/armada-38x.dtsi b/arch/arm/boot/dts/armada-38x.dtsi index b7868b2..b9f4ce2 100644 --- a/arch/arm/boot/dts/armada-38x.dtsi +++ b/arch/arm/boot/dts/armada-38x.dtsi @@ -539,6 +539,14 @@ status = "disabled"; }; + bm: bm@c8000 { + compatible = "marvell,armada-380-neta-bm"; + reg = <0xc8000 0xac>; + clocks = <&gateclk 13>; + internal-mem = <&bm_bppi>; + status = "disabled"; + }; + sata@e0000 { compatible = "marvell,armada-380-ahci"; reg = <0xe0000 0x2000>; @@ -617,6 +625,16 @@ #size-cells = <1>; ranges = <0 MBUS_ID(0x09, 0x15) 0 0x800>; }; + + bm_bppi: bm-bppi { + compatible = "mmio-sram"; + reg = <MBUS_ID(0x0c, 0x04) 0 0x100000>; + ranges = <0 MBUS_ID(0x0c, 0x04) 0 0x100000>; + #address-cells = <1>; + #size-cells = <1>; + clocks = <&gateclk 13>; + status = "disabled"; + }; }; clocks {
Armada 38x network controller supports hardware buffer management (BM). Since it is now enabled in mvneta driver, appropriate nodes can be added to armada-38x.dtsi - for the actual common BM unit (bm@c8000) and its internal SRAM (bm-bppi), which is used for indirect access to buffer pointer ring residing in DRAM. Pools - ports mapping, bm-bppi entry in 'soc' node's ranges and optional parameters are supposed to be set in board files. Signed-off-by: Marcin Wojtas <mw@semihalf.com> --- arch/arm/boot/dts/armada-38x.dtsi | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+)