From patchwork Sun Nov 8 22:02:50 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Hurley X-Patchwork-Id: 541498 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 50F2B1413F5 for ; Mon, 9 Nov 2015 09:03:55 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=hurleysoftware_com.20150623.gappssmtp.com header.i=@hurleysoftware_com.20150623.gappssmtp.com header.b=eU6jZov8; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751835AbbKHWDR (ORCPT ); Sun, 8 Nov 2015 17:03:17 -0500 Received: from mail-ig0-f182.google.com ([209.85.213.182]:38816 "EHLO mail-ig0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751379AbbKHWDL (ORCPT ); Sun, 8 Nov 2015 17:03:11 -0500 Received: by igbxm8 with SMTP id xm8so40961514igb.1 for ; Sun, 08 Nov 2015 14:03:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hurleysoftware_com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=FMlY2alW6F5bZJ3Ngh3n5pqhARnnGBtoG1jj0zw4JEw=; b=eU6jZov8bSCEYbJWRippH4f0EymRHEyygiHk6djeV7yN2vkfntIdYihcD07jkp399C fLIYMoL15o2NDu/vVpDa+D20TRkeVoSEFuAn7V0A4WyLfytUhtsTznPw3mH+LIjjcles Lz7aluuTHYhUFgRvzS7kQhcBM9RFNW0APhjeivbiPdEb/My5q68iX888xoEbljdkjll2 u/vR2+M74PkmF9oBuepSu9qQmxjaR/1I20+u/nCM1TNs4WkrOXD/81k8SJmae1MSKZms JiSEP2zEcEhSqedwlT3L7t7ufqk08WK7ALChEX1dLqzjhCNcV8wgZTUCdrg4WEuEOG03 pijQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=FMlY2alW6F5bZJ3Ngh3n5pqhARnnGBtoG1jj0zw4JEw=; b=f98DJI49Cg79+MZcnKxnnmfvybnAqU1F9IVm0XTWnndDoJA1HdCHEL4YBz2lgdDFnQ 1UiCzfwa74okauGrMuoA+l6Hup5Hu1jpp7xS+DOkPx6l4Ivx64LnfN6vrWXgwjDnhgJ7 OzN4aCFOD5KCpVi76cGFLCsYZeQuR+UZH65eafK0GkpVFwGvyhhuLp74X5LrMW4G3pS+ Dy1XKTH/JKQn0/VDr2Cr/FnjEjMeWzx7ikXuMzj5lnQBEojuZAuZMNmQ5czq3XQmyEJx vqY6jDFNCuNPNAXxJIgO3XNrYlxJcVru7Few+Zb2FBMsuNYkcLo/JzcoOQiJsijbkMyJ f3NQ== X-Gm-Message-State: ALoCoQkBxg/R5BCs2hwrmbS/e9VMj/ouZv5LYhPflp2Jr+EJvOsoRIyklIxyxyIaYnKa57VbgbkW X-Received: by 10.50.57.44 with SMTP id f12mr17558231igq.29.1447020189053; Sun, 08 Nov 2015 14:03:09 -0800 (PST) Received: from thor.lan (cpe-76-190-194-55.neo.res.rr.com. [76.190.194.55]) by smtp.gmail.com with ESMTPSA id m29sm4413795iod.38.2015.11.08.14.03.07 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sun, 08 Nov 2015 14:03:08 -0800 (PST) From: Peter Hurley To: Greg Kroah-Hartman Cc: Jiri Slaby , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, netdev@vger.kernel.org, Karsten Keil , Martin Schwidefsky , Heiko Carstens , Jesper Nilsson , Mikael Starvik , Jiri Kosina , David Sterba , Mark Hounschell , Peter Hurley Subject: [PATCH 1/4] tty: rocket: Remove private close_wait Date: Sun, 8 Nov 2015 17:02:50 -0500 Message-Id: <1447020173-32207-2-git-send-email-peter@hurleysoftware.com> X-Mailer: git-send-email 2.6.3 In-Reply-To: <1447020173-32207-1-git-send-email-peter@hurleysoftware.com> References: <1447020173-32207-1-git-send-email-peter@hurleysoftware.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This driver's private completion variable, close_wait, is no longer used for wait since "tty: Remove ASYNC_CLOSING checks in open()/hangup"; remove. Signed-off-by: Peter Hurley --- drivers/tty/rocket.c | 2 -- drivers/tty/rocket_int.h | 1 - 2 files changed, 3 deletions(-) diff --git a/drivers/tty/rocket.c b/drivers/tty/rocket.c index 802eac7..c5179f8 100644 --- a/drivers/tty/rocket.c +++ b/drivers/tty/rocket.c @@ -643,7 +643,6 @@ static void init_r_port(int board, int aiop, int chan, struct pci_dev *pci_dev) info->chan = chan; tty_port_init(&info->port); info->port.ops = &rocket_port_ops; - init_completion(&info->close_wait); info->flags &= ~ROCKET_MODE_MASK; switch (pc104[board][line]) { case 422: @@ -1049,7 +1048,6 @@ static void rp_close(struct tty_struct *tty, struct file *filp) mutex_unlock(&port->mutex); tty_port_tty_set(port, NULL); - complete_all(&info->close_wait); atomic_dec(&rp_num_ports_open); #ifdef ROCKET_DEBUG_OPEN diff --git a/drivers/tty/rocket_int.h b/drivers/tty/rocket_int.h index 67e0f1e..ef1e1be 100644 --- a/drivers/tty/rocket_int.h +++ b/drivers/tty/rocket_int.h @@ -1144,7 +1144,6 @@ struct r_port { int read_status_mask; int cps; - struct completion close_wait; /* Not yet matching the core */ spinlock_t slock; struct mutex write_mtx; };