From patchwork Sat Nov 7 05:34:54 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yang Shi X-Patchwork-Id: 541217 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id BAD34140B0F for ; Sat, 7 Nov 2015 16:54:06 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=linaro_org.20150623.gappssmtp.com header.i=@linaro_org.20150623.gappssmtp.com header.b=1Vukdc8G; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750865AbbKGFxR (ORCPT ); Sat, 7 Nov 2015 00:53:17 -0500 Received: from mail-pa0-f46.google.com ([209.85.220.46]:35033 "EHLO mail-pa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750787AbbKGFxP (ORCPT ); Sat, 7 Nov 2015 00:53:15 -0500 Received: by pasz6 with SMTP id z6so147750189pas.2 for ; Fri, 06 Nov 2015 21:53:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro_org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=m7oZ07+YjmqeUpNb/f4RYFzvAJUDpfK0KLPkxw0KSh4=; b=1Vukdc8G6SX446ODeG6/G2bKWUhcZjTw9QwTj42oAA0t6mcjniyxMBgezfycfeAB+P wE03sIO1kE7geDqMn7sExGafoJrPCbYhE0b1HPrVtIp71+P4+TKcybDgR5v3e/AeGkk5 mA3kGEnDKFYrXsvTgRBbxeeD/ayJQSAVjOoKLRwHaLVaoq4RsH9gY+mmGdooYWshYHQc G9swEccXUrA/rkpoVAoz4q+rEiogoT3cjIvscL6Et+eQgZVq457AfI0HLiT2LObyhah/ SU/v+An2eIHNEfyHAhVRyRfu2Kz7BXf64U5suHhjF5sQjuS6s8OIwzXhPDy/uuakrt4W dHng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=m7oZ07+YjmqeUpNb/f4RYFzvAJUDpfK0KLPkxw0KSh4=; b=aEmjbgVXMqZA6BJSOMXBGCcoOWci7cBE2Mj3q1dauF/G3A496tcDn/vjOJJzbGjAMi tWxX3dH/t339kdcR7fgCDyFUETO21jIdiZIPibXvbhfKOjw06DdEm/cAjMlpnFS0wNHD GWmtC58kFzL9NBcjIFmUyRCOCLRpRBAf9f/BeXGSPlIZ5aZ90O7K3qkvt31vcoe2XZyT mE75bE8fY89ROfpLjsWGEKCumXyuug2TTYEVHy7Ssll9VdGBv91SwDe09wKBR9v2YXBG sYZgzdaVTUh6EQS6a2PI0CJxc/EULevAlUU7EXitK1WKhAbYLyA1BOGMNJt/sikclKrA oGhQ== X-Gm-Message-State: ALoCoQmBESOxsUjDE2/Rs58uuJ6NLMjjfpZZSJ7i1TRdT4fghoQaVTcKclG9O5AK/E59vzdjDWTU X-Received: by 10.67.8.40 with SMTP id dh8mr23082752pad.121.1446875595324; Fri, 06 Nov 2015 21:53:15 -0800 (PST) Received: from yshi-Precision-T5600.corp.ad.wrs.com (unknown-216-82.windriver.com. [147.11.216.82]) by smtp.gmail.com with ESMTPSA id bs3sm3315082pbd.89.2015.11.06.21.53.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 06 Nov 2015 21:53:14 -0800 (PST) From: Yang Shi To: ast@kernel.org, daniel@iogearbox.net, catalin.marinas@arm.com, will.deacon@arm.com Cc: zlim.lnx@gmail.com, xi.wang@gmail.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linaro-kernel@lists.linaro.org, yang.shi@linaro.org Subject: [PATCH] arm64: bpf: fix JIT stack setup Date: Fri, 6 Nov 2015 21:34:54 -0800 Message-Id: <1446874494-14500-1-git-send-email-yang.shi@linaro.org> X-Mailer: git-send-email 2.0.2 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org ARM64 JIT used FP (x29) as eBPF fp register, but FP is subjected to change during function call so it may cause the BPF prog stack base address change too. Whenever, it pointed to the bottom of BPF prog stack instead of the top. So, when copying data via bpf_probe_read, it will be copied to (SP - offset), then it may overwrite the saved FP/LR. Use x25 to replace FP as BPF stack base register (fp). Since x25 is callee saved register, so it will keep intact during function call. It is initialized in BPF prog prologue when BPF prog is started to run everytime. When BPF prog exits, it could be just tossed. Other than this the BPf prog stack base need to be setup before function call stack. So, the BPF stack layout looks like: high original A64_SP => 0:+-----+ BPF prologue | | FP/LR and callee saved registers BPF fp register => +64:+-----+ | | | ... | BPF prog stack | | | | current A64_SP => +-----+ | | | ... | Function call stack | | +-----+ low Signed-off-by: Yang Shi CC: Zi Shen Lim CC: Xi Wang --- arch/arm64/net/bpf_jit_comp.c | 38 +++++++++++++++++++++++++++++++------- 1 file changed, 31 insertions(+), 7 deletions(-) diff --git a/arch/arm64/net/bpf_jit_comp.c b/arch/arm64/net/bpf_jit_comp.c index a44e529..6809647 100644 --- a/arch/arm64/net/bpf_jit_comp.c +++ b/arch/arm64/net/bpf_jit_comp.c @@ -50,7 +50,7 @@ static const int bpf2a64[] = { [BPF_REG_8] = A64_R(21), [BPF_REG_9] = A64_R(22), /* read-only frame pointer to access stack */ - [BPF_REG_FP] = A64_FP, + [BPF_REG_FP] = A64_R(25), /* temporary register for internal BPF JIT */ [TMP_REG_1] = A64_R(23), [TMP_REG_2] = A64_R(24), @@ -155,18 +155,42 @@ static void build_prologue(struct jit_ctx *ctx) stack_size += 4; /* extra for skb_copy_bits buffer */ stack_size = STACK_ALIGN(stack_size); + /* + * BPF prog stack layout + * + * high + * original A64_SP => 0:+-----+ BPF prologue + * | | FP/LR and callee saved registers + * BPF fp register => +64:+-----+ + * | | + * | ... | BPF prog stack + * | | + * | | + * current A64_SP => +-----+ + * | | + * | ... | Function call stack + * | | + * +-----+ + * low + * + */ + + /* Save FP and LR registers to stay align with ARM64 AAPCS */ + emit(A64_PUSH(A64_FP, A64_LR, A64_SP), ctx); + /* Save callee-saved register */ emit(A64_PUSH(r6, r7, A64_SP), ctx); emit(A64_PUSH(r8, r9, A64_SP), ctx); if (ctx->tmp_used) emit(A64_PUSH(tmp1, tmp2, A64_SP), ctx); - /* Set up BPF stack */ - emit(A64_SUB_I(1, A64_SP, A64_SP, stack_size), ctx); - - /* Set up frame pointer */ + /* Set up BPF prog stack base register (x25) */ emit(A64_MOV(1, fp, A64_SP), ctx); + /* Set up function call stack */ + emit(A64_SUB_I(1, A64_SP, A64_SP, stack_size), ctx); + emit(A64_MOV(1, A64_FP, A64_SP), ctx); + /* Clear registers A and X */ emit_a64_mov_i64(ra, 0, ctx); emit_a64_mov_i64(rx, 0, ctx); @@ -196,8 +220,8 @@ static void build_epilogue(struct jit_ctx *ctx) emit(A64_POP(r8, r9, A64_SP), ctx); emit(A64_POP(r6, r7, A64_SP), ctx); - /* Restore frame pointer */ - emit(A64_MOV(1, fp, A64_SP), ctx); + /* Restore FP/LR registers */ + emit(A64_POP(A64_FP, A64_LR, A64_SP), ctx); /* Set return value */ emit(A64_MOV(1, A64_R(0), r0), ctx);