From patchwork Fri Nov 6 19:35:44 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Dmitry Safonov <0x7f454c46@gmail.com> X-Patchwork-Id: 541088 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id DF0D31402B4 for ; Sat, 7 Nov 2015 06:35:24 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=Xo+EvSj1; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161910AbbKFTe7 (ORCPT ); Fri, 6 Nov 2015 14:34:59 -0500 Received: from mail-wi0-f171.google.com ([209.85.212.171]:36287 "EHLO mail-wi0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1032012AbbKFTe5 (ORCPT ); Fri, 6 Nov 2015 14:34:57 -0500 Received: by wimw2 with SMTP id w2so36662911wim.1; Fri, 06 Nov 2015 11:34:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=v2mpeCuJMEL9kNsAbqsoswwPoJ5vpGPko5X6EnZm5rM=; b=Xo+EvSj1ZWx5Hc2C1cS5oUvDcgUaZis58TjxnPKSHggBTAn7rv1TR43nJtuFaAHNMI Nuthr15WqPiVudIXN2SQCn+dgvFNAo/I1v/Ywvz7MzN6MObZJZoWf9QPnhkF+KW5uk9u hAc/n2xmW25KPZYeWK90DOLPaodvuqu/5vy6X1IkUZ0FLlV7J3jxwQ2SBOAuqYA2Iu9U oz7iiUE2wdga1YDhi1Adkqv5bpqlFip0qeO5RIG+Ck7JQP6PbKR/+uRk5xeqtklJPP1Z B1Tj5F2v0kI/JBqt/LXkDQunQKGzE+bdWnBvtOo1faGEVTs0aGjbQIg1C3Vvk1EEgsy8 gAsA== X-Received: by 10.194.235.101 with SMTP id ul5mr17080547wjc.107.1446838496245; Fri, 06 Nov 2015 11:34:56 -0800 (PST) Received: from safonovpc.rnd.samsung.ru (kaputte.li. [194.150.168.95]) by smtp.gmail.com with ESMTPSA id l1sm1566042wjx.13.2015.11.06.11.34.52 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 06 Nov 2015 11:34:55 -0800 (PST) From: Dmitry Safonov <0x7f454c46@gmail.com> To: pablo@netfilter.org, kaber@trash.net, kadlec@blackhole.kfki.hu, davem@davemloft.net Cc: netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Dmitry Safonov <0x7f454c46@gmail.com> Subject: [PATCH] net: netfilter: fix false positive GCC warnings Date: Fri, 6 Nov 2015 22:35:44 +0300 Message-Id: <1446838544-30487-1-git-send-email-0x7f454c46@gmail.com> X-Mailer: git-send-email 2.6.2 In-Reply-To: <20151106190705.GA20345@breakpoint.cc> References: <20151106190705.GA20345@breakpoint.cc> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org With x86_64_defconfig: GCC thinks that in nfulnl_recv_config flags parameter is not inited but it was under the same condition (nfula[NFULA_CFG_FLAGS] == true). Suppress this warning: net/netfilter/nfnetlink_log.c: In function ‘nfulnl_recv_config’: net/netfilter/nfnetlink_log.c:320:14: warning: ‘flags’ may be used uninitialized in this function [-Wmaybe-uninitialized] inst->flags = flags; ^ GCC thinks that nfnl_ct wasn't inited, but it is used only under if (ct && diff) where ct is not NULL only when nfnl_ct is inited. Reported-by: Florian Westphal Signed-off-by: Dmitry Safonov <0x7f454c46@gmail.com> --- net/netfilter/nfnetlink_log.c | 2 +- net/netfilter/nfnetlink_queue.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/net/netfilter/nfnetlink_log.c b/net/netfilter/nfnetlink_log.c index 06eb48fceb42e4..23f16b99e6388a 100644 --- a/net/netfilter/nfnetlink_log.c +++ b/net/netfilter/nfnetlink_log.c @@ -825,7 +825,7 @@ nfulnl_recv_config(struct sock *ctnl, struct sk_buff *skb, struct net *net = sock_net(ctnl); struct nfnl_log_net *log = nfnl_log_pernet(net); int ret = 0; - u16 flags; + u16 uninitialized_var(flags); if (nfula[NFULA_CFG_CMD]) { u_int8_t pf = nfmsg->nfgen_family; diff --git a/net/netfilter/nfnetlink_queue.c b/net/netfilter/nfnetlink_queue.c index 7d81d280cb4ff3..66b006112921ca 100644 --- a/net/netfilter/nfnetlink_queue.c +++ b/net/netfilter/nfnetlink_queue.c @@ -313,7 +313,7 @@ nfqnl_build_packet_message(struct net *net, struct nfqnl_instance *queue, struct net_device *outdev; struct nf_conn *ct = NULL; enum ip_conntrack_info uninitialized_var(ctinfo); - struct nfnl_ct_hook *nfnl_ct; + struct nfnl_ct_hook *uninitialized_var(nfnl_ct); bool csum_verify; char *secdata = NULL; u32 seclen = 0; @@ -1041,7 +1041,7 @@ nfqnl_recv_verdict(struct sock *ctnl, struct sk_buff *skb, unsigned int verdict; struct nf_queue_entry *entry; enum ip_conntrack_info uninitialized_var(ctinfo); - struct nfnl_ct_hook *nfnl_ct; + struct nfnl_ct_hook *uninitialized_var(nfnl_ct); struct nf_conn *ct = NULL; struct net *net = sock_net(ctnl);