From patchwork Fri Nov 6 18:48:14 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Dmitry Safonov <0x7f454c46@gmail.com> X-Patchwork-Id: 541080 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 13263140787 for ; Sat, 7 Nov 2015 05:47:11 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=MP3xaO0a; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756216AbbKFSqw (ORCPT ); Fri, 6 Nov 2015 13:46:52 -0500 Received: from mail-wi0-f180.google.com ([209.85.212.180]:35043 "EHLO mail-wi0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751870AbbKFSqv (ORCPT ); Fri, 6 Nov 2015 13:46:51 -0500 Received: by wicll6 with SMTP id ll6so35743646wic.0; Fri, 06 Nov 2015 10:46:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:mime-version:content-type :content-transfer-encoding; bh=kp3O/BLo07QqEch88EkG74WnKjTdASEZ/kTUxexrGuI=; b=MP3xaO0al6kBFQp+YDYc8EO8dQYLDb1EpvMSdU0pT8PytdAFduQFm2pcUdBkCP98ta uFlctiq694SXlNsV851O6bGXvd2GhaK7a0DjeiM6seoaOYXInWKqMEoIKwkntxc9AMVD CYOpg0NgjsRvndJ5rEH6urtiY6K2NXvXQRPtnnVTBbQnjsdEWqPsEgoDtMS0TDit+/Jy ybLIlPcwaMqZfgdA2vsOmk0nYW91fUBM09bKCQILMoHJBIEWiblUdbr9KYmGq+gOaK9M +XoCM2+K7LIs+9NGETeH2VP+o48U0M0al1013TejcuZpsB3MNctMyGujFgBdz8I9ymwX 4/mA== X-Received: by 10.194.203.106 with SMTP id kp10mr16696054wjc.86.1446835610024; Fri, 06 Nov 2015 10:46:50 -0800 (PST) Received: from safonovpc.rnd.samsung.ru (atlantic480.us.unmetered.com. [188.138.9.49]) by smtp.gmail.com with ESMTPSA id om1sm1416558wjc.2.2015.11.06.10.46.47 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 06 Nov 2015 10:46:49 -0800 (PST) From: Dmitry Safonov <0x7f454c46@gmail.com> To: pablo@netfilter.org, kaber@trash.net, kadlec@blackhole.kfki.hu, davem@davemloft.net Cc: netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Dmitry Safonov <0x7f454c46@gmail.com> Subject: [PATCH] net: netfilter: fix GCC uninitialized warning Date: Fri, 6 Nov 2015 21:48:14 +0300 Message-Id: <1446835694-6967-1-git-send-email-0x7f454c46@gmail.com> X-Mailer: git-send-email 2.6.2 MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org With x86_64_defconfig: GCC thinks that in nfulnl_recv_config flags parameter is not inited but it was under the same condition (nfula[NFULA_CFG_FLAGS] == true). Suppress this warning: net/netfilter/nfnetlink_log.c: In function ‘nfulnl_recv_config’: net/netfilter/nfnetlink_log.c:320:14: warning: ‘flags’ may be used uninitialized in this function [-Wmaybe-uninitialized] inst->flags = flags; ^ Signed-off-by: Dmitry Safonov <0x7f454c46@gmail.com> --- net/netfilter/nfnetlink_log.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/netfilter/nfnetlink_log.c b/net/netfilter/nfnetlink_log.c index 06eb48fceb42e4..d65f3b987b7f13 100644 --- a/net/netfilter/nfnetlink_log.c +++ b/net/netfilter/nfnetlink_log.c @@ -825,7 +825,7 @@ nfulnl_recv_config(struct sock *ctnl, struct sk_buff *skb, struct net *net = sock_net(ctnl); struct nfnl_log_net *log = nfnl_log_pernet(net); int ret = 0; - u16 flags; + u16 flags = 0; /* GCC uninitialized */ if (nfula[NFULA_CFG_CMD]) { u_int8_t pf = nfmsg->nfgen_family;