From patchwork Wed Oct 28 12:20:30 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Estevam X-Patchwork-Id: 537316 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id E3B2B140549 for ; Wed, 28 Oct 2015 23:20:47 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=g1jTokZo; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755888AbbJ1MUm (ORCPT ); Wed, 28 Oct 2015 08:20:42 -0400 Received: from mail-vk0-f52.google.com ([209.85.213.52]:35717 "EHLO mail-vk0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755868AbbJ1MUl (ORCPT ); Wed, 28 Oct 2015 08:20:41 -0400 Received: by vkfw189 with SMTP id w189so3348531vkf.2 for ; Wed, 28 Oct 2015 05:20:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=D7R6tsQtn7j5F4RInWvcmHA4Zg0GShKpYBB7RMPEtJo=; b=g1jTokZokOjLDt/RfirwWTe3hC1gI60sAtEkf4kJLZYj356ARA66+5EuGbhl8JpMSM XgiB8cLkZAN1wNxRG/VCVKbfVUfYjuJ5Pjm7BH87c4kBk3ecF+hQyqWfGQ9RLvTfEP3v 0cUmUriztGTplwftMkJxXxOYKmWrZJBjO1y4j4Nf1j6nh+oRlWCoh8ZHBqeAi4Ty/OdU OzeLtRIPuhnk+ts9RmDZfEhZXOkl3yPKl3/XMpiDI2CIIHZLMCFcQvqdPTfLlo/YeMon xn5oUyx/ueLYs0lrSXTZjjKw/AaT90/IHzc8irZ+bzMKM3BjAHmzk9l1ZwYF6ApeFJQ9 WX0A== X-Received: by 10.31.108.74 with SMTP id h71mr30368360vkc.57.1446034840732; Wed, 28 Oct 2015 05:20:40 -0700 (PDT) Received: from localhost.localdomain ([179.159.5.130]) by smtp.gmail.com with ESMTPSA id y66sm8592944vky.12.2015.10.28.05.20.39 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 28 Oct 2015 05:20:40 -0700 (PDT) From: Fabio Estevam To: davem@davemloft.net Cc: netdev@vger.kernel.org, Fabio Estevam Subject: [PATCH] fec: Use gpio_set_value_cansleep() Date: Wed, 28 Oct 2015 10:20:30 -0200 Message-Id: <1446034830-13640-1-git-send-email-festevam@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Fabio Estevam We are in a context where we can sleep, and the FEC PHY reset gpio may be on an I2C expander. Use the cansleep() variant when setting the GPIO value. Based on a patch from Russell King for pci-mvebu.c. Signed-off-by: Fabio Estevam --- drivers/net/ethernet/freescale/fec_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c index 501e143..b2a3220 100644 --- a/drivers/net/ethernet/freescale/fec_main.c +++ b/drivers/net/ethernet/freescale/fec_main.c @@ -3261,7 +3261,7 @@ static void fec_reset_phy(struct platform_device *pdev) return; } msleep(msec); - gpio_set_value(phy_reset, 1); + gpio_set_value_cansleep(phy_reset, 1); } #else /* CONFIG_OF */ static void fec_reset_phy(struct platform_device *pdev)