From patchwork Wed Oct 21 17:00:20 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Scott Feldman X-Patchwork-Id: 533961 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id B2E7B140DB4 for ; Thu, 22 Oct 2015 03:57:25 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=QJCgZua7; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755942AbbJUQ5W (ORCPT ); Wed, 21 Oct 2015 12:57:22 -0400 Received: from mail-pa0-f54.google.com ([209.85.220.54]:36002 "EHLO mail-pa0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753748AbbJUQ5V (ORCPT ); Wed, 21 Oct 2015 12:57:21 -0400 Received: by pacfv9 with SMTP id fv9so62215287pac.3 for ; Wed, 21 Oct 2015 09:57:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=MpUJ1sdDMoyo28vrmUUZLQD29418ua1VIawQUqonDjU=; b=QJCgZua7tBiECbdUXYVfGS29mWsrPQF63yrZckrwkSjSiZqnWQFeyM48WOu94CRQJU aEY8YLah9riqmXyN/9FgWpD2gICwpLmKpacF+xco8H4ysyEiBzYmbbE2K11mz50Etjf0 L8+816x32f2rngUHL3KtD7myzqkhYwu0/uwpDz4hYBYa2mT1AUqyDT+Apl8taV/uFvg9 nnx7Uqwl6CJBvvScfqWZN2svrxrz3Emm1CXzTmySRNsJnN7TzFQjFtbRb2wHdmz1jgLB clxCyEjaE62kBMCHBvFaNNHsS1gKQaZAPQ9WHElycvgS8ZaEDRNDKTDC22KHxsm2P5na TEEA== X-Received: by 10.68.91.193 with SMTP id cg1mr11726591pbb.98.1445446640655; Wed, 21 Oct 2015 09:57:20 -0700 (PDT) Received: from rocker1.rocker.net ([199.58.98.35]) by smtp.gmail.com with ESMTPSA id xm9sm10077139pbc.32.2015.10.21.09.57.19 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 21 Oct 2015 09:57:20 -0700 (PDT) From: sfeldma@gmail.com To: netdev@vger.kernel.org Cc: jiri@resnulli.us, vivien.didelot@savoirfairelinux.com Subject: [PATCH net-next v2 2/3] switchdev: fix: pass correct obj size when deferring obj add/del Date: Wed, 21 Oct 2015 10:00:20 -0700 Message-Id: <1445446821-26147-2-git-send-email-sfeldma@gmail.com> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1445446821-26147-1-git-send-email-sfeldma@gmail.com> References: <1445446821-26147-1-git-send-email-sfeldma@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Scott Feldman Fixes: 4d429c5dd ("switchdev: introduce possibility to defer obj_add/del") Signed-off-by: Scott Feldman Acked-by: Jiri Pirko --- v1->v2: use correct "Fixes" tag, use common func to calc obj size for add/del net/switchdev/switchdev.c | 19 +++++++++++++++++-- 1 file changed, 17 insertions(+), 2 deletions(-) diff --git a/net/switchdev/switchdev.c b/net/switchdev/switchdev.c index 56d8479..bff8e2b 100644 --- a/net/switchdev/switchdev.c +++ b/net/switchdev/switchdev.c @@ -336,6 +336,21 @@ int switchdev_port_attr_set(struct net_device *dev, } EXPORT_SYMBOL_GPL(switchdev_port_attr_set); +static size_t switchdev_obj_size(const struct switchdev_obj *obj) +{ + switch (obj->id) { + case SWITCHDEV_OBJ_ID_PORT_VLAN: + return sizeof(struct switchdev_obj_port_vlan); + case SWITCHDEV_OBJ_ID_IPV4_FIB: + return sizeof(struct switchdev_obj_ipv4_fib); + case SWITCHDEV_OBJ_ID_PORT_FDB: + return sizeof(struct switchdev_obj_port_fdb); + default: + BUG(); + } + return 0; +} + static int __switchdev_port_obj_add(struct net_device *dev, const struct switchdev_obj *obj, struct switchdev_trans *trans) @@ -421,7 +436,7 @@ static void switchdev_port_obj_add_deferred(struct net_device *dev, static int switchdev_port_obj_add_defer(struct net_device *dev, const struct switchdev_obj *obj) { - return switchdev_deferred_enqueue(dev, obj, sizeof(*obj), + return switchdev_deferred_enqueue(dev, obj, switchdev_obj_size(obj), switchdev_port_obj_add_deferred); } @@ -489,7 +504,7 @@ static void switchdev_port_obj_del_deferred(struct net_device *dev, static int switchdev_port_obj_del_defer(struct net_device *dev, const struct switchdev_obj *obj) { - return switchdev_deferred_enqueue(dev, obj, sizeof(*obj), + return switchdev_deferred_enqueue(dev, obj, switchdev_obj_size(obj), switchdev_port_obj_del_deferred); }