From patchwork Wed Oct 7 03:46:07 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexei Starovoitov X-Patchwork-Id: 527087 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3E7D1140D72 for ; Wed, 7 Oct 2015 14:46:20 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753157AbbJGDqQ (ORCPT ); Tue, 6 Oct 2015 23:46:16 -0400 Received: from mail-pa0-f53.google.com ([209.85.220.53]:36086 "EHLO mail-pa0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753128AbbJGDqP (ORCPT ); Tue, 6 Oct 2015 23:46:15 -0400 Received: by pablk4 with SMTP id lk4so7180964pab.3 for ; Tue, 06 Oct 2015 20:46:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=7OAXI8b3Z9ehTwbiOHL8SP8oM49ABiBj82E1TT3jbdk=; b=mexHCBbtaT4byofrlUQRQ29nQXabggICnhu+cfVUl6GrKaoJqvvvmHiwv7ns+vGRha 2cPVK+kKkCNtRJL+Zile/m+Ea9+2hiE729D+P6EiDzdBEkVB2OXgRFoTOOxFQOLx73EL 2uCV5AXpFbFn6yV43twtBPLE7jDtSVvu+zGwFvPmRfTY4cVjKXKrkzc+pto0RRT7IedW tga437tZbco2fyW7cc9yV3M/tpirxex+XnoPG1+NyqNu5yQcNuSHWjv3M4vsYjDMpWJB 7X4cYwQVt2NTMyapUJa4XRyNqXnBLukdA7y5uFtQWdHV9NaCD0Xxqh+R2lw9S1l2YwyI Fomw== X-Gm-Message-State: ALoCoQlbmJ6dVdWNe4PJ2rQDwIhR068hrkx/EJnw7SouZMH1t2S7dWW/FXnLIFQtVNoVSjp9oIHl X-Received: by 10.66.253.199 with SMTP id ac7mr50423849pad.56.1444189574826; Tue, 06 Oct 2015 20:46:14 -0700 (PDT) Received: from localhost.localdomain ([12.97.19.195]) by smtp.gmail.com with ESMTPSA id uc1sm36464353pab.20.2015.10.06.20.46.13 (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 06 Oct 2015 20:46:14 -0700 (PDT) From: Alexei Starovoitov To: "David S. Miller" Cc: Daniel Borkmann , Eric Dumazet , netdev@vger.kernel.org Subject: [PATCH net] bpf: clear sender_cpu before xmit Date: Tue, 6 Oct 2015 20:46:07 -0700 Message-Id: <1444189567-3031-1-git-send-email-ast@plumgrid.com> X-Mailer: git-send-email 1.7.9.5 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Similar to commit c29390c6dfee ("xps: must clear sender_cpu before forwarding") the skb->sender_cpu needs to be cleared before xmit. Fixes: 3896d655f4d4 ("bpf: introduce bpf_clone_redirect() helper") Signed-off-by: Alexei Starovoitov Acked-by: Daniel Borkmann --- That is similar to pending patches for xps: http://patchwork.ozlabs.org/patch/526952/ and for act_mirred: http://patchwork.ozlabs.org/patch/527066/ though Fixes tag is different, since bpf_clone_redirect() came in after commit 2bd82484bb4c ("xps: fix xps for stacked devices") --- net/core/filter.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/core/filter.c b/net/core/filter.c index 87b78ef0c3d4..bb18c3680001 100644 --- a/net/core/filter.c +++ b/net/core/filter.c @@ -1415,6 +1415,7 @@ static u64 bpf_clone_redirect(u64 r1, u64 ifindex, u64 flags, u64 r4, u64 r5) return dev_forward_skb(dev, skb2); skb2->dev = dev; + skb_sender_cpu_clear(skb2); return dev_queue_xmit(skb2); }