From patchwork Fri Sep 25 21:31:32 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Estevam X-Patchwork-Id: 523010 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 9F51B140770 for ; Sat, 26 Sep 2015 07:32:03 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=WChoY/v0; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757102AbbIYVb5 (ORCPT ); Fri, 25 Sep 2015 17:31:57 -0400 Received: from mail-qg0-f41.google.com ([209.85.192.41]:36366 "EHLO mail-qg0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755457AbbIYVb4 (ORCPT ); Fri, 25 Sep 2015 17:31:56 -0400 Received: by qgx61 with SMTP id 61so80245316qgx.3 for ; Fri, 25 Sep 2015 14:31:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=w21vJMl8x8As/RFGtZSEjMiV9ewVuEuw4cGnKxkGZOA=; b=WChoY/v0Wa4/WRagaVA254t84edTVx/6z+qns6edJOrqCiScnzec53rymxoSoTsflq ucIHH6Ld+nmkwKhg8BrvEIa3gox+B4gLtAxFqacQKVZo9quB4FCC4+A600YXf4Dy8NnN 9tpYI7zqFaCP4T/982F1Z0SU7E2HYi5JaqW3pljflZbHOc7l8DJPdikq/qAqM0FXdPvJ Up8LOKppaYBy1adPFO8mlHlznKYExu/kN8nfHhyF9a6rvXFsLJJicfUfdcQY5EcvdUuu 7wa0RWoXakxbn12qDKcIcZaAx4eWHC0RUlTWFoLkf53pI6kFTQ3WzW7jCK/ffEqg4ZkR roxA== X-Received: by 10.140.129.212 with SMTP id 203mr9342366qhb.46.1443216715919; Fri, 25 Sep 2015 14:31:55 -0700 (PDT) Received: from localhost.localdomain ([189.5.19.77]) by smtp.gmail.com with ESMTPSA id w138sm2236575qkw.40.2015.09.25.14.31.54 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 25 Sep 2015 14:31:55 -0700 (PDT) From: Fabio Estevam To: davem@davemloft.net Cc: netdev@vger.kernel.org, Fabio Estevam Subject: [PATCH] net: fec: Remove unneeded FEATURES_NEED_QUIESCE definition Date: Fri, 25 Sep 2015 18:31:32 -0300 Message-Id: <1443216692-29042-1-git-send-email-festevam@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Fabio Estevam There is no need to have FEATURES_NEED_QUIESCE defined as we can simply use NETIF_F_RXCSUM instead as done in other parts of the driver. Signed-off-by: Fabio Estevam --- drivers/net/ethernet/freescale/fec_main.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c index dd4ca39..501e143 100644 --- a/drivers/net/ethernet/freescale/fec_main.c +++ b/drivers/net/ethernet/freescale/fec_main.c @@ -3070,7 +3070,6 @@ static void fec_poll_controller(struct net_device *dev) } #endif -#define FEATURES_NEED_QUIESCE NETIF_F_RXCSUM static inline void fec_enet_set_netdev_features(struct net_device *netdev, netdev_features_t features) { @@ -3094,7 +3093,7 @@ static int fec_set_features(struct net_device *netdev, struct fec_enet_private *fep = netdev_priv(netdev); netdev_features_t changed = features ^ netdev->features; - if (netif_running(netdev) && changed & FEATURES_NEED_QUIESCE) { + if (netif_running(netdev) && changed & NETIF_F_RXCSUM) { napi_disable(&fep->napi); netif_tx_lock_bh(netdev); fec_stop(netdev);