From patchwork Thu Sep 24 10:16:53 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sudip Mukherjee X-Patchwork-Id: 522218 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 5A5A614029C for ; Thu, 24 Sep 2015 20:17:24 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=Ck1+wfz2; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752819AbbIXKRF (ORCPT ); Thu, 24 Sep 2015 06:17:05 -0400 Received: from mail-pa0-f53.google.com ([209.85.220.53]:35786 "EHLO mail-pa0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752047AbbIXKRE (ORCPT ); Thu, 24 Sep 2015 06:17:04 -0400 Received: by pacfv12 with SMTP id fv12so70423403pac.2; Thu, 24 Sep 2015 03:17:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=oPnTsa8Nzg6nL2xZ4itk0+98SjFENDb5LyqJGrSv5zo=; b=Ck1+wfz2GUBCoCoF0drh3+IUcI19GJd0AQ8r8/vMdAtCf98PDkoaOBU9nSEaaBrLmn rnG32dHp0HWKAe6//rVtUUoLEAVXwhRyf936p0BleyrecqmWYlYUSDWHBz7XkjKL8D58 XczMAN1Bswy2pJfSQurRynMupe7P+GsEDz2zQ//aIu/ffBYtI6PqX/ib4UnulO1DF0Hg KCvSyJ9qtU6dsYFcLW6G/d2/yMN30LsSD3DS0XuG8VQu7I33u5tpzgl8rG+2z0XtB0jc Ws6TOxS9uS3pAoi0InPykBM7FVIqyvTBh6zPmq5uBINjt60/2qxhM5oLQqm2ZdEFPKJi xccw== X-Received: by 10.68.227.8 with SMTP id rw8mr44087707pbc.74.1443089823242; Thu, 24 Sep 2015 03:17:03 -0700 (PDT) Received: from localhost.localdomain ([49.206.240.178]) by smtp.gmail.com with ESMTPSA id uc1sm12856265pab.20.2015.09.24.03.17.00 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 24 Sep 2015 03:17:02 -0700 (PDT) From: Sudip Mukherjee To: "David S. Miller" , Hans-Christian Egtvedt Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Andrew Morton , Sudip Mukherjee Subject: [PATCH] net: via/Kconfig: GENERIC_PCI_IOMAP required if PCI not selected Date: Thu, 24 Sep 2015 15:46:53 +0530 Message-Id: <1443089813-10967-1-git-send-email-sudipm.mukherjee@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The builds of allmodconfig of avr32 is failing with: drivers/net/ethernet/via/via-rhine.c:1098:2: error: implicit declaration of function 'pci_iomap' [-Werror=implicit-function-declaration] drivers/net/ethernet/via/via-rhine.c:1119:2: error: implicit declaration of function 'pci_iounmap' [-Werror=implicit-function-declaration] The generic empty pci_iomap and pci_iounmap is used only if CONFIG_PCI is not defined and CONFIG_GENERIC_PCI_IOMAP is defined. Add GENERIC_PCI_IOMAP in the dependency list for VIA_RHINE as we are getting build failure when CONFIG_PCI and CONFIG_GENERIC_PCI_IOMAP both are not defined. Signed-off-by: Sudip Mukherjee --- Failed build log is at: https://travis-ci.org/sudipm-mukherjee/parport/jobs/81127188 An exactly similar patch has been posted earlier and relevant discussion is at: https://patchwork.ozlabs.org/patch/498722/ I posted a patch to include empty pci_iomap, pci_iounmap in avr32. That discussion is at: https://lkml.org/lkml/2015/9/19/100 drivers/net/ethernet/via/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/via/Kconfig b/drivers/net/ethernet/via/Kconfig index 2f1264b..17831e5 100644 --- a/drivers/net/ethernet/via/Kconfig +++ b/drivers/net/ethernet/via/Kconfig @@ -17,7 +17,7 @@ if NET_VENDOR_VIA config VIA_RHINE tristate "VIA Rhine support" - depends on (PCI || OF_IRQ) + depends on (PCI || (OF_IRQ && GENERIC_PCI_IOMAP)) depends on HAS_DMA select CRC32 select MII