From patchwork Wed Sep 23 15:39:16 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Scott Feldman X-Patchwork-Id: 521743 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 69A1D1401AF for ; Thu, 24 Sep 2015 01:36:18 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=DEwxI6Y3; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755377AbbIWPgO (ORCPT ); Wed, 23 Sep 2015 11:36:14 -0400 Received: from mail-pa0-f41.google.com ([209.85.220.41]:34859 "EHLO mail-pa0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754033AbbIWPgM (ORCPT ); Wed, 23 Sep 2015 11:36:12 -0400 Received: by pacfv12 with SMTP id fv12so44232742pac.2 for ; Wed, 23 Sep 2015 08:36:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=00TGqoGEub5sBgHEi81xHjT1Gr7urH4DyaSvcRzdWFk=; b=DEwxI6Y3B8N2UqvUah/Dmb38Pt6uA7DDI2jtFaw2mj88XO0szEr02WlWftPuT5mlWH etZvxWtIrHwJp/tz9YXMo2O9b0JJna5vPWTsbm9baR1x6SUfU9d/8EN3et7wIQJM5LjD i7AcZSFrP40cSmjylaNV8rVMMfBcFXRJGRozUSId9Oxar0OmSa9HzfXautTmGUof8Kng Xe9c2PRM4QDUEnWB7trdq+LDn+qpxdeHJokKvmJ+FmBu3BMdawt7Y3zgOIPb8HVtzFNb 7RKHwB3CI+TcZYcLnDMqjjY8i/NLs2yWfl4W+tnQBHzCceKgRJlW8bP8qTB2h5fy09PN 0T+A== X-Received: by 10.66.146.69 with SMTP id ta5mr38763389pab.46.1443022571612; Wed, 23 Sep 2015 08:36:11 -0700 (PDT) Received: from rocker1.rocker.net ([199.58.98.143]) by smtp.gmail.com with ESMTPSA id rw8sm4245565pac.11.2015.09.23.08.36.10 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 23 Sep 2015 08:36:11 -0700 (PDT) From: sfeldma@gmail.com To: netdev@vger.kernel.org Cc: davem@davemloft.net, jiri@resnulli.us, siva.mannem.lnx@gmail.com, pjonnala@broadcom.com, stephen@networkplumber.org, roopa@cumulusnetworks.com, andrew@lunn.ch, f.fainelli@gmail.com, vivien.didelot@savoirfairelinux.com Subject: [PATCH net-next v3 3/7] bridge: define some min/max/default ageing time constants Date: Wed, 23 Sep 2015 08:39:16 -0700 Message-Id: <1443022760-21301-4-git-send-email-sfeldma@gmail.com> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1443022760-21301-1-git-send-email-sfeldma@gmail.com> References: <1443022760-21301-1-git-send-email-sfeldma@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Scott Feldman Signed-off-by: Scott Feldman Acked-by: Jiri Pirko --- v2: Per Jiri review comment: add BR_DEFAULT_AGEING_TIME to defines include/linux/if_bridge.h | 6 ++++++ net/bridge/br_device.c | 2 +- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/include/linux/if_bridge.h b/include/linux/if_bridge.h index dad8b00..a338a68 100644 --- a/include/linux/if_bridge.h +++ b/include/linux/if_bridge.h @@ -46,6 +46,12 @@ struct br_ip_list { #define BR_LEARNING_SYNC BIT(9) #define BR_PROXYARP_WIFI BIT(10) +/* values as per ieee8021QBridgeFdbAgingTime */ +#define BR_MIN_AGEING_TIME (10 * HZ) +#define BR_MAX_AGEING_TIME (1000000 * HZ) + +#define BR_DEFAULT_AGEING_TIME (300 * HZ) + extern void brioctl_set(int (*ioctl_hook)(struct net *, unsigned int, void __user *)); typedef int br_should_route_hook_t(struct sk_buff *skb); diff --git a/net/bridge/br_device.c b/net/bridge/br_device.c index 6ed2feb..2f81624 100644 --- a/net/bridge/br_device.c +++ b/net/bridge/br_device.c @@ -391,7 +391,7 @@ void br_dev_setup(struct net_device *dev) br->bridge_max_age = br->max_age = 20 * HZ; br->bridge_hello_time = br->hello_time = 2 * HZ; br->bridge_forward_delay = br->forward_delay = 15 * HZ; - br->ageing_time = 300 * HZ; + br->ageing_time = BR_DEFAULT_AGEING_TIME; br_netfilter_rtable_init(br); br_stp_timer_init(br);