From patchwork Mon Sep 21 13:33:59 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrzej Hajda X-Patchwork-Id: 520303 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id A22BE1401DE for ; Mon, 21 Sep 2015 23:43:34 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932140AbbIUNlR (ORCPT ); Mon, 21 Sep 2015 09:41:17 -0400 Received: from mailout4.w1.samsung.com ([210.118.77.14]:40457 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932428AbbIUNg0 (ORCPT ); Mon, 21 Sep 2015 09:36:26 -0400 Received: from eucpsbgm2.samsung.com (unknown [203.254.199.245]) by mailout4.w1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0NV100MUI4GLDS30@mailout4.w1.samsung.com>; Mon, 21 Sep 2015 14:36:21 +0100 (BST) X-AuditID: cbfec7f5-f794b6d000001495-60-560007d543be Received: from eusync3.samsung.com ( [203.254.199.213]) by eucpsbgm2.samsung.com (EUCPMTA) with SMTP id A7.67.05269.5D700065; Mon, 21 Sep 2015 14:36:21 +0100 (BST) Received: from AMDC1061.digital.local ([106.116.147.88]) by eusync3.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0NV100LNT4DTKI10@eusync3.samsung.com>; Mon, 21 Sep 2015 14:36:21 +0100 (BST) From: Andrzej Hajda To: linux-kernel@vger.kernel.org Cc: Andrzej Hajda , Bartlomiej Zolnierkiewicz , Marek Szyprowski , Steve Glendinning , "David S. Miller" , "Woojung.Huh@microchip.com" , linux-usb@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH 27/38] usbnet: remove invalid check Date: Mon, 21 Sep 2015 15:33:59 +0200 Message-id: <1442842450-29769-28-git-send-email-a.hajda@samsung.com> X-Mailer: git-send-email 1.9.1 In-reply-to: <1442842450-29769-1-git-send-email-a.hajda@samsung.com> References: <1442842450-29769-1-git-send-email-a.hajda@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprLLMWRmVeSWpSXmKPExsVy+t/xq7pX2RnCDNad4rW4te4cq8XGGetZ Leacb2GxuLxrDpvFomWtzBZrj9xltzi2QMyi+dMrJouJv0+xO3B6bFl5k8njzo+ljB59W1Yx evxvvszi8XmTXABrFJdNSmpOZllqkb5dAlfGj+enWQve8lZMnR3ZwLibu4uRk0NCwETi2dEW NghbTOLCvfVANheHkMBSRokdq2+xQzhNTBLHNuwDq2IT0JT4u/kmmC0ioCCxufcZK0gRs8A9 JonPJ9uZQBLCAsYS7Vf3soPYLAKqEjcuHmAEsXkFXCTWbWxhhlgnJ3Hy2GRWEJsTKH7g4BcW EFtIwFniwJIjTBMYeRcwMqxiFE0tTS4oTkrPNdIrTswtLs1L10vOz93ECAm0rzsYlx6zOsQo wMGoxMPrKPA/VIg1say4MvcQowQHs5IIr84soBBvSmJlVWpRfnxRaU5q8SFGaQ4WJXHembve hwgJpCeWpGanphakFsFkmTg4pRoYJzGceb7vmsuqV5Nlny/4d076QK3qhjKTe4y/FpZ9FV2m 0lAuPfvcjsnTyyYqa+ytPblXQVLBXEHB2fTL0r0db++8tL+f3s0SI+QzK71i3ZsbrQef6IWp Xd/65wZHs5vs2etSYcJapx9FmKzumu2TfK1Qg9d35vKF55eo7pO+vW9mhdP22fYsR5VYijMS DbWYi4oTAchg9i8wAgAA Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org skb->len is always non-negative. The problem has been detected using proposed semantic patch scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2038576 Signed-off-by: Andrzej Hajda --- drivers/net/usb/lan78xx.c | 5 ----- drivers/net/usb/smsc75xx.c | 5 ----- drivers/net/usb/smsc95xx.c | 5 ----- 3 files changed, 15 deletions(-) diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx.c index a39518f..e0556dc 100644 --- a/drivers/net/usb/lan78xx.c +++ b/drivers/net/usb/lan78xx.c @@ -2522,11 +2522,6 @@ static int lan78xx_rx(struct lan78xx_net *dev, struct sk_buff *skb) skb_pull(skb, align_count); } - if (unlikely(skb->len < 0)) { - netdev_warn(dev->net, "invalid rx length<0 %d", skb->len); - return 0; - } - return 1; } diff --git a/drivers/net/usb/smsc75xx.c b/drivers/net/usb/smsc75xx.c index d9e7892..30033db 100644 --- a/drivers/net/usb/smsc75xx.c +++ b/drivers/net/usb/smsc75xx.c @@ -2185,11 +2185,6 @@ static int smsc75xx_rx_fixup(struct usbnet *dev, struct sk_buff *skb) skb_pull(skb, align_count); } - if (unlikely(skb->len < 0)) { - netdev_warn(dev->net, "invalid rx length<0 %d\n", skb->len); - return 0; - } - return 1; } diff --git a/drivers/net/usb/smsc95xx.c b/drivers/net/usb/smsc95xx.c index 26423ad..66b3ab9 100644 --- a/drivers/net/usb/smsc95xx.c +++ b/drivers/net/usb/smsc95xx.c @@ -1815,11 +1815,6 @@ static int smsc95xx_rx_fixup(struct usbnet *dev, struct sk_buff *skb) skb_pull(skb, align_count); } - if (unlikely(skb->len < 0)) { - netdev_warn(dev->net, "invalid rx length<0 %d\n", skb->len); - return 0; - } - return 1; }