From patchwork Mon Sep 21 13:33:53 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrzej Hajda X-Patchwork-Id: 520305 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 5CAC51401DE for ; Mon, 21 Sep 2015 23:44:03 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932324AbbIUNgY (ORCPT ); Mon, 21 Sep 2015 09:36:24 -0400 Received: from mailout2.w1.samsung.com ([210.118.77.12]:37352 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932311AbbIUNgU (ORCPT ); Mon, 21 Sep 2015 09:36:20 -0400 Received: from eucpsbgm1.samsung.com (unknown [203.254.199.244]) by mailout2.w1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0NV1005VP4GISJ60@mailout2.w1.samsung.com>; Mon, 21 Sep 2015 14:36:19 +0100 (BST) X-AuditID: cbfec7f4-f79c56d0000012ee-de-560007d22123 Received: from eusync3.samsung.com ( [203.254.199.213]) by eucpsbgm1.samsung.com (EUCPMTA) with SMTP id B8.67.04846.2D700065; Mon, 21 Sep 2015 14:36:18 +0100 (BST) Received: from AMDC1061.digital.local ([106.116.147.88]) by eusync3.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0NV100LNT4DTKI10@eusync3.samsung.com>; Mon, 21 Sep 2015 14:36:18 +0100 (BST) From: Andrzej Hajda To: linux-kernel@vger.kernel.org Cc: Andrzej Hajda , Bartlomiej Zolnierkiewicz , Marek Szyprowski , Amitkumar Karwar , Nishant Sarmukadam , Kalle Valo , linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH 21/38] mwifiex: fix comparison expression Date: Mon, 21 Sep 2015 15:33:53 +0200 Message-id: <1442842450-29769-22-git-send-email-a.hajda@samsung.com> X-Mailer: git-send-email 1.9.1 In-reply-to: <1442842450-29769-1-git-send-email-a.hajda@samsung.com> References: <1442842450-29769-1-git-send-email-a.hajda@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprJLMWRmVeSWpSXmKPExsVy+t/xq7qX2BnCDM69ULe4te4cq0X/tn3M FhtnrGe1WLRyIZvF5V1z2CzerLjDbrH2yF12i2MLxCwuPN/M7sDpcbmvl8lj8sKLzB59W1Yx enzeJBfAEsVlk5Kak1mWWqRvl8CV8fTTTuaCfZwV+z+9YG9g/MDexcjJISFgIvFz5XxGCFtM 4sK99WxdjFwcQgJLGSUOrT7GCuE0MUmsX3MarINNQFPi7+abbCC2iICCxObeZ2BFzAKHmCRW XXvPDJIQFrCUaNz2GMxmEVCV+Lt2JQuIzSvgIjGncQLUajmJk8cms4LYnEDxAwe/gNUICThL HFhyhGkCI+8CRoZVjKKppckFxUnpuYZ6xYm5xaV56XrJ+bmbGCEB9mUH4+JjVocYBTgYlXh4 HQT+hwqxJpYVV+YeYpTgYFYS4dWZBRTiTUmsrEotyo8vKs1JLT7EKM3BoiTOO3fX+xAhgfTE ktTs1NSC1CKYLBMHp1QD44SFLxNXG/3c3sjrHvvo0qS5HmncDcJc746yJyh7fHl0/vi7UoFs 59Dz5868ad8+rfIX376HXn8yi6TlJ3yenSW5luUGM4+aEY+rxN1p04Ma5S4n6ld/q3t0IEik Mf3vbOETfip69pKulVOOd7Udmr4n0n9K8aM6lqIXK1k/+psearwW+qqsT4mlOCPRUIu5qDgR ABNWuM8sAgAA Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org To avoid underflows signed variables should be used in expression. The problem has been detected using proposed semantic patch scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2038576 Signed-off-by: Andrzej Hajda Acked-by: Amitkumar Karwar --- drivers/net/wireless/mwifiex/11n_rxreorder.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/mwifiex/11n_rxreorder.c b/drivers/net/wireless/mwifiex/11n_rxreorder.c index 2906cd5..b3970a8 100644 --- a/drivers/net/wireless/mwifiex/11n_rxreorder.c +++ b/drivers/net/wireless/mwifiex/11n_rxreorder.c @@ -615,10 +615,10 @@ int mwifiex_11n_rx_reorder_pkt(struct mwifiex_private *priv, ((end_win > start_win) && ((seq_num > end_win) || (seq_num < start_win)))) { end_win = seq_num; - if (((seq_num - win_size) + 1) >= 0) + if (((end_win - win_size) + 1) >= 0) start_win = (end_win - win_size) + 1; else - start_win = (MAX_TID_VALUE - (win_size - seq_num)) + 1; + start_win = (MAX_TID_VALUE - (win_size - end_win)) + 1; mwifiex_11n_dispatch_pkt_until_start_win(priv, tbl, start_win); }