| Message ID | 1442002119-15823-1-git-send-email-cascardo@redhat.com |
|---|---|
| State | Superseded, archived |
| Delegated to: | David Miller |
| Headers | show |
On 15-09-11 01:08 PM, Thadeu Lima de Souza Cascardo wrote: > Redo commit ed1acc8cd8c22efa919da8d300bab646e01c2dce. > > Commit 822b3b2ebfff8e9b3d006086c527738a7ca00cd0 ("net: Add max rate tx queue > attribute") moved get_netdev_queue_index around, but kept the old version. > Probably because of a reuse of the original patch from before Eric's change to > that function. > > Remove one inline keyword, and no need for a loop to find > an index into a table. > > Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@redhat.com> > Fixes: 822b3b2ebfff8e9b3d006086c527738a7ca00cd0 > Cc: Or Gerlitz <ogerlitz@mellanox.com> > Cc: John Fastabend <john.r.fastabend@intel.com> > Cc: Eric Dumazet <edumazet@google.com> > --- > > Not sure what is the best way to credit Eric Dumazet here. I assume he will add > any appropriate tags. > Yep, I guess Or just overlooked this and I missed it in the review when the patch was submitted. Thanks! Acked-by: John Fastabend <john.r.fastabend@intel.com> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 9/11/2015 11:08 PM, Thadeu Lima de Souza Cascardo wrote: > Redo commit ed1acc8cd8c22efa919da8d300bab646e01c2dce. > > Commit 822b3b2ebfff8e9b3d006086c527738a7ca00cd0 ("net: Add max rate tx queue > attribute") moved get_netdev_queue_index around, but kept the old version. > Probably because of a reuse of the original patch from before Eric's change to > that function. > > Remove one inline keyword, and no need for a loop to find > an index into a table. > > Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@redhat.com> > Fixes: 822b3b2ebfff8e9b3d006086c527738a7ca00cd0 Please use here a --abbrev=12 generated short log e.g Fixes: 22b3b2ebfff ('net: Add max rate tx queue attribute') > Cc: Or Gerlitz <ogerlitz@mellanox.com> remove the Cc: line for me and add this one (hate to see myself mentioned twice here...) Acked-by: Or Gerlitz <ogerlitz@mellanox.com> Good catch! -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/core/net-sysfs.c b/net/core/net-sysfs.c index b279077..49b5990 100644 --- a/net/core/net-sysfs.c +++ b/net/core/net-sysfs.c @@ -1004,15 +1004,12 @@ static ssize_t show_trans_timeout(struct netdev_queue *queue, } #ifdef CONFIG_XPS -static inline unsigned int get_netdev_queue_index(struct netdev_queue *queue) +static unsigned int get_netdev_queue_index(struct netdev_queue *queue) { struct net_device *dev = queue->dev; - int i; - - for (i = 0; i < dev->num_tx_queues; i++) - if (queue == &dev->_tx[i]) - break; + unsigned int i; + i = queue - dev->_tx; BUG_ON(i >= dev->num_tx_queues); return i;
Redo commit ed1acc8cd8c22efa919da8d300bab646e01c2dce. Commit 822b3b2ebfff8e9b3d006086c527738a7ca00cd0 ("net: Add max rate tx queue attribute") moved get_netdev_queue_index around, but kept the old version. Probably because of a reuse of the original patch from before Eric's change to that function. Remove one inline keyword, and no need for a loop to find an index into a table. Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@redhat.com> Fixes: 822b3b2ebfff8e9b3d006086c527738a7ca00cd0 Cc: Or Gerlitz <ogerlitz@mellanox.com> Cc: John Fastabend <john.r.fastabend@intel.com> Cc: Eric Dumazet <edumazet@google.com> --- Not sure what is the best way to credit Eric Dumazet here. I assume he will add any appropriate tags. --- net/core/net-sysfs.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-)